Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 15:52:55 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Prathamesh Shete <pshete@nvidia.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        jonathanh@nvidia.com, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        smangipudi@nvidia.com, kyarlagadda@nvidia.com, anrao@nvidia.com
Subject: Re: [PATCH v3] arm64: tegra: Add Tegra234 SDMMC1 device tree node
Message-ID: <Y1aYt6mvD9NCPc9C@orome>
References: <7bf3f70a-4af6-c62a-75fc-89591d5de04b@linaro.org>
 <20221007165941.16539-1-pshete@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wzwNODuKfDHQoYpG"
Content-Disposition: inline
In-Reply-To: <20221007165941.16539-1-pshete@nvidia.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--wzwNODuKfDHQoYpG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 07, 2022 at 10:29:41PM +0530, Prathamesh Shete wrote:
> Add device tree node for Tegra234 SDMMC1 instance.
> Add and enable SD card instance in device tree.
>=20
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
>  .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  |  7 +++
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi      | 60 +++++++++++++++++++
>  2 files changed, 67 insertions(+)

Applied, with some minor changes (see below).

> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/a=
rm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
[...]
> +		mmc@3400000 {
> +			compatible =3D "nvidia,tegra194-sdhci", "nvidia,tegra234-sdhci";
> +			reg =3D <0x03400000 0x20000>;
> +			interrupts =3D <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks =3D <&bpmp TEGRA234_CLK_SDMMC1>,
> +				 <&bpmp TEGRA234_CLK_SDMMC_LEGACY_TM>;
> +			clock-names =3D "sdhci", "tmclk";
> +			assigned-clocks =3D <&bpmp TEGRA234_CLK_SDMMC1>,
> +					<&bpmp TEGRA234_CLK_PLLC4_MUXED>;

I've aligned these.

> +			assigned-clock-parents =3D
> +					  <&bpmp TEGRA234_CLK_PLLC4_MUXED>,

And put this on the previous line. checkpatch's character/row limit is
100, so let's use that.

> +					  <&bpmp TEGRA234_CLK_PLLC4_VCO_DIV2>;

> +			resets =3D <&bpmp TEGRA234_RESET_SDMMC1>;
> +			reset-names =3D "sdhci";
> +			interconnects =3D <&mc TEGRA234_MEMORY_CLIENT_SDMMCRA &emc>,
> +					<&mc TEGRA234_MEMORY_CLIENT_SDMMCWA &emc>;
> +			interconnect-names =3D "dma-mem", "write";
> +			iommus =3D <&smmu_niso1 TEGRA234_SID_SDMMC1A>;
> +			pinctrl-names =3D "sdmmc-3v3", "sdmmc-1v8";
> +			pinctrl-0 =3D <&sdmmc1_3v3>;
> +			pinctrl-1 =3D <&sdmmc1_1v8>;
> +			nvidia,pad-autocal-pull-up-offset-3v3-timeout =3D
> +								      <0x07>;
> +			nvidia,pad-autocal-pull-down-offset-3v3-timeout =3D
> +									<0x07>;
> +			nvidia,pad-autocal-pull-up-offset-1v8-timeout =3D <0x06>;
> +			nvidia,pad-autocal-pull-down-offset-1v8-timeout =3D
> +									<0x07>;

Same here.

Thanks,
Thierry

--wzwNODuKfDHQoYpG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNWmLcACgkQ3SOs138+
s6EPEhAArCthFJLRizBNMafRPRLeQdIn4Fb+3scor6my0Cmpk/H+g/axmMjnheIz
H2rFrVY8wo6EYi94ronDAdo0V5K2n7EMROdxeQy3oCbh2Iuo/TUiDbN6vgWQ9Xh1
ODDbc1DoEtS0ZRZj42DrjSENHUu3nM0Xim6wG0FxTWVJoDhHpCymw4jSe0HbZ9eu
rfnOXV1MGDw9RJQMhM6uoKUUgZzW6aNEHcVAHpvJ25G22kaV79pVQjzoXP7UuuOD
gckurjIZNz5iFvUTy8mJErcJms8txPg0kAEuEsAv/WtG5Hg0NMcSABOweJ6t87em
oVyuqVgAmO1xaXLxUbN0Sqs0n/8ca3J+1uguOB5chcuBIBcDbcQA7x+LZixEsS2S
uTMGBzCc7p9x36orTaqwRG8trFcINFmg68SVYJHiKbK4XNDJm505AJl8stlXNi1B
PwjeV/Cx/wLUoCpa06Xh7/3nQTW+KkL4gk0JRWlo9fsu32PhhwqRnSRENnIyq4oY
gIyEMLi2jt6mHojhJiYjS9JlPlMqLT+cjdyoiG/9A1cTtl9xokU3c0u0JgHZ3hUQ
B4sBeMEGU9VpdF/1fLUixzm2qvLCxprxKtXaAeiOzdPX2K9IcTp3L8xTGHw+OAhb
enofWbQ50GFh2bpuOkjWkQV7b0uHobQt90k7yZvWHpVw8O06o4k=
=YLVL
-----END PGP SIGNATURE-----

--wzwNODuKfDHQoYpG--