Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7024485rwi; Mon, 24 Oct 2022 08:56:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6D+9DjbmXCzOVI2V/Eb1RtRdptkEhU0ZhrhJWgqxzrRQ6fZSjw0LADGVaQREXddp6C1qhY X-Received: by 2002:a17:907:161f:b0:78e:11b3:8962 with SMTP id hb31-20020a170907161f00b0078e11b38962mr28745779ejc.0.1666626963547; Mon, 24 Oct 2022 08:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666626963; cv=none; d=google.com; s=arc-20160816; b=uUQAX05I1Z5jKRZCOsM2Fnn2cumGhqekC+T+eovTcpKd1vvUZueFdzB/M3oEaW97dt zvcPlEAyQt5tOOA+DwBOH3GY/HoKsZ5GDzb08yX2BIleUsosKJ0WaO9pYef6z+itqhkX kpYGMMeebhcOZx+wn7uWCVIZSL00vCY0lmeUSyVaEGyVIRkr8NPCUCu1XDJFIQ6vDV0n 02cbDOVGwt/Ndmq86KwqBr0ZGxYOeM4y4s15TLr6dH76zge3ghMyJ4WMc0xrSB3mM+Or MnXTAjhlELVe/SUG6WEVs3EhS+ButmYkiBhCTY3N0HSa98Xcb9Fy12VDmljtPNzz9p9e wRQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=47lY1cbXx63ca+OrPeEqnIjrVtRa889PBqaLWa9J9cM=; b=Q2vNs5oY0nJllbK2YFwo1dS63vl7tYkm1P0jcidk8oTj773PwKUEUnT0DFhNSXO2RK qk4DXuij9eng2KxctTf0GtKi7HBpP2xgIw690wiR9tnkHdzpqtG4ise8lYwznsLQVFsG MlmBnLMe+SUy/HdzwxtoGUDyOQfCgK1E5zmOO7KRtU4J1luATxAXlTV1oHpf5ZTiRzrn Y3odCZIqEwkkD223wz/3kgA8vyERiT6C1IFdBU3UwtX8HrBszuVyLfmQMna3MXjvh0Se gxkla7p5A69BLfanrd4Eos6nuTmOT4c7fEI/LvLlSBUiYwabXJUZQIdZn/Qebwl8A90n ixRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y01ZxZO4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m23-20020a509997000000b0045981993486si113863edb.227.2022.10.24.08.55.38; Mon, 24 Oct 2022 08:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y01ZxZO4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbiJXOGf (ORCPT + 99 others); Mon, 24 Oct 2022 10:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235523AbiJXOCu (ORCPT ); Mon, 24 Oct 2022 10:02:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A7A28050A; Mon, 24 Oct 2022 05:48:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3540B612A4; Mon, 24 Oct 2022 12:48:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46675C433D7; Mon, 24 Oct 2022 12:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615697; bh=s5bOhSlb/E/gFE2fhF4bPWtz8wcohG6L7kPb3tR1HAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y01ZxZO4kSPeCyamxYSf9dUjrJDUjR3DwqrhA553Y+dTxu5lytcEqO5tYbRpQwhRo 5eZZBIJ35KxeXPwrVvp7nKRW9e10UpQfz5jl+oc4QUlXN8aX2jesW4fhSgXX7uZ/Y4 FH+Fv5O0RBI6SmH54CnREnnshGer7sD9g2M4rHL8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, AngeloGioacchino Del Regno , Tianping Fang , Chunfeng Yun , Sasha Levin Subject: [PATCH 5.15 349/530] usb: mtu3: fix failed runtime suspend in host only mode Date: Mon, 24 Oct 2022 13:31:33 +0200 Message-Id: <20221024113100.799440692@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chunfeng Yun [ Upstream commit 1c703e29da5efac6180e4c189029fa34b7e48e97 ] When the dr_mode is "host", after the host enter runtime suspend, the mtu3 can't do it, because the mtu3's device wakeup function is not enabled, instead it's enabled in gadget init function, to fix the issue, init wakeup early in mtu3's probe() Fixes: 6b587394c65c ("usb: mtu3: support suspend/resume for dual-role mode") Reviewed-by: AngeloGioacchino Del Regno Reported-by: Tianping Fang Signed-off-by: Chunfeng Yun Link: https://lore.kernel.org/r/20220929064459.32522-1-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/mtu3/mtu3_core.c | 2 -- drivers/usb/mtu3/mtu3_plat.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c index c4a2c37abf62..3ea5145a842b 100644 --- a/drivers/usb/mtu3/mtu3_core.c +++ b/drivers/usb/mtu3/mtu3_core.c @@ -971,8 +971,6 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb) goto irq_err; } - device_init_wakeup(dev, true); - /* power down device IP for power saving by default */ mtu3_stop(mtu); diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index f13531022f4a..4c4dcbf17518 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -332,6 +332,8 @@ static int mtu3_probe(struct platform_device *pdev) pm_runtime_enable(dev); pm_runtime_get_sync(dev); + device_init_wakeup(dev, true); + ret = ssusb_rscs_init(ssusb); if (ret) goto comm_init_err; -- 2.35.1