Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7028559rwi; Mon, 24 Oct 2022 08:59:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6HxBm5rnTJAPnQ7GOlVTO9Zf2b/voVvsD8oZwlgCcy5ABl01gH+uOt4GSc05V4zOBj5z7V X-Received: by 2002:a17:907:d02:b0:7a3:de36:b67 with SMTP id gn2-20020a1709070d0200b007a3de360b67mr8303013ejc.451.1666627188899; Mon, 24 Oct 2022 08:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627188; cv=none; d=google.com; s=arc-20160816; b=yNWsk9Ku+NhSfJIUVjkJFfnzK7HIGhsK9RqKnCZ4RJuO/eLBHTmi5CHHEkS8+J68uJ PS19TZiqJDAjoU5hjSp/xmKlmE+HPtDAAZaH4tHX5N+yr/MsY8bqvTFbSEG9SyXG5E7Q Ny04zw/tIsGGxztlleznMLwG9xhr8dKcZk+qUa/lAlgscJsRC6ZdlVNp1aiF+ELY94w6 45RL1xUf6G8hzk3YSeDJEJwQOkvR0C249embyPtNrflg8FQGHzQwa3cOGnwO5fo1c8wQ UNE3XUAFM2niaXj/KqGIVEtJDVDYFexndwRyrs+H9C5oQeI/++mZA6s/Ct0oHSXRxHHF 9X2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ywnzyajHVH5P4coVgM62eanHHKFBJKO0DVFgQNg3oTM=; b=suMaSzER9wXpQVOlKCdLhdvn9UjpCNf9pJoMRSUQp9tpeB6gVhHzZnUU2l8/TA0qGk eR/swmGdalvdiRTLRQEx6Y95bEscD4Lw8krKQs9M41dJWSBAo6/3sm11mFM9HIn7efsz RTPkiT1Ow1pfuX2bQRYAGDVVXEXBHb0M9iW0pqMb2KWnipn94rmt1hXU1C8MIJ+mkbco bZZYggp4wZMyYM14ao5qUIqP84rXxcDag4e+uSCI6KkBbYnGcEumlIdtzp6TrjUy1p55 U+VVZTORvRiW92w0Hl5ag4G5H4OaMyhRwKrTQuGWaKO0rz1lhrWKZsELOCuMytlMLOlI xvcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Q9afi1B/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b8-20020a056402350800b0045caa8bf80bsi157524edd.307.2022.10.24.08.59.24; Mon, 24 Oct 2022 08:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Q9afi1B/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231464AbiJXOGK (ORCPT + 99 others); Mon, 24 Oct 2022 10:06:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235310AbiJXOCt (ORCPT ); Mon, 24 Oct 2022 10:02:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED94645054; Mon, 24 Oct 2022 05:48:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C51D061347; Mon, 24 Oct 2022 12:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD01AC433D6; Mon, 24 Oct 2022 12:38:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615138; bh=KqCEdkhPcHZPtHS5XUueyb73weNWSVVYIaiahVplhzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q9afi1B/kuysCin1rFzywseBKVsJKry9AUjLtTve/2GsL8HW0T+b72kY055XRavGn iJ2cgezY7vXGMJBE/c2De2AvoLt9nw+zVTDSNe6q0GgscIX6pj0QAyn1cg+D81nftn aO65G08UVQ+5f6b4eDyhPdVZJ1n0JT5yjC93+9ts= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jianglei Nie , Lyude Paul , Thierry Reding Subject: [PATCH 5.15 129/530] drm/nouveau: fix a use-after-free in nouveau_gem_prime_import_sg_table() Date: Mon, 24 Oct 2022 13:27:53 +0200 Message-Id: <20221024113050.893252016@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianglei Nie commit 540dfd188ea2940582841c1c220bd035a7db0e51 upstream. nouveau_bo_init() is backed by ttm_bo_init() and ferries its return code back to the caller. On failures, ttm will call nouveau_bo_del_ttm() and free the memory.Thus, when nouveau_bo_init() returns an error, the gem object has already been released. Then the call to nouveau_bo_ref() will use the freed "nvbo->bo" and lead to a use-after-free bug. We should delete the call to nouveau_bo_ref() to avoid the use-after-free. Signed-off-by: Jianglei Nie Reviewed-by: Lyude Paul Signed-off-by: Lyude Paul Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object") Cc: Thierry Reding Cc: # v5.4+ Link: https://patchwork.freedesktop.org/patch/msgid/20220705132546.2247677-1-niejianglei2021@163.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_prime.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_prime.c +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c @@ -71,7 +71,6 @@ struct drm_gem_object *nouveau_gem_prime ret = nouveau_bo_init(nvbo, size, align, NOUVEAU_GEM_DOMAIN_GART, sg, robj); if (ret) { - nouveau_bo_ref(NULL, &nvbo); obj = ERR_PTR(ret); goto unlock; }