Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 24 Oct 2022 16:03:30 +0200
Message-Id: <CNU7K2WVE8IR.3400IWODUPYYK@ancom>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
        "Henrik Rydberg" <rydberg@bitmath.org>,
        "Luca Weiss" <luca@z3ntu.xyz>, <linux-kernel@vger.kernel.org>,
        <linux-input@vger.kernel.org>
Subject: Re: [PATCH v5 2/3] Input: add driver for Himax hx83112b touchscreen
 devices
From:   "Job Noorman" <job@noorman.info>
To:     "Jeff LaBundy" <jeff@labundy.com>
References: <20221023163032.144150-1-job@noorman.info>
 <20221023163032.144150-3-job@noorman.info> <Y1We8NgutWBbbNpV@nixie71>
In-Reply-To: <Y1We8NgutWBbbNpV@nixie71>
Precedence: bulk

Hi Jeff,

On Sun Oct 23, 2022 at 10:07 PM CEST, Jeff LaBundy wrote:
> Hi Job,
>
> Looks great; just a few tiny nits that I missed last time. Sorry
> about that!

No problem!

> > +	ts->regmap =3D devm_regmap_init_i2c(client, &himax_regmap_config);
> > +	error =3D PTR_ERR_OR_ZERO(ts->regmap);
> > +	if (error) {
> > +		dev_err(&client->dev,
>
> We already have a locally declared dev pointer which at this point is
> equal to &client->dev as well as &ts->client->dev, so we can just use
> that here instead.

Nice catch! Fixed this one and all others in v6.

> With those remaining points resolved:
>
> Reviewed-by: Jeff LaBundy <jeff@labundy.com>

Thanks! Added in v6.

Kind regards,
Job