Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7099159rwi; Mon, 24 Oct 2022 09:47:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4lAOk0H+eXVh199HqvaqvAbtefUolnpu1+89jJcZJNJm0CHqZxY/FFqaU+2m4AP+V7Jhrr X-Received: by 2002:aa7:ccd7:0:b0:461:c6e9:8b0 with SMTP id y23-20020aa7ccd7000000b00461c6e908b0mr5459905edt.287.1666630070348; Mon, 24 Oct 2022 09:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666630070; cv=none; d=google.com; s=arc-20160816; b=kHX3Wvjo/s4nQe+V2xpO49oE52kZzcBdH4mFNS5MwQAqfEYe92+Dtapnh8TyVPal68 xY0hEJHOS221UMvERcTsmpjNu265K+Vcl+rGSWZhJkLbfJFCV4B908e6HzgneS/hBKB+ CugUEPVGNqiz5Zaozh9DJl4T9taWhaEPv5GixQ12/Fg0bVwJC8Yi/ITeglAhLhDLUXCv Z+VhpmuV0HHXbHl8/bSuhTDdi98nVPRhzyW6YF3ye7E8p+xptXzFfGsk++JEK3pm2eVx szCcUn3Ucc62eddTlDDQjjNA4N3BL69/z9LsRk3mtlvcfbCY08Db/GFd6Qxno4AUTWaW P4GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lZFGFCuUxEu9tAkiax+BSd0uFX/2HXFpnNRhEQWWOxc=; b=lCJ2vBcJD6iq2jMI5OodT1hKb8WrBsQVW/AaqossN4G1mpuEXlzs3p4Pf8v4Wvlkj+ 340fk7UvI8Hm9okt2wVU6fR1v+AS02TxkVtrRZ/9YRyMt2nUq99xgkJllRs6SjTHmRRd dy3L2Viiw37T4M1dyKQ/or4q6E0QUwC6tfKIylsAXSSrIbwcmGka7U53jWzK10Yn2nMR BOIXS+RHc7ENplvnWq0BbL4mKJdolJr6f1LzstId4uP1Z+QC1Hpi5TrRmIxby4sjTvpO fyv2oj+ucCl/HmlnoJCuFh42ksq06OViOJW1882W/8MGIoolxN9G6NWgu9Vc/FSWtU2D dAqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ORsA4OK2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f19-20020a170906495300b0077951929340si210947ejt.271.2022.10.24.09.47.25; Mon, 24 Oct 2022 09:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ORsA4OK2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233296AbiJXQ22 (ORCPT + 99 others); Mon, 24 Oct 2022 12:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbiJXQ1f (ORCPT ); Mon, 24 Oct 2022 12:27:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43CE25FD3; Mon, 24 Oct 2022 08:14:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E71B3612BB; Mon, 24 Oct 2022 12:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 059F5C433C1; Mon, 24 Oct 2022 12:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615955; bh=zTri6CPQ9P0Lzgr20EKzelmjLoo2TzdJMIC0eulf4NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ORsA4OK28Mf6SdydZ201u600qH6eRwDupXpp/xJpKjYs/zcTh6kXrbRrPyx5C1G3F kWME4OCNEXIKSmnggXYAKW+yPN6cczz6Ks8xMQC99gNXeOopFupUIgMcjVEpuUZNXl Vv4ylLaZ18XAv8vcxSwK+9BtYVTGyusP75jIl2po= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Patrick Rudolph , Mark Brown , Sasha Levin Subject: [PATCH 5.15 429/530] regulator: core: Prevent integer underflow Date: Mon, 24 Oct 2022 13:32:53 +0200 Message-Id: <20221024113104.508396489@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrick Rudolph [ Upstream commit 8d8e16592022c9650df8aedfe6552ed478d7135b ] By using a ratio of delay to poll_enabled_time that is not integer time_remaining underflows and does not exit the loop as expected. As delay could be derived from DT and poll_enabled_time is defined in the driver this can easily happen. Use a signed iterator to make sure that the loop exits once the remaining time is negative. Signed-off-by: Patrick Rudolph Link: https://lore.kernel.org/r/20220909125954.577669-1-patrick.rudolph@9elements.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 43613db7af75..aa4d78b02483 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2636,7 +2636,7 @@ static int _regulator_do_enable(struct regulator_dev *rdev) * expired, return -ETIMEDOUT. */ if (rdev->desc->poll_enabled_time) { - unsigned int time_remaining = delay; + int time_remaining = delay; while (time_remaining > 0) { _regulator_enable_delay(rdev->desc->poll_enabled_time); -- 2.35.1