Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7145861rwi; Mon, 24 Oct 2022 10:21:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6nFF1pRm5tYfKoJRfV0CC1cPop2W0chCdFIPx/9Az3MRpZfUj7qYGWciUPnk4rFsnUHDwe X-Received: by 2002:a05:6402:3806:b0:450:bad8:8cd5 with SMTP id es6-20020a056402380600b00450bad88cd5mr32679667edb.305.1666632092679; Mon, 24 Oct 2022 10:21:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666632092; cv=none; d=google.com; s=arc-20160816; b=SxzHr2Ct2oOGp/YPXVuU9XXg6H/tk/FNUUajVnKqP690V7yoUIilKvFSn2haWuf/hh j/myLSulw6FIrg4q97OytPlzObgR9KD2189eM7q82t2dAiY1BjoKfB+SDpdztsFWRoch Vtho9ZsDXEyJid160ZR/ZBR1iWWSK+0wj3/vRb8f6VwkJ4/2tAkyICV2GdXHAfw7iXzP CvfNoguh16TDTQuINa2tVjIpwVfxCvnGrW0JbdO5btUvOOk1iNFk6oa18owtZ/uKM9r6 XY9aLUSq3J+45QbDO7t+VhexybrPzaVQH2U/aIwq46rXLxGggXWIbQmfekWRQBgxETBI RyJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eJ1xBfSDiLxLA79EM2qP/YWCwwrrhzC/RUlyHFhO/vI=; b=LpPBqfHvEwLLkaNjhjPAOy3iROTkSVrcE/fSb/FfjSXh350Y0Re801ScM1/9InOIX4 nZC7F9Vrdn9rk6k+LowRy3KimVU8PR4RSeHstrk9JI+lqS5zJZ7A5IqUE/33hjVI2rZ1 h8h/E2b7zDhpaj3SgPF2IIUFBsuywAdSa5PlmGpGWJ4ydGeDcxeMIoj+cE6JP0c8VnMi bJ68B9Amz80e9WdFLtEOvCooRaZIp3akG3vesmDCDKswFooOXWGH7OpXsUuhj4oeEGna dPKadCUoyFsFphlroLofIIhi1ZwiE8U2HXGfbmTdH+BJ1LUIhPjMA7GYDRibNtRCTgZR VaiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TS5hFzOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020a17090655d500b007820f6b65c6si217880ejp.469.2022.10.24.10.21.07; Mon, 24 Oct 2022 10:21:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TS5hFzOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232698AbiJXQmI (ORCPT + 99 others); Mon, 24 Oct 2022 12:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234541AbiJXQlQ (ORCPT ); Mon, 24 Oct 2022 12:41:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBB161D0E0; Mon, 24 Oct 2022 08:28:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F61CB8199A; Mon, 24 Oct 2022 12:43:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7498CC433D6; Mon, 24 Oct 2022 12:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615410; bh=WUE8FJWJv8eYvKiyEOnorlpexel6MZMk7An450XUA2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TS5hFzOrNEBEiw/5sjBl8WXq3AND4Q4nYDt0yP5JRfYQxR+bXP1zwsfy6SsuP57Sx q4xshdKjgwXBFfZKe/3sy8H5Qe39vdkQs66x049vXkwfSLwJ0JmghBQVj/Oh/facTH WWTJnvUgYPTNCUiu6JM200gd4CgsF8stz5oR2g0U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhang Qilong , Mark Brown , Sasha Levin Subject: [PATCH 5.15 241/530] ASoC: wm8997: Fix PM disable depth imbalance in wm8997_probe Date: Mon, 24 Oct 2022 13:29:45 +0200 Message-Id: <20221024113056.008350762@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Qilong [ Upstream commit 41a736ac20602f64773e80f0f5b32cde1830a44a ] The pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced according to context. We fix it by moving pm_runtime_enable to the endding of wm8997_probe Fixes:40843aea5a9bd ("ASoC: wm8997: Initial CODEC driver") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20220928160116.125020-2-zhangqilong3@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm8997.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c index 38ef631d1a1f..c8c711e555c0 100644 --- a/sound/soc/codecs/wm8997.c +++ b/sound/soc/codecs/wm8997.c @@ -1162,9 +1162,6 @@ static int wm8997_probe(struct platform_device *pdev) regmap_update_bits(arizona->regmap, wm8997_digital_vu[i], WM8997_DIG_VU, WM8997_DIG_VU); - pm_runtime_enable(&pdev->dev); - pm_runtime_idle(&pdev->dev); - arizona_init_common(arizona); ret = arizona_init_vol_limit(arizona); @@ -1183,6 +1180,9 @@ static int wm8997_probe(struct platform_device *pdev) goto err_spk_irqs; } + pm_runtime_enable(&pdev->dev); + pm_runtime_idle(&pdev->dev); + return ret; err_spk_irqs: -- 2.35.1