Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7198346rwi; Mon, 24 Oct 2022 11:05:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6/bDHfXgULSluI9U5ySMXzSzT3fVTbIVIvNvTOhEKOLWONp9igQPAh2cn+J6yjtxkw8jKj X-Received: by 2002:a17:906:8451:b0:78d:d467:55a4 with SMTP id e17-20020a170906845100b0078dd46755a4mr28481089ejy.352.1666634731077; Mon, 24 Oct 2022 11:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666634731; cv=none; d=google.com; s=arc-20160816; b=LKqvq3cyavJR9P0yYa+2TabCleYLETOJUUxgVmePOiWt8MD/ZOg/KC0zc5y/TdaDc7 h25zCDw3P1xJZpgJcTVndVD1IUuzeocEMh3YfIEMvl73wmB4IWVrtViJhDI5Yp3Ox3CP IN5Cck/CLYQitwopuwK8maKp4EWeBQ+nNtUPbJiwWBAlNm8WIbHQYdvqLbXoEjj1RuUS mGdqyDZoXnXaixaI+qkfRY9oXGB4v7mAz63hT2EY6zXBANsXvCucZ6JJ72qKlwh7tLRE 02GZBJLs5pQNM081JWyz1qvmTSCNsy8d/Ktxi2QaE80isHxEvQ+t/jZjnUtjOpOm/gz4 giFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a1QuOYvuRisp/EALocACHvhqq7vII+9OaWwL4wyPplo=; b=U944HRbCOxJtX15CZha/CZENE00LYsJcXfr5GXq9VW9efN9vTPXHfzX9D9C3b+RYzY OYxJhYNznyenOvbQ1ioTSDNLNgOBvtuBWitOyC6kuqmDb7aBwDk3E8q/XC0LijgXL1PF 9kP0iAUtCcQgIBHAuB4f6QJW/EuPFordOiGJgN85rzqmmFwzmx/jtdEbT07ieGHFlUqv /9C0sNo5ZqUdvYwKGGzz60sbCMI9JeGg+bWGJvB54j1Rc2eTonkSd2Oo/+owm5FhAj2z sOyqP4ga+6yWBW2KUKr7cS207S1cxhLK56X1vTjW6St2MhofCNYj0V0r+L1MTrgZRUYn mPHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=f78Oef8m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa33-20020a17090786a100b0078dfe6dc4d2si564123ejc.33.2022.10.24.11.05.04; Mon, 24 Oct 2022 11:05:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=f78Oef8m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbiJXRps (ORCPT + 99 others); Mon, 24 Oct 2022 13:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232664AbiJXRpW (ORCPT ); Mon, 24 Oct 2022 13:45:22 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2FB4A3B89; Mon, 24 Oct 2022 09:21:13 -0700 (PDT) Received: from zn.tnic (p200300ea9733e790329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e790:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 53C4A1EC068C; Mon, 24 Oct 2022 18:09:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1666627755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=a1QuOYvuRisp/EALocACHvhqq7vII+9OaWwL4wyPplo=; b=f78Oef8mMPh4u167RqzzXHtScFCz5EwAxJXkbHmiMdUF0SLwPTeD60zHX41N+e8u6qstgz uAj19Ugl/gNh30w4VlySEHUoy/sh4e7FUz22kZnY4kUSc2k02TdBxAtZNXhIvrviN94hhI HBVtoxn1n5dmfc9QTHpWJ0gVlum+CKA= Date: Mon, 24 Oct 2022 18:09:10 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Message-ID: References: <20220418174440.334336-1-yazen.ghannam@amd.com> <20220418174440.334336-2-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2022 at 12:22:20PM +0000, Yazen Ghannam wrote: > I ask because struct mce is UAPI. But I think this is just for /dev/mcelog, > and this has been deprecated for a while. So on a related note, should > /dev/mcelog be removed and struct mce moved out of UAPI? Then changes to > struct mce won't affect user space, and we can just consider the mce trace > event when reporting to user space. Question is, do you want those error records to be fed into mcelog on AMD too? And I remember you guys supporting it at some point. The answer to that question will tell you how exactly to build your structure of data you shuffle to luserspace. I'd say. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette