Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-95441a68-0025-49de-8c73-9730fb9cec42-1666623320110@3c-app-gmx-bap55>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Wenbin Mei <wenbin.mei@mediatek.com>,
        linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Aw: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 24 Oct 2022 16:55:20 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <a0121e0a-9f62-8630-45c5-d32eaa91d46f@linaro.org>
References: <20221023091247.70586-1-linux@fw-web.de>
 <20221023091247.70586-4-linux@fw-web.de>
 <a0121e0a-9f62-8630-45c5-d32eaa91d46f@linaro.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead=
.org
> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaot=
ian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herri=
ng" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@li=
naro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenb=
in.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.or=
g, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986
>
> On 23/10/2022 05:12, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add SoC specific section for defining clock configuration.
> >
> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi,

got another config from mtk which requires changing binding a bit

                       clocks =3D <&topckgen CLK_TOP_EMMC_416M_SEL>,
                                <&infracfg CLK_INFRA_MSDC_HCK_CK>,
                                <&infracfg CLK_INFRA_MSDC_CK>,
                                <&infracfg CLK_INFRA_MSDC_133M_CK>,
                                 <&infracfg CLK_INFRA_MSDC_66M_CK>;
                       clock-names =3D "source", "hclk", "source_cg", "bus=
_clk",
                                     "sys_cg";
in binding:

+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -241,15 +241,17 @@ allOf:
           items:
             - description: source clock
             - description: HCLK which used for host
-            - description: AXI bus clock gate
-            - description: AHB bus clock gate
+            - description: independent source clock gate
+            - description: bus clock used for internal register access (r=
equired for MSDC0/3).
+            - description: msdc subsys clock gate
         clock-names:
           minItems: 3
           items:
             - const: source
             - const: hclk
-            - const: axi_cg
-            - const: ahb_cg
+            - const: "source_cg"
+            - const: "bus_clk"
+            - const: "sys_cg"

will send an updated v4...old version was working but i should use the new=
 one.

@Krzysztof can i take your RB here or should i leave it as Patch was chang=
ed?

regards Frank