Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7233682rwi; Mon, 24 Oct 2022 11:35:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5ELSK1TtuYI9MCu8Q/JDDwMCvJ7TcWLuBa1eNLwRIFfPCTpPoM+t1I8ry9klZRPVE2tFG+ X-Received: by 2002:a17:906:c14f:b0:793:30e1:96be with SMTP id dp15-20020a170906c14f00b0079330e196bemr23854848ejc.447.1666636523442; Mon, 24 Oct 2022 11:35:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666636523; cv=none; d=google.com; s=arc-20160816; b=Gj2IgMFO5HbTGNQZBLUNRP2fmBokwvaH6Fu/zytF3/+rvjcYfb6Uy5N+qpOLeNLsOU hYpwrORZC6W/R34cyIYzJrGZPgNhKt1E9H/TNnv5GO/DnYrLG/HeZyY65//Z6Qihu1KQ Y4Le3otSA4FPash8HXrHexxHW4GUuinj90H90wXp3Co4N5QV7LfAdZ5giQE5hZD17kr8 MK5QI+HOMqWqclBDWJz64mDYi+DEUKo8TXo07gAnoGgI8MI7W3CzdcYcrAyb/xmdytjc HIW5GD9ELV2WhFQqXG9mpbph/QWYRYfAIZSxFMF3sKyodB4kj5sJuIN718/8dsXnDdY0 PXIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=AXEhQBaYJcsY09QjqAQ/xiILbCbyndNxr5VQjFtEgKQ=; b=PN97zOQPoY1DaRmaMzZDOM81o8J5xVAUkemfCqK3dVBzCnD/OKks3UbPdxfog4yXeY YLlMspdahog6HeX3djpJMgf+CJHuAuqufDPBe9l2QAo0CF3ysCSNyntmzVTQIFhicaC4 9B9BcaVOSmZmTtutfDC9z6bYl4F+/o2R0WSmuJPRqrdg5QXsG7TA/bIkI+Z22vNprXRb mlRd+bDwWjm67r8ZCqJeyNEmulCEeP3mXyCKH5CL7t6kkOov2E4uAcL6Ae+ylAQ1v+cU jSqY781HrqTnW6aPkmk2BlK5bBX1JnMUbPtzWb3NdNJu9nfspOLIgRzmSp78Sken51xU u/5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp16-20020a1709073e1000b007306ac0faa0si427247ejc.615.2022.10.24.11.34.56; Mon, 24 Oct 2022 11:35:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232263AbiJXSWu (ORCPT + 99 others); Mon, 24 Oct 2022 14:22:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbiJXSW3 (ORCPT ); Mon, 24 Oct 2022 14:22:29 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBF6E6502C for ; Mon, 24 Oct 2022 10:03:07 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so3928135pji.0 for ; Mon, 24 Oct 2022 10:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AXEhQBaYJcsY09QjqAQ/xiILbCbyndNxr5VQjFtEgKQ=; b=IEHv+6EZs++pWLm9yYz0ECtajbE7gAJ95UhsBSQQ+tg4qNvmIIxgLKRoXAAd8iA7dT 7ioXPXezOFgvHMPz4Iv+GQh3BhCZ60FjczNgGt6m/A6rwMu0wWEeoeT8INCTabElURnZ K+PtrME6sG6FAKowJEe2UBBx0NSPR+KxoBaRKNVnQ6CX2CzpUQEAUNl6i1N0Vrm+FQNk NDpSLSzWw/zF2yOHnxxCv/4GzBZcSyzZIL/6Ia5DXLJ5fUGxEbK90lmXPAJhZGctD499 Ph3BfD55zumn4AjxeYhc529HlbzwUbKXNhnJd8dDkWZOfLO0jd60Zc35TkTGACJ0r7eU UoVw== X-Gm-Message-State: ACrzQf3vi0zxQQtzvreeFyoIzuFds5xgVxaOJBghgdK54TmQ3Ew4BjzY Yw93ajtkx9Ig+d/SAg2tITfjTItj4F4= X-Received: by 2002:a17:90b:1d0f:b0:20d:1ec3:f732 with SMTP id on15-20020a17090b1d0f00b0020d1ec3f732mr38720175pjb.84.1666630812805; Mon, 24 Oct 2022 10:00:12 -0700 (PDT) Received: from fedora (136-24-99-118.cab.webpass.net. [136.24.99.118]) by smtp.gmail.com with ESMTPSA id q14-20020a170902a3ce00b00186748fe6ccsm6530456plb.214.2022.10.24.10.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 10:00:12 -0700 (PDT) Date: Mon, 24 Oct 2022 10:00:09 -0700 From: Dennis Zhou To: Baoquan He Cc: linux-kernel@vger.kernel.org, Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH 5/8] mm/percpu: replace the goto with break Message-ID: References: <20221024081435.204970-1-bhe@redhat.com> <20221024081435.204970-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024081435.204970-6-bhe@redhat.com> X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 04:14:32PM +0800, Baoquan He wrote: > In function pcpu_reclaim_populated(), the line of goto jumping is > unnecessary since the label 'end_chunk' is near the end of the for > loop, use break instead. > > Signed-off-by: Baoquan He > --- > mm/percpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index 09e407338573..954abf916c7d 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -2167,7 +2167,7 @@ static void pcpu_reclaim_populated(void) > /* reintegrate chunk to prevent atomic alloc failures */ > if (pcpu_nr_empty_pop_pages < PCPU_EMPTY_POP_PAGES_HIGH) { > reintegrate = true; > - goto end_chunk; > + break; > } > > /* > @@ -2203,7 +2203,6 @@ static void pcpu_reclaim_populated(void) > end = -1; > } > > -end_chunk: > /* batch tlb flush per chunk to amortize cost */ > if (freed_page_start < freed_page_end) { > spin_unlock_irq(&pcpu_lock); > -- > 2.34.1 > > Acked-by: Dennis Zhou Thanks, Dennis