Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 13:54:05 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/6] iommu/s390: Fix incorrect aperture check
Message-ID: <Y1bDLfK7df6XL8WP@nvidia.com>
References: <20221017124558.1386337-1-schnelle@linux.ibm.com>
 <20221017124558.1386337-5-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221017124558.1386337-5-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QuYImb5ThIqy7AbME2lmTFdCNbFLVsMH8CqqGjDBp+bdTdysGEnQ0yJDpcGK?=
 =?us-ascii?Q?Kp8kwvAAz+CWUMcGmqP8btkvQGLbqiidNTlcw97XzRtxx/M8UIolfY/GVSnA?=
 =?us-ascii?Q?f292GQRGXX5xs2FKaUjVcCUJqRqq21gpUofZDDRMTnFGo+ptQF4dFJWnuMt/?=
 =?us-ascii?Q?vIBLLKVwy1lOXyz3N9s5FAaLPpjiiSaKRtC0LqdMFqz/nMrIqkMztLKoTk17?=
 =?us-ascii?Q?Ezj3RKyijDBKBrTY34h12GsAOp+ZmKqE1od3ROqGZ09t777Qv94IuUikTSON?=
 =?us-ascii?Q?qDE/LSwAzveszINf+9azl5YHqPAQ3C+SUhdcexVjHiAwhZcg/t08DO5jZIRT?=
 =?us-ascii?Q?xeiyNNSMIr6By3St0vrN+2yKgKj4Lz8sKO7rGJaePZCdWbEwY4EfqG1GfQym?=
 =?us-ascii?Q?vSRMtw1IRODT6DZFpJCOAHXGkOutOkLTI9Jo6uF4oOsjEt8Gpo4UH/KAVZTW?=
 =?us-ascii?Q?ie+lGlo//gKtC6regh7FKYBgLErAwF5X40WUOFPilcfQ5+CxYYbmniDIWe07?=
 =?us-ascii?Q?L5LHvOnCEtk1hezoWTiZY8x486N6FBd8j88p38fUdyOX1cULACBwOtHWsY+r?=
 =?us-ascii?Q?/EU9qOuH5V9vqRufX5vWeGFo4vMtSGcjwPN6Zi54STGPygBsVt74fhfChy5c?=
 =?us-ascii?Q?n40mjQIf3nThoTgHostBEO6WcGvCvA4crfSxgLLpHmTgcr/F97njxmUCTjML?=
 =?us-ascii?Q?yy5zh4RYboUyEC4oqI62meEFFiHVOIp8zZSbu1Ehi/Eadqc7nmrCSH4Y2NuY?=
 =?us-ascii?Q?sK591wmyc/joRGIKYR21PKa2F1iDC6igrOK/GE5iInjGwysvpPpuMtXsvd5P?=
 =?us-ascii?Q?QBeBCVr4r+Uph4PJWPnPJi514j5u5HuyISQRmbk6oC3pS9Wikd3E7lKXDBd/?=
 =?us-ascii?Q?xFMh32/puaIMra8Yba/H4QWsnxAubA0AF2xZ7TiOrh8k9Fad46LVWPgnyoaN?=
 =?us-ascii?Q?Ws85zUvk2uX1kby5r9yzw5hwBnbbSBTbvFNfM6zF87vIVD2k2nMNvLstWmLH?=
 =?us-ascii?Q?PZeCdJoA9eihXivqsxgf8pAE3Ziz87W4SURpTYiJ9xpzWTBxfw4zoji6NYGa?=
 =?us-ascii?Q?/nykFEwJympF/TmZCmQQEZmlVHeusk6Lrmo5vZS7MAEVrjojp46SMWQatT/w?=
 =?us-ascii?Q?PKoDD+iUbQERXyP8fQnitPDAp9uZ0NRk7d6Rnv4qMJUwuDZ3PIiSBsF7kbAG?=
 =?us-ascii?Q?6vhBxztHNhoY7eF1zXVIZAjlxiovxRi9VwGUjr32vgWIgTq93vmR2kXFAixl?=
 =?us-ascii?Q?GdLI5kWr7hkMoHYZZ3DFKmon2S5O6/1IFI+0QK2DA9qgWxUZeddTFLGLLqhj?=
 =?us-ascii?Q?TVcc0qWyrIWU73lp8vYH5RfnXXBmWGUvUm7+DI6+ZGbD5hiyoPjnjmgWV6H2?=
 =?us-ascii?Q?Tdraa6Rilf55myeRsCZcjpS1f6Xr/Le8Ai4nE6muG6Q03eMToZvx6BmLlC+e?=
 =?us-ascii?Q?BbeUVlX6BD9KV86fCVxsDxSfdiceV6UN5dqf9vOtJow5NgzQFPgDcmABXdWM?=
 =?us-ascii?Q?IMZ+icxQLemZl2fVAd1d5Meeou+Xpf/lsIeO8oXnUdNygpl6Fhl3YzTghWK6?=
 =?us-ascii?Q?FhsFwyd31WagsJcLC7Q=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a965a4f0-3aad-45a3-a1d5-08dab5e05d44
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:54:07.0926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b+bo0NpXBLDpFVhUWBV50QcmbM1sGOSHlOMVeeHyMCuFZAnmkjcPyAaz7/cnl+EF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5368
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 02:45:56PM +0200, Niklas Schnelle wrote:
> The domain->geometry.aperture_end specifies the last valid address treat
> it as such when checking if a DMA address is valid.
> 
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> v3->v4:
> - Make check robust against overflow (Jason)

I wish this value was called "last" but..

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason