Date: Thu, 2 Aug 2007 15:40:34 +0900
From: Mattia Dongili <malattia@linux.it>
To: Eugene Teo <eugeneteo@kernel.sg>, Len Brown <lenb@kernel.org>,
       Thomas Renninger <trenn@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/char/sonypi.c: fix ids member of struct
	acpi_driver
Message-ID: <20070802064034.GF25969@inferi.kami.home>
References: <20070801091534.GA6845@kernel.sg>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070801091534.GA6845@kernel.sg>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1156
Lines: 35

On Wed, Aug 01, 2007 at 05:15:34PM +0800, Eugene Teo wrote:
> ids member of struct acpi_driver is of type struct acpi_device_id, not a
> character array.
> 
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
> ---
>  drivers/char/sonypi.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
> index 73037a4..ac0aeb0 100644
> --- a/drivers/char/sonypi.c
> +++ b/drivers/char/sonypi.c
> @@ -1147,10 +1147,16 @@ static int sonypi_acpi_remove(struct acpi_device *device, int type)
>  	return 0;
>  }
>  
> +const static struct acpi_device_id sonypi_device_ids[] = {
> +	{"SNY6001", 0},
> +	{"", 0},
> +};
> +MODULE_DEVICE_TABLE(acpi, sonypi_device_ids);

how does it behave with the already existing id in sony-laptop?
I'd rather avoid the MODULE_DEVICE_TABLE for sonypi allowing sony-laptop
to take over automagically.

-- 
mattia
:wq!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/