Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: cdnsp: fix issue with ZLP - added TD_SIZE = 1
Thread-Topic: [PATCH] usb: cdnsp: fix issue with ZLP - added TD_SIZE = 1
Thread-Index: AQHY44ERVMaQ2YM4VkyQ1o26SeztW64XRlkAgAEFafCAAiW3AIADKvRw
Date:   Mon, 24 Oct 2022 14:10:30 +0000
Message-ID: <BYAPR07MB5381BC3F7565C1BEC2DEF96FDD2E9@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <1666159637-161135-1-git-send-email-pawell@cadence.com>
 <20221020132010.GA29690@nchen-desktop>
 <BYAPR07MB5381E4649DFD2BD0C528AC0FDD2D9@BYAPR07MB5381.namprd07.prod.outlook.com>
 <20221022134318.GA51416@nchen-desktop>
In-Reply-To: <20221022134318.GA51416@nchen-desktop>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bxf6Tnnt/hT2MJaJXJvNjCs/+wJloOiqRyjhEugs6R0PSNvQdnqQWbUUkoS+?=
 =?us-ascii?Q?ft1kSMjvymJDd/Io4c8TQM4XAd78eWRKi/A/FsI6VYLP3xfe++LBBj2p3U1j?=
 =?us-ascii?Q?GI6kUBeBWBTx8mUfeYhoz2GBB3vx+Ap6kki6dK2bOkm5pRMny5GO0iVhToOE?=
 =?us-ascii?Q?pm2Zwn9vFab/HlBa2BVApzkS1CUouBO0T3iI8Cl1+FjV2EXBOeIn6RZbkLLZ?=
 =?us-ascii?Q?hO0y+P9V1201oj56n8LU0dVrmc0+JUCviAYMqOW149f0+jHMIb/6Snt+QWw/?=
 =?us-ascii?Q?3mXVovP0lyC9C8zNWD1BrDg+XNf08Eq4/NrfaHzhjnPZRs+zZR821CWZk7h0?=
 =?us-ascii?Q?fZZzDl3NrnZVEuNnWfMioufvSOX4nizQRSkeQ0St1vR29PreoG5LynEfVpf+?=
 =?us-ascii?Q?iDGVV6tY/Fd7GfcztkxsTMGOSQXozC/PPAWyz4sPQGCBt8lwteXAHDHURcmj?=
 =?us-ascii?Q?BZ9IjowSKUhZbwO7iUAKeaXGQ/IgTKYIzdmC3VQqScNMa+ryPuf1v1v4MxWD?=
 =?us-ascii?Q?x0TdZRz3DQpBVMiZuGjwfXsCNlAscCgGq3xrDJ5u7pLONh4EUgE4fWfBiw5C?=
 =?us-ascii?Q?B7gTyI6CJbUl6uppepZvxuOxyavXSow/lcU3hmBGkrSKm/a5UpyKlbpQfQT7?=
 =?us-ascii?Q?TOC84ZcY/Ugk1XTbomOlutylJiwKFQzwbcKY2Luz6WXH5+E+H3C7gmCIIaHx?=
 =?us-ascii?Q?jud7OXq388Buk7UJjqnIl9p0EsSNShbAyaWjTngUIpXEiJPvlvrcCRkFyNc+?=
 =?us-ascii?Q?dKIkVyWc9CvnWc3o7trjWvj3HWkuid53/O7+x3cm9ofCRjR3OPT89NqUH665?=
 =?us-ascii?Q?MOmZmWoyG3cLwzfqgbinw1zdz2q+0KvThMZrQFu7EhWYuKsinvRjBvScrldX?=
 =?us-ascii?Q?vucP59g+ycNw4KgCCuUrNspF+yVBgCom5hCBJjTksBWr2TPM821PAU/ro7Fh?=
 =?us-ascii?Q?qdQ7jonmlTSVdSRA8iroWE9+DrJNokwAL5OiM6PM4VB9KYiytltrcuwfpEN+?=
 =?us-ascii?Q?1Lfl/6h0BeagpzM3SYSeA3oNZW/d5Vnk0htWbeDkWAVTaUzvnpangk/EIi5o?=
 =?us-ascii?Q?A9qxitl5+5eJhR4Duo0Ynn2V/0I+c6AfBY3Ugxuh2uBU2Dxvgd02z5QwYL1q?=
 =?us-ascii?Q?MH1+qwXHfQsPH7sF8qM+bv3JTcZ21rXibbS/6AGLt2Ypm3gareehO909QKzC?=
 =?us-ascii?Q?zaNmZFdQFVyHDxyAxEqheZIgPtBFvgkD/P/ijCFDRW1RrsSng8NHZxwJfn+y?=
 =?us-ascii?Q?XErXV1+aLctoLJJWbvsIPDg4I3A4VFyUuSKFmBNAn5NjcxwGlJICU+dPtKo4?=
 =?us-ascii?Q?CTu4vHbG3VvZKlSNP6oj5W+9Zb1KNAH5G3CeR34nBKKUulkn0ehJVbJZFqhT?=
 =?us-ascii?Q?oUJ13rvxYMyCWzN3YblyAKWELhokE/Hhi1utU9zk+Y+hNj5OGocUdG1B7cnQ?=
 =?us-ascii?Q?8ysNyOsJ7S9lIJ+Q9zf4yNd4h0FVaLMZVh49OIJ6RVTuf/iAuoKcx/WarOG2?=
 =?us-ascii?Q?4SmTd3v+bJg46QVXUvMGUw45ud5val8QfCB6JIVf9EYPBRNHXpEkSZ+mrXu2?=
 =?us-ascii?Q?EskwBsHFcmuWNRTNBJCiNGvd8x+nzJP8VccnkA3Qy7J9K4yHUiv/sEdghFsL?=
 =?us-ascii?Q?vQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7f84d1-283b-48fe-0afa-08dab5c98284
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 14:10:30.8623
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vKLt/0e+4Y3vi/XBer5MVlhPjMsSJd0veBwCISbV7YyN+qK93c31U2wyILRaJnjk1p6+NTdwfPu+AFCZgQ0SO/jnZJSP8QFTcj1fwCzsz5Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR07MB6237
X-Proofpoint-GUID: 0ncyyLqY-Sxqd6_rPo77ttkmRKqDMzkc
X-Proofpoint-ORIG-GUID: 0ncyyLqY-Sxqd6_rPo77ttkmRKqDMzkc
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 bulkscore=0
 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0
 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0
 mlxlogscore=407 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2209130000 definitions=main-2210240087
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> >
>> >On 22-10-19 02:07:17, Pawel Laszczak wrote:
>> >> Patch modifies the TD_SIZE in TRB before ZLP TRB.
>> >> The TD_SIZE in TRB before ZLP TRB must be set to 1 to force
>> >> processing ZLP TRB by controller.
>> >>
>> >> Cc: <stable@vger.kernel.org>
>> >> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence
>> >> USBSSP DRD Driver")
>> >> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> >> ---
>> >>  drivers/usb/cdns3/cdnsp-ring.c | 15 ++++++++-------
>> >>  1 file changed, 8 insertions(+), 7 deletions(-)
>> >>
>> >> diff --git a/drivers/usb/cdns3/cdnsp-ring.c
>> >> b/drivers/usb/cdns3/cdnsp-ring.c index 794e413800ae..4809d0e894bb
>> >> 100644
>> >> --- a/drivers/usb/cdns3/cdnsp-ring.c
>> >> +++ b/drivers/usb/cdns3/cdnsp-ring.c
>> >> @@ -1765,18 +1765,19 @@ static u32 cdnsp_td_remainder(struct
>> >cdnsp_device *pdev,
>> >>  			      struct cdnsp_request *preq,
>> >>  			      bool more_trbs_coming)
>> >>  {
>> >> -	u32 maxp, total_packet_count;
>> >> -
>> >> -	/* One TRB with a zero-length data packet. */
>> >> -	if (!more_trbs_coming || (transferred =3D=3D 0 && trb_buff_len =3D=
=3D 0) ||
>> >> -	    trb_buff_len =3D=3D td_total_len)
>> >> -		return 0;
>> >> +	u32 maxp, total_packet_count, remainder;
>> >>
>> >>  	maxp =3D usb_endpoint_maxp(preq->pep->endpoint.desc);
>> >>  	total_packet_count =3D DIV_ROUND_UP(td_total_len, maxp);
>> >>
>> >>  	/* Queuing functions don't count the current TRB into transferred. =
*/
>> >> -	return (total_packet_count - ((transferred + trb_buff_len) / maxp))=
;
>> >> +	remainder =3D (total_packet_count - ((transferred + trb_buff_len) /
>> >> +maxp));
>> >> +
>> >> +	/* Before ZLP driver needs set TD_SIZE=3D1. */
>> >> +	if (!remainder && more_trbs_coming)
>> >> +		remainder =3D 1;
>> >
>> >Without ZLP, TD_SIZE =3D 0 for the last TRB.
>> >With ZLP, TD_SIZE =3D 1 for current TRB, and TD_SIZE =3D 0 for the next
>> >TRB (the last zero-length packet) right?
>>
>> Yes, you have right.
>>
>
>Pawel, With your changes, the return value is 1 for function
>cdnsp_queue_ctrl_tx. Without your changes, it is 0, something wrong?
>
Yes you have right.=20
It does not cause a problem, but it's not according with controller specifi=
cation.=20

I posted the fixed version of this patch.

Thanks,
Pawel