Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 13:52:50 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/6] iommu/s390: Get rid of s390_domain_device
Message-ID: <Y1bC4tzKOIHhrYE8@nvidia.com>
References: <20221017124558.1386337-1-schnelle@linux.ibm.com>
 <20221017124558.1386337-3-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221017124558.1386337-3-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8xIXMKbYRDHyjBLiLcOm+BsU/BnN6rO44/r8c30xAp1rKbHiYLZQG9Pr07OZ?=
 =?us-ascii?Q?J5EfTOV9DtRRUkIEzj8t75Bn37IYWdebfIeZjdyeMADwUr37/AWEQBTGvDED?=
 =?us-ascii?Q?/0VrVOhD/6OKvhBq74J3K/BrnZihWJzwPNuAj2zW9WQpXSOazn92F5odoq2e?=
 =?us-ascii?Q?cOvfue3Pc/q88+M3SinoimF3aOLBUTpGNy/ndikUXzz6NvYO4+Z0qmuo+tBq?=
 =?us-ascii?Q?0dONKqYXLuROVQslxaDbvyPuRW7H3V6mSi4R8CFrfILzj6R/62wpQwTquWwz?=
 =?us-ascii?Q?xMfJBNEf+q2rmpUIqbtMeKhADligDBR8Eu5a38s/CnLcXXLtTsKV2cGjqWHF?=
 =?us-ascii?Q?YdKes02PWceVZ5Yj7FjQCxjdq2TGnbXhqTJd77HJzlpd/KTBGRVA/Io3q7Bi?=
 =?us-ascii?Q?dXKlU29FZrEyMYGaGU+6kLOGbQtJjQUVJK61D0a9mi8irg91rXBPVKB7N5Vs?=
 =?us-ascii?Q?/h/FFgDjySPPdGkIAWiuXIVKqzljoujo3yH/fKtgXk5q3oTRyH2Gyrc0+Tx3?=
 =?us-ascii?Q?jERxGwRTqpyCxGFR2tzSi7d/dV3q4ktfGd4fxrbDH2ZBU3ULOzLgE3RHo2F1?=
 =?us-ascii?Q?NyVrWXuWQa4xCengw6B5IxY52r6mF4cdHtd7AgJl4yjx5v5w1F8LTDtVuPsb?=
 =?us-ascii?Q?cauhhaIpCFT++pCAhst+AaNzTWCM0Ra603sPpG0ntiqFXuEuC4Zg3umwNLZG?=
 =?us-ascii?Q?j1Pv1dhv1Oasg5PRfmxGuqncJ8DXJdu1jby6/+MKLrIHRR/o/k5YORCjBd2+?=
 =?us-ascii?Q?amAmWx/RkJZa9y/+y8pBvfazZXvXzvIRMScxHWzlNGnKVTCIUw3oJAzKvrLm?=
 =?us-ascii?Q?s7KxS6ccFcB2Nx0ioGvBdCKA9qmvC9L8vRSEeLyeHNJh6BME/u3SgAhS4XOR?=
 =?us-ascii?Q?3DZsHgF8z59RJRhi6+FugOXtqMQYjjWbg7RwYoDk/Qyezocp53cheWbpuyY/?=
 =?us-ascii?Q?Ozcd7VXk1KbjgwqfaJite0FaEW+Exg1bJVh3C0H1xbMTLGk8DtAhL+RZ5Aqj?=
 =?us-ascii?Q?uMxecSdkdLq55od0y+UDVYaD0SjnuY52/3dnHJ8GWMmOgeYskD6iqZRlyO4g?=
 =?us-ascii?Q?9MfyVHhySDKNtywxdwdcUMDU0NRJCgImtQGov9d78waTy/zVeFo/BhB1P3Nw?=
 =?us-ascii?Q?7QGRSAqlBBHiKIF03j7dkDqdvtNE4B4bCcmrkYnpifO2zSpfB3aZGGK2ABfh?=
 =?us-ascii?Q?x3rhsNRkQODs7Bowapb/C6n7DbAuj8yDW2eeMBCrjjjld7Fi/0MT7P1XRoOK?=
 =?us-ascii?Q?nozMqsNpD2YnxLtpGRiXwB6W9z0U4Hnf5i51e1NzAbEMK2rGHeLL3OiMAx+g?=
 =?us-ascii?Q?lT00nCE8Kx1FfnjQao/XT4UyEqp5TKqAPY+yUz/Dr8Z6isXi+h/rsPY1/DOW?=
 =?us-ascii?Q?5N2S5cb3AzUZJOw9J1qmdtx7DuR1e2yMeRfIL0yjKQlOXp5zJJ539yw+2hFo?=
 =?us-ascii?Q?hpavXqKC1qk4mTcWO8+lMZL+iDTRP+QdhoNN9mwzrM8/SWQnWO/4+Ltp+heh?=
 =?us-ascii?Q?XkayRv/WARZ8BZ3phRnlvlvAK22pRrnsiHYumRwicHjWXC0qU8NgKoD8Bc1j?=
 =?us-ascii?Q?EGxywOceVlUnhXtRyTw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7d67c85-a002-4274-b949-08dab5e03063
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 16:52:52.1438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rvzna8tKH96P5wJkx4ZSPTx4ZyGNXwrNRQBX9CwF9dasAbQOKeoHGfJgqOBs/l25
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4513
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 02:45:54PM +0200, Niklas Schnelle wrote:
> The struct s390_domain_device serves the sole purpose as list entry for
> the devices list of a struct s390_domain. As it contains no additional
> information besides a list_head and a pointer to the struct zpci_dev we
> can simplify things and just thread the device list through struct
> zpci_dev directly. This removes the need to allocate during domain
> attach and gets rid of one level of indirection during mapping
> operations.
> 
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> v5->v6:
> - On attach failure make sure the IOAT is not registered
>   and zdev->dma_table == NULL
> - Dropped Jason's R-b

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason