Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7278860rwi; Mon, 24 Oct 2022 12:16:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM433DrsS+Y7Q6nG4sjPgxa0WFbujjepiL5PpeQT2hdPQ579JD4IfEa8hF7iDyAmdyUfYItp X-Received: by 2002:a17:902:d48c:b0:186:8815:38fe with SMTP id c12-20020a170902d48c00b00186881538femr14886365plg.63.1666638994122; Mon, 24 Oct 2022 12:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666638994; cv=none; d=google.com; s=arc-20160816; b=h0eUgGBfx1A64opnBqwHtUYIt47IAdUXnD7OzVlbPzdt8TjBdaTPtWDAUwphFVdzJN ps+Cnp27kZmKvqRZglT5CDBX8qMrVs/TtctmqpAnx0cdW5KUeVMDuY5dC51Rw6sEtQjl dwgau3AdnBuksqTW20lq0h9eQ319CtU1EMABoiQMGSvn+qFGN0IZQ9L41WOz1Vu4z2lL Fg5SM9egkvMYZhdOWfA3PCoB2o4iQavaSQX5zPelMflLPz7YVsemPt/LOmQRpjMokO/C oXqU7sL/Pybeysgi3erC5Caje27FxKNL8QIlp0opuQmnSnDr/izBOBYEpyaKKiYavkWF b/pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=r16e7YJQGBmRzLzLaDKltCyGcTq700C7FFSJf8NtzRQ=; b=olYtpw6Xp82bwCmj+WnicRPhyDXoTvL0FaafwKN3SygN3IVCws5itXRTvV3BGjlRQT AAz6x//bm828ZuMhST2s+RAeQTdY63+1iKnNFBI5+N6ipZfg0mA4WF/+qPYlW+LqHSfq +2awsyISbcwj3pAy6ts5rbcyXqoQERQKCjHPRInmePgVjKCqy9SrEKBdqwqrm6uGJpfr 3WJ/1bIPo6rkorvAqq1Hx9xd/J6TnLvFcuKhzTcJyOcFOQt/5t7/FP3LWFjP0MOjBzty XzC52gH+4afYCGIBqEEn94NuCJQZyJrA+Tal4LTphZQlYJh5s34M7PUoICTln3H7A+j5 bZ0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vqbn2KpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y15-20020a170902b48f00b0016bea2a8b16si271148plr.364.2022.10.24.12.16.21; Mon, 24 Oct 2022 12:16:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vqbn2KpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233053AbiJXTK5 (ORCPT + 99 others); Mon, 24 Oct 2022 15:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233023AbiJXTKW (ORCPT ); Mon, 24 Oct 2022 15:10:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D99FA15FEB; Mon, 24 Oct 2022 10:49:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3C7A0B81978; Mon, 24 Oct 2022 17:29:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 770B3C433D6; Mon, 24 Oct 2022 17:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666632594; bh=vIPEuadz4wBsNJCFqsj4+XK0Nga5/XK3St4OhCu66q8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Vqbn2KpF0tIBYJ0lsKaDWCn/FTOR6Cz+nEnB5lyV1oqFKOhHzKQpQpyTsqgzwq4Sz tIZAQiO8GHgwG0IaWg04BRtTYuHtN0IP+Eu0iX9LUGENdEzixFclrZMQaBGYEkCMUf 0+MoUqAqC3WFsMhn42eTddAi0sA9EHuMs+9aYxAMEgHvLjuYiCEodQyQYEJGrEtoBS 4T9NVzus9ybYohS2ivNmZy/OfSfZitHC9aZilVXzx9HHfZytrSf+KhceqkjbL71eUt KlXqiB3xAfA8q0vxUkV+/08vnUtUt4ruTB3M0WemVwe534owiGkeVLepWfK5GIkSQE XlaMFhwEsKiXg== Date: Mon, 24 Oct 2022 10:29:53 -0700 From: Jakub Kicinski To: "KaiLong Wang" Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: replace ternary operator with min() Message-ID: <20221024102953.1ecc15f0@kernel.org> In-Reply-To: <4e5c1182.347.18404f42721.Coremail.wangkailong@jari.cn> References: <4e5c1182.347.18404f42721.Coremail.wangkailong@jari.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 23 Oct 2022 21:07:00 +0800 (GMT+08:00) KaiLong Wang wrote: > Fix the following coccicheck warning: > > net/ipv4/igmp.c:2621: WARNING opportunity for min() > net/ipv4/igmp.c:2574: WARNING opportunity for min() > net/ipv4/ip_sockglue.c:285: WARNING opportunity for min() > > Signed-off-by: KaiLong Wang Please don't send coccicheck fixes for net and drivers/net. (And I mean *you* specifically shouldn't send them since you don't even build test the fix.)