Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7289998rwi; Mon, 24 Oct 2022 12:26:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4IKJwNj4/2vgm5nBK/zR0cY+jPe1s9g4XGZX6WwMFK2x54uTd4fQ3cSq5h28RDzyiGb0H/ X-Received: by 2002:a17:907:7e95:b0:78d:e9cf:82c7 with SMTP id qb21-20020a1709077e9500b0078de9cf82c7mr29687472ejc.724.1666639562164; Mon, 24 Oct 2022 12:26:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666639562; cv=none; d=google.com; s=arc-20160816; b=MHw0C1lJRr2JPZZjq8fTWcM+bYyfOE+SYvXIOqCQSbTgNUWSRhJQmmQyMSHF3qsz32 YXQ7uYfA6qNqsnUlh5T3g46vibJXnkL9Xq5LZHg+HK7wLRiedLCARMkBPa8EJiSICvhE a6TX2nC1pG7f/bHWbY6JzwJOehzTftDHb553WuVkF8Ul0sVYgqUwk+xgmQAae+lheIqe PVPx/IvvC/ywwbR6e3WTjAGIGPbgGeEkkec6hRB7eMGo5b3guodDgvFYCQxbaY3/QZC8 oIYRNlA1F+ziCGY2hAZOzjeM0CkbOElmmbg47Dp5se0LTaa7jUsFLPaRmeQntu8n2+yZ Ayjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RAx6rLVJjn5BmqZ9cIXNrbm3R9fkMghF1ej2DK+Wt2U=; b=Z6WSRNIGCzmX/skrW2K+HcCb8cajySySH7OCJ5hv2xDHozKATU0NS4UnrG6j7FCv8w cVODfhvT3uyLfV9p8heTt2eeaeyJOaDF8h2RE2cZu/t6earTk090QFdw4u06bC+9x9+5 6Lb5EIqIeq1r5Pj6RZNleWTSC/WUmJzR6f9wyUyqzU9eabsxOVnL2/c9MyrIKu0M2Mwh RppOUzUnL96TRzTe2oZWY7slK6GSxyl49/C0El0Zjl6ogQXs1jKwP401DklA4D02toGK F71OHXhuQXHgwAGpMq1C1VyWqxUo2UaPStk/QRom2TSJVWjCJy1OpfqCUlwqzEu/p3n7 w1jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gwKio5oy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020a056402348200b004595a90c510si699960edc.3.2022.10.24.12.25.35; Mon, 24 Oct 2022 12:26:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gwKio5oy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbiJXTWI (ORCPT + 99 others); Mon, 24 Oct 2022 15:22:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232371AbiJXTVO (ORCPT ); Mon, 24 Oct 2022 15:21:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70886109D44; Mon, 24 Oct 2022 10:56:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9FBCCB81993; Mon, 24 Oct 2022 12:42:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF761C433D6; Mon, 24 Oct 2022 12:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615332; bh=w37r33LIb9FKUf6H97lfeWvSi5XF2Tniw+6hjdytPr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gwKio5oyw82X+j/h566UDPVwe2IuaAdfk0OGp6kkO7qyHQVchgaMUwQeATFlnp91S nP18GCF0vjOsPcq0ie4KzZTYpK9Wn1m616OU57e0CzrMSWWjIowqVuQpg3sjXP8PBL zurCMYhL8NBbRZZYxa4Vlfg1aiA8uZDJSK+TVUWE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Zimmermann , Maxime Ripard , Sasha Levin Subject: [PATCH 5.15 211/530] drm/mipi-dsi: Detach devices when removing the host Date: Mon, 24 Oct 2022 13:29:15 +0200 Message-Id: <20221024113054.622531204@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Ripard [ Upstream commit 668a8f17b5290d04ef7343636a5588a0692731a1 ] Whenever the MIPI-DSI host is unregistered, the code of mipi_dsi_host_unregister() loops over every device currently found on that bus and will unregister it. However, it doesn't detach it from the bus first, which leads to all kind of resource leaks if the host wants to perform some clean up whenever a device is detached. Fixes: 068a00233969 ("drm: Add MIPI DSI bus support") Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220711173939.1132294-2-maxime@cerno.tech Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 5dd475e82995..2c43d54766f3 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -300,6 +300,7 @@ static int mipi_dsi_remove_device_fn(struct device *dev, void *priv) { struct mipi_dsi_device *dsi = to_mipi_dsi_device(dev); + mipi_dsi_detach(dsi); mipi_dsi_device_unregister(dsi); return 0; -- 2.35.1