Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7369589rwi; Mon, 24 Oct 2022 13:40:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM55OMWDbqXT+XC37nM5I/K8qw16Of+nXtDz/1HjVsOu98lLOiEBxr1SnSrrb0mHzTKi/E+p X-Received: by 2002:a17:907:6d03:b0:782:abba:936c with SMTP id sa3-20020a1709076d0300b00782abba936cmr29340031ejc.758.1666644001476; Mon, 24 Oct 2022 13:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666644001; cv=none; d=google.com; s=arc-20160816; b=RLFZEQRT8OpRmWfyEBBUMW8bMpIK/qt84iTMs6wvH2LGTbC/a3MBUo6TB+4VshtZ69 0zhsnZGUiSBwe8MGO4Ylo4iCRnqoaebZB4Tbn6DOvKlPZwle6SxWK1nBJLZcgLOEAmr8 A9kllWd946sW7n726/gadqY4qtJ5Y7dNKdILQZjEdXzNRGijdw6LJZogMLxml9T+ZpAD r0kQVwIrbb8CWWzuTOifkq0ZJPXhAGAMlkYOdSgegTvw03IQdnT51aeGzIYmJ4MN/McM oodiQ69wYUL7CPvc95Nd5GQ7GBnHtTaswQqOq/EISLAeVabHOGcH/NR4SzT1DPj7WR1x Tbmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/ZZxteHC9SLoOj5aJCbFplJq6CyvYqoYsqzacvUGjq8=; b=YwZH0wgnxphrfmP/40erKReE13a2+4EGVp0GWVg/BufLsrpEuCGafaDdRHkzCV+0dK VIeZxDisvIxHS7aprXAAhkTY9IdWHg0yfjmUZ8xIQdMeaWhGGmncYApGOJy5XLXvpfT9 NWVy7JuSiP8+xw54nh77W1gLqBcy4aUuiZSymdrn00bVoljb5TE1SgyBsmrvEtPbuAJ8 OV5U1prUrVboPtWS8KkUStW2LcvavB6DdsPNN4hnQu4TUCxEuyoauzd9RjOX4KSQmmI6 HmmAESKpEu4pPFpFus0DsvhwxfqL4364rX9BH/8axEF8KG3amiSRQay9b5ehAHzmfGof 3isg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J4B37YgB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr18-20020a170906d55200b0077ef2f9c8b7si675156ejc.922.2022.10.24.13.39.36; Mon, 24 Oct 2022 13:40:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=J4B37YgB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234557AbiJXUh3 (ORCPT + 99 others); Mon, 24 Oct 2022 16:37:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbiJXUgi (ORCPT ); Mon, 24 Oct 2022 16:36:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 417C6D2E2; Mon, 24 Oct 2022 11:48:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 72600B81999; Mon, 24 Oct 2022 12:43:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6BCDC433D6; Mon, 24 Oct 2022 12:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615429; bh=nNKAQ3i0wiJd72HKsfnVhMi/xXXab3eMPr7Tq3CWO8Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J4B37YgBn7f5EyMRNMwzyld/jhsfhCx0D4/JJzXGA0nXsLTh07TiCCSuswbsewvvA LrUItegzDRjkm9pzOQfj0bHVN7lXuWzncgx+x4J6JVwBa6EQiDtQBfpioEiXvVt6oc ehoEIx7i1QHxy8ajS07nz5niVLOW5bQsD+A7/Xa4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Tomi Valkeinen , Sasha Levin Subject: [PATCH 5.15 230/530] drm/omap: dss: Fix refcount leak bugs Date: Mon, 24 Oct 2022 13:29:34 +0200 Message-Id: <20221024113055.498379556@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liang He [ Upstream commit 8b42057e62120813ebe9274f508fa785b7cab33a ] In dss_init_ports() and __dss_uninit_ports(), we should call of_node_put() for the reference returned by of_graph_get_port_by_id() in fail path or when it is not used anymore. Fixes: 09bffa6e5192 ("drm: omap: use common OF graph helpers") Signed-off-by: Liang He Signed-off-by: Tomi Valkeinen Link: https://patchwork.freedesktop.org/patch/msgid/20220722144348.1306569-1-windhl@126.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/omapdrm/dss/dss.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index d6a5862b4dbf..7567e2265aa3 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1176,6 +1176,7 @@ static void __dss_uninit_ports(struct dss_device *dss, unsigned int num_ports) default: break; } + of_node_put(port); } } @@ -1208,11 +1209,13 @@ static int dss_init_ports(struct dss_device *dss) default: break; } + of_node_put(port); } return 0; error: + of_node_put(port); __dss_uninit_ports(dss, i); return r; } -- 2.35.1