Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of opensynergy.com
 designates 217.66.60.4 as permitted sender) receiver=protection.outlook.com;
 client-ip=217.66.60.4; helo=SR-MAIL-03.open-synergy.com; pr=C
From:   Igor Skalkin <Igor.Skalkin@opensynergy.com>
To:     virtualization@lists.linux-foundation.org, luiz.dentz@gmail.com,
        mst@redhat.com
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, jasowang@redhat.com,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        Igor Skalkin <Igor.Skalkin@opensynergy.com>
Subject: [PATCH v3 0/1] virtio_bt: Fix alignment in configuration struct
Date:   Mon, 24 Oct 2022 15:40:32 +0200
Message-Id: <20221024134033.30142-1-Igor.Skalkin@opensynergy.com>
In-Reply-To: <20221018191911.589564-1-Igor.Skalkin@opensynergy.com>
References: <20221018191911.589564-1-Igor.Skalkin@opensynergy.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:40:59.1956
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 11bd2c82-b347-487c-ed2a-08dab5c56289
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=800fae25-9b1b-4edc-993d-c939c4e84a64;Ip=[217.66.60.4];Helo=[SR-MAIL-03.open-synergy.com]
X-MS-Exchange-CrossTenant-AuthSource: VI1EUR05FT010.eop-eur05.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8770
X-TM-AS-ERS: 104.47.12.52-0.0.0.0
X-TMASE-Version: StarCloud-1.3-9.0.1006-27220.007
X-TMASE-Result: 10-1.841600-4.000000
X-TMASE-MatchedRID: k/56TffKUsg4vjIDbvA3OMVUBXy8OM3/M9EkAUzyluGAI7Mvq/sL57ek
        d2LX0DpINaAGdu5Ot0eXJbVmtnHrxnI0shGAc7FenVTWWiNp+v+wQ8dOma+kqrwxqSK0GSPRjFK
        /NcS7G4llfaF/BQ/tikrFr2FVZxb3hYCiPfz7etn3dt27LH8hnKxAhf/GPomfeGHkpR2WBaL6Pq
        wEmsq4onoKNsImo9ohuXFEQJaCEz7+OhQWBlKflRRFJJyf5BJenOXVXbtyRcZUMLUJu4leYyq2r
        l3dzGQ11VrbCslo1IPzdrwMaU6LTMVEUeIHhCKcPpsnApkCOkM22y3gb14N8g==
X-TMASE-XGENCLOUD: 41de61e5-7a29-48f4-ad5f-068e5c6e9b47-0-0-200-0
X-TM-Deliver-Signature: CE0A99EB907CC0AE3CBC5D1BBF2D5FA8
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opensynergy.com;
        s=TM-DKIM-20210503141657; t=1666618866;
        bh=LiTSONCq/pWfBg/3qES81Hhk0fxoeYLdcH3ISspf2kQ=; l=1320;
        h=From:To:Date;
        b=oVZJ+pBoTFsa4Xd/jB8f0DpuLtbmjpVUqITQOthmUe3ttiqtGp7eFEOBBHR4nn5Bg
         Q7GHFoorleOe9bsYeysXYonMdvOMF1AZQh2JjZS7DkCTGRHgk7MR9NuG3hl4tTZgko
         lt+5Zfforpes8Y4MdOKiSnhrCiV/iT9vKgUNa4T9jQjIwaJQMemHvR1zuK6YZpgp9V
         h6BvFqmCG6UPUWYhYErcQIkgGdEdwEmPWR+UY9pOjOFCG5LNEO8jnRR4Ii94JoUtjH
         0WRMafcZ4Q4yFUfeTlzl35sANppmraAlwnCIvSB/ktqEKNTD21vThX006VDQWpJxiN
         8cARgnxGIE6nQ==
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

According to specification [1], "For the device-specific configuration
space, the driver MUST use 8 bit wide accesses for 8 bit wide fields,
16 bit wide and aligned accesses for 16 bit wide fields and 32 bit wide
and aligned accesses for 32 and 64 bit wide fields.".

Current version of the configuration structure has non-aligned 16bit
fields.

This patch adds a second, aligned  version of the configuration structure
and a new feature bit indicating that this version is being used.

[1] https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.pdf

Changes in v4:
  v3 was corrupted by our smtp server.
Changes in v3:
  v2 had been sent from the wrong address, fixed.
Changes in v2:
  The first version of this patch just changed the configuration
  structure in uapi/linux/virtio_bt.h
  This can not be done, because it will break the userspace, so the
  second version offers a less radical approach - it introduces a new
  feature bit and a new configuration structure that both the device
  and the driver will use if this bit is negotiated.

Igor Skalkin (1):
  virtio_bt: Fix alignment in configuration struct

 drivers/bluetooth/virtio_bt.c  | 16 +++++++++++++---
 include/uapi/linux/virtio_bt.h |  8 ++++++++
 2 files changed, 21 insertions(+), 3 deletions(-)

-- 
2.37.2