Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7383836rwi; Mon, 24 Oct 2022 13:55:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5dkwLD40cxxOo7N2qeqdb66mCLbabUenyPAGP9qdyODDe5stoLieqSraIRdxMwrxj8paGb X-Received: by 2002:a17:902:f54f:b0:186:a437:f4d1 with SMTP id h15-20020a170902f54f00b00186a437f4d1mr7551356plf.168.1666644902913; Mon, 24 Oct 2022 13:55:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666644902; cv=none; d=google.com; s=arc-20160816; b=hqC8V1VnW1ugAjGBUsVSQR+64RCT4Ptw3HIoeI9G70b4GjWv9quiAb8dOy7aSmNZGg emp44WbKUe8ijOIOOJhhb+5Mqd6+2Da8gRit0cpGvlxyfZL1epnvM3RO49nR08ACmFxU M/t6Sdna5YVB80OCz5YEvz/cjWP/mZz0rJQjvD40YVeVPm761oyK2d6WEjLe9mP7z7Q8 C05QJd7m0bHDsNZH8s0ZOA7DAZP+GWquhIDIQPpzqn2DhILOxAwfY84TMflI7g1BTSSO KCKsEndIqRK+xSZQyDxUIUTJvvwNxOB1k5wAH0NqjYtWrnJyrjrN+JvVHyuhD1++k352 ZiYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rmYsPiQAe01mPUbVVVEiS6SzJmrWKoOMvVqAUcXlI3E=; b=g6FTPN4SipD5NOXBIfWt6dDjl6F6gXhdL5avrwKVcjN33dXQQ/ypTPd582HdUVKppG LUBqHFi69thiCtdfmF5wKddE+dDF9JhV7fdL4S65LMMnHe0m7UqwgYBGTxLWULku5zQr gkWSQfQlgH29r+10DuZyaF5U6sjxxOyaYNslL5hOC7sGs21rUHqiYUgp+XYh8c8RFbF3 UWK2AzTP736WsftHDwPZlLQkJm6aFOqBSZBgikf9YkRzwSfJc8pSQ6YsJB+1x73lLbKU GCqOg5xNnAt1Q8YSTVutiWf0gJ49sf0huIR3XnD23el0FHITtybZbLltKqf8+5sa49OV BZsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tv4ds0D7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l10-20020a63ea4a000000b00438f77814b2si590236pgk.124.2022.10.24.13.54.50; Mon, 24 Oct 2022 13:55:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tv4ds0D7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbiJXUKm (ORCPT + 99 others); Mon, 24 Oct 2022 16:10:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbiJXUIg (ORCPT ); Mon, 24 Oct 2022 16:08:36 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D64E340039; Mon, 24 Oct 2022 11:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=rmYsPiQAe01mPUbVVVEiS6SzJmrWKoOMvVqAUcXlI3E=; b=tv4ds0D7DIvDaukA98ZSEiuXsj 5bqFYvG7Kxc26coWWzyB01UmgmfRdJ9NHPgGN6+MQ7K4t49rWSudQCsuaeA2oImMNf7NVrvZZ9/uD LvzpmEf/Q3O+XSsEElVRnf67XBDZEQpKYSLXlClNzP2bbrz/OL+1qNcB8wfxo54awzWM5rIQW5SQ/ mR7WVWNmsqKU02JvuN3+2ectX7Y6LsXwS8vxfIVuIqrpT2VhpH1Qyb4ulEE9SK5kFgYa/qJZTiELn BbRs/CqIvv5s4bT0EFrEYnFdKZlIxXYw4/DTUf4Iv1wnoozDaByH7HaF9dz2HWVwJ+sJRQ7vuPAgn 7hdtcQuA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1on1Jk-002Tzq-40; Mon, 24 Oct 2022 17:32:52 +0000 Date: Mon, 24 Oct 2022 10:32:52 -0700 From: Christoph Hellwig To: Andrew Cooper Cc: Christoph Hellwig , Juergen Gross , "jejb@linux.ibm.com" , Sreekanth Reddy , Bart Van Assche , Salvatore Bonaccorso , "sathya.prakash@broadcom.com" , "suganath-prabu.subramani@broadcom.com" , "Martin K. Petersen" , "MPT-FusionLinux.pdl@broadcom.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "adi@kriegisch.at" Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y. Message-ID: References: <85ad4508-b979-c792-e92b-01bc16260dec@acm.org> <2fd505a07bd26d76f1166761fa50905414edb7ef.camel@linux.ibm.com> <30a056c8-071f-4259-3253-75e718af619d@suse.com> <858a4288-46ac-d423-a529-b3b77b7fbc8a@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <858a4288-46ac-d423-a529-b3b77b7fbc8a@citrix.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 05:28:05PM +0000, Andrew Cooper wrote: > I don't know exactly how this translates to Linux internals, but most > devices are fine and it's routinely the mpt2/3sas drivers which > encounter problems.? It would be lovely if we could get to the bottom of > this for once and for all. So to summarize my two mails: I think te use of dma_get_required_mask in mpt3sas is wrong, and the dma_get_required_mask return value from xen-swiotlb is also wrong. Fixing either one should fix this problem, and I think we should fix both.