Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 20:42:36 +0200
From:   Frank Wunderlich <linux@fw-web.de>
To:     =?ISO-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E_Prado?= 
        <nfraprado@collabora.com>
CC:     linux-mediatek@lists.infradead.org,
        Frank Wunderlich <frank-w@public-files.de>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Wenbin Mei <wenbin.mei@mediatek.com>,
        linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v3_2/7=5D_dt-bindings=3A_mmc=3A_?= =?US-ASCII?Q?mtk-sd=3A_Set_clocks_based_on_compatible?=
User-Agent: K-9 Mail for Android
In-Reply-To: <20221024164353.jzvx4ea442e4vahj@notapiano>
References: <20221023091247.70586-1-linux@fw-web.de> <20221023091247.70586-3-linux@fw-web.de> <20221024164353.jzvx4ea442e4vahj@notapiano>
Message-ID: <9940F0A3-9834-4614-A838-2E15BEABAC94@fw-web.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Am 24=2E Oktober 2022 18:43:53 MESZ schrieb "N=C3=ADcolas F=2E R=2E A=2E Pr=
ado" <nfraprado@collabora=2Ecom>:
>Hi,
>
>thank you for picking this up=2E
>
>On Sun, Oct 23, 2022 at 11:12:42AM +0200, Frank Wunderlich wrote:
>> From: N=C3=ADcolas F=2E R=2E A=2E Prado <nfraprado@collabora=2Ecom>
>>=20
>> The binding was describing a single clock list for all platforms, but
>> that's not really suitable:
>>=20
>> Most platforms using at least 2 clocks (source, hclk), some of them
>> a third "source_cg"=2E Mt2712 requires an extra 'bus_clk' on some of
>> its controllers, while mt8192 requires 8 clocks=2E
>>=20
>> Move the clock definitions inside if blocks that match on the
>> compatibles=2E
>>=20
>> I used Patch from N=C3=ADcolas F=2E R=2E A=2E Prado and modified it to =
not using
>> "not" statement=2E
>>=20
>> Fixes: 59a23395d8aa ("dt-bindings: mmc: Add support for MT8192 SoC")
>> Signed-off-by: N=C3=ADcolas F=2E R=2E A=2E Prado <nfraprado@collabora=
=2Ecom>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files=2Ede>
>>=20
>> ---
>> v2:
>> - add this patch
>> v3:
>> - add blank lines and change "not" to matchlist
>> - reorder entries - make generic first then order alphanumeric
>> - rewrite commit description
>> - drop soc-specific mt8183 - constraints were also set for it above
>
>This is wrong, see below=2E

You are right,will fix in v4

>> ---
>>  =2E=2E=2E/devicetree/bindings/mmc/mtk-sd=2Eyaml       | 113 ++++++++++=
+++-----
>>  1 file changed, 83 insertions(+), 30 deletions(-)
>>=20
>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd=2Eyaml b/Docu=
mentation/devicetree/bindings/mmc/mtk-sd=2Eyaml
>> index 3cbf0208f1b4=2E=2E31bb6dc329d2 100644
>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd=2Eyaml
>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd=2Eyaml
>[=2E=2E]
>> =20
>> -if:
>> -  properties:
>> -    compatible:
>> -      contains:
>> -        const: mediatek,mt8183-mmc
>> -then:
>> -  properties:
>> -    reg:
>> -      minItems: 2
>
>You can't drop this=2E Nodes with the mt8183 compatible should keep requi=
ring two
>reg values=2E It's not covered by the branch below=2E
>
>Thanks,
>N=C3=ADcolas


regards Frank