Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7403806rwi; Mon, 24 Oct 2022 14:14:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6wOt4ijZq+ep9IDdjXQ5mRkXJt0RTchdTybpnrBpzGU9pzTvSWFupaBBmXOeZa8oj3ynlo X-Received: by 2002:a17:907:1c96:b0:78d:fe6b:9891 with SMTP id nb22-20020a1709071c9600b0078dfe6b9891mr29007503ejc.746.1666646052432; Mon, 24 Oct 2022 14:14:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666646052; cv=none; d=google.com; s=arc-20160816; b=EjeRZ0SnumTB1o4Vpab87cl0+vdEeN1pp/LiSMkOJRj5qn2LWJq65R2zsPcALU8Jvw 2nmdG6vRk5nSJrmPgjXynRP1D3IhbHfLD0+EtLueIF6b8B0Hwgbo5EGmGdYIRu37Mhow Of9br823qISgbs2ykfBxMhtRxZLsVK4aMu6tqjDrQR09ZHjWMSITfQMIr2+SSFCH5LqD HyCR459GCmzVkPS/xNBW/KkjvfRCbS7o24S4rE4zwDb7nEeGTPNpCPavBcpmISA0hasl KnfvcwxbJktEsVJbLokMjUugK9kE2qDSjz3kc9kfoidqEBden2tJV7yKwhvZlRObI/HC osdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=eYvdGV7HErY3m6x/34NUjZozQTewVyFRf1GwTCwrHhs=; b=RwEIRlQh903POrVrHIpzf7gyYx1LhLOsQU1ZxBat7UNzZgCOWVUWuWH4l7tDFBqT8l xtjik6JakhHttshO9ULleJsL1ShKEbJmfdr0HHh7G4UduYl1WepMw3O1mxBnEpLZ9fTZ 0awBmPpfKLwcyT/5Bkn6ftmbZ4HJDPkK5/g2lhdBS+i8IRkyvvAA4Koq/vYSWkPE/igM detkF26q6CwgqHRcsSfs1WrrTIQTE8LMgDw97itLcVNppWz21xvCmGYG+0QZAmwg6m1S BkT0yILc8lEhCxqAj6fnhu3tXuM+fgMDBEQGQnsHdSAQqDGY40/kM3EYY5mDPxvZI4eK x/Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a2-20020aa7d902000000b0045bc92ef2c0si678727edr.195.2022.10.24.14.13.30; Mon, 24 Oct 2022 14:14:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233784AbiJXU7k (ORCPT + 99 others); Mon, 24 Oct 2022 16:59:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235424AbiJXU7V (ORCPT ); Mon, 24 Oct 2022 16:59:21 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BB74416D563 for ; Mon, 24 Oct 2022 12:05:36 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 109D6150C; Mon, 24 Oct 2022 08:24:02 -0700 (PDT) Received: from [10.57.68.77] (unknown [10.57.68.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DCFA3F792; Mon, 24 Oct 2022 08:23:54 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 16:23:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] coresight: cti: Remove unused variables in cti_{dis,en}able_hw() To: Nathan Chancellor , Mathieu Poirier Cc: Mike Leach , Leo Yan , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221024151201.2215380-1-nathan@kernel.org> From: Suzuki K Poulose In-Reply-To: <20221024151201.2215380-1-nathan@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nathan On 24/10/2022 16:12, Nathan Chancellor wrote: > Clean up the following warnings, as the variables are no longer used. > > drivers/hwtracing/coresight/coresight-cti-core.c:93:17: warning: unused variable 'dev' [-Wunused-variable] > struct device *dev = &drvdata->csdev->dev; > ^ > drivers/hwtracing/coresight/coresight-cti-core.c:154:17: warning: unused variable 'dev' [-Wunused-variable] > struct device *dev = &drvdata->csdev->dev; > ^ > 2 warnings generated. > > Fixes: 665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()") > Signed-off-by: Nathan Chancellor Thanks for your patch, this is now reverted upstream. I have queued a patch locally to sqaush the changes and plan to push it once the revert lands upstream. Thanks Suzuki