Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4a70a29-4c27-c091-4332-dc476e258b74@gmail.com>
Date:   Mon, 24 Oct 2022 19:43:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 00/17] staging: r8188eu: clean up mlme handlers
Content-Language: en-US
To:     Martin Kaiser <martin@kaiser.cx>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20221024081417.66441-1-martin@kaiser.cx>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20221024081417.66441-1-martin@kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/24/22 10:14, Martin Kaiser wrote:
> This series cleans up the mlme handlers that process incoming management
> frames.
> 
> We can reorder the handler functions and remove forward declarations. We
> can also remove unused return values and simplify the error handling.
> 
> This series should be applied after the "some more small cleanups" series.
> 
> As usual, this series was tested with EdimaxV2 on an arm32 system.
> 
> Martin Kaiser (17):
>    staging: r8188eu: restructure mlme subfunction handling
>    staging: r8188eu: make OnAssocReq static
>    staging: r8188eu: make OnAssocRsp static
>    staging: r8188eu: make OnProbeReq static
>    staging: r8188eu: make OnProbeRsp static
>    staging: r8188eu: make OnBeacon static
>    staging: r8188eu: make OnDisassoc static
>    staging: r8188eu: make OnAuthClient static
>    staging: r8188eu: make OnDeAuth static
>    staging: r8188eu: make OnAction static
>    staging: r8188eu: make OnAuth static
>    staging: r8188eu: change mlme handlers to void
>    staging: r8188eu: remove unnecessary label
>    staging: r8188eu: remove unnecessary else branch
>    staging: r8188eu: remove unnecessary return
>    staging: r8188eu: remove an else branch
>    staging: r8188eu: go2asoc is not needed
> 
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c   | 226 ++++++++----------
>   .../staging/r8188eu/include/rtw_mlme_ext.h    |  23 +-
>   2 files changed, 100 insertions(+), 149 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150