Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20211209103505.197453-1-vkoul@kernel.org> <20211209103505.197453-11-vkoul@kernel.org>
 <5035b6a3-164b-afa0-b714-4deb886f9f90@linaro.org> <9f696023-f2b4-ccd0-34a0-6f4d5848e862@linaro.org>
 <8c1428a6-f268-cb03-3e55-887d30236924@linaro.org> <3af48606-731f-6047-92ca-80435f401ae3@linaro.org>
 <d5726896-e62b-d19d-454b-700dd1c42222@linaro.org>
In-Reply-To: <d5726896-e62b-d19d-454b-700dd1c42222@linaro.org>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Mon, 24 Oct 2022 21:58:48 +0300
Message-ID: <CAA8EJpovd0D154QUG1_EtCnCrffJBt+SPWQtLEZWb=dc_PLGjA@mail.gmail.com>
Subject: Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Vinod Koul <vkoul@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 24/10/2022 12:48, Dmitry Baryshkov wrote:
> > On 24/10/2022 19:46, Krzysztof Kozlowski wrote:
> >> On 24/10/2022 12:45, Dmitry Baryshkov wrote:
> >>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote:
> >>>> On 09/12/2021 05:35, Vinod Koul wrote:
> >>>>> Add the spmi bus as found in the SM8450 SoC
> >>>>>
> >>>>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> >>>>> ---
> >>>>>    arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++
> >>>>>    1 file changed, 18 insertions(+)
> >>>>>
> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> >>>>> index f75de777f6ea..b80e34fd3fe1 100644
> >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> >>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 {
> >>>>>                           interrupt-controller;
> >>>>>                   };
> >>>>>
> >>>>> +         spmi_bus: spmi@c42d000 {
> >>>>> +                 compatible = "qcom,spmi-pmic-arb";
> >>>>> +                 reg = <0x0 0x0c400000 0x0 0x00003000>,
> >>>>> +                       <0x0 0x0c500000 0x0 0x00400000>,
> >>>>> +                       <0x0 0x0c440000 0x0 0x00080000>,
> >>>>> +                       <0x0 0x0c4c0000 0x0 0x00010000>,
> >>>>> +                       <0x0 0x0c42d000 0x0 0x00010000>;
> >>>>
> >>>> This is a patch from December 2021. Is there anything blocking it from
> >>>> being merged?
> >>>>
> >>>> The same applies to several other patches here.
> >>>
> >>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support
> >>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT
> >>> parts.
> >>
> >> Why we cannot merge DTS? How is DTS with new nodes depending on any
> >> driver changes?
> >
> > In this particular case, there was an open question, what should be the
> > bindings for the PMIC ARB v7.
>
> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait
> with this one. I just had an impression that it's about driver changes...

Yes, it's about binding. Thus we have been waiting for quite some time.

>
> >
> >>
> >> Just like I replied to Konrad - if that's true, bindings are simply
> >> wrong and should be fixed.
> >
> > Maybe I missed the reply. Which email are you referring to?
>
> I meant about this one:
>
> https://lore.kernel.org/linux-arm-msm/8c1428a6-f268-cb03-3e55-887d30236924@linaro.org/T/#m50f4c72775492046f9b0a172e974cab83563af3c

Ack, for some reason I got it later than the previous one.

>
> Best regards,
> Krzysztof
>


-- 
With best wishes
Dmitry