Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7478655rwi; Mon, 24 Oct 2022 15:29:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Gm1I260eJGJzwOPZV/3wi14op9i6Gaz3kDkhxfLwa4elUlcHJq9JnrBVLGZTGZI2jumFu X-Received: by 2002:a63:e348:0:b0:46f:25cc:d554 with SMTP id o8-20020a63e348000000b0046f25ccd554mr2562896pgj.598.1666650565360; Mon, 24 Oct 2022 15:29:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666650565; cv=none; d=google.com; s=arc-20160816; b=HgMrSJG/4c5VdQoLAdoDniDjLyYLjqQORgVO04OLmSsjjvhqedTqRm9HjHojga3gDH n4qHBGsaIG+HFt2cvFsg8klKIHSZJJpXzJmp0n1ONfbGRf+tfXDlx2m2tFmtG3P30Zok cnXgUa6hiHXX2JZQ+k0AnlAIwe+7Aj7A3Tq1SkW8zzFYFTgugL/7D6RXmfTxymGSNLPd cmr6w/TZX+8oyp6Q4oQn6nFeKqutFvoqdG+m83NTepY9KfC2m6hv3ISPzAU3LGDhD7Kq S6AmyDzww5C2BZPQfjbqRJulgiklBasSa3S1B0E4v756Qodx8+nSmSuzuJJu8ZaIwZ6x ZEIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZvTI9bvNoKHsyFgiuzWKp14KnT6xFE5GhdT5g4Pt3Lk=; b=BULn9KQwMH8Aa+arUZIZXFHQHIhhVrtpq8gEoJVsYsZwGMWxuyU7JvR4GDzJiBm8VS /xjP69udwXGmP/XYfqPQp7K1A7lfS6DFTopTlUVWjMFpdkLz+co6NukQ6AVrHmsUSijh qK9sGbOEMw0PbkuBwcpqZRXr7TXhJSI8lWIji45uTgGA+wVhVS3WszOLjKA84i1kD7xC R1BxeIjpupKq0kvyFQp3/eiYY7K6m2bl9a2QUd6qGwRsE8xgWVkomXcVWn55QW6W28Qp mezsscuEUzEoAnCwcIfrbv4st5+L0fX9hw21muwjnknEAdioF8FolE+2h1VhLwj3lkAe YbLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jUpGFyFB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a63db45000000b0043cb5d08908si803818pgi.138.2022.10.24.15.29.13; Mon, 24 Oct 2022 15:29:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jUpGFyFB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231852AbiJXWEj (ORCPT + 99 others); Mon, 24 Oct 2022 18:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231967AbiJXWEC (ORCPT ); Mon, 24 Oct 2022 18:04:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E5D050531; Mon, 24 Oct 2022 13:18:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9ACD861286; Mon, 24 Oct 2022 12:40:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B234BC433C1; Mon, 24 Oct 2022 12:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615222; bh=hkN++V+EZziRXwAqDFEpFocfj0LhpT6OEj3yMchgpAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jUpGFyFBXnr//HfjdXtjxnr/hMQ71oLMyU+KLkObn8hki+NUGdV7uA6iMv8+Lkpqq epsL+5rLwIdggGDl/8eb/iIJ45Jz+FUHTlf/hAEvwrJOz5bXGHpOZmOig2px421gC3 WI4mb7wWqfFw63NMsbskx3dTQnmxDtlyk4sy/8Bk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lyude Paul , Karol Herbst Subject: [PATCH 5.15 128/530] drm/nouveau/kms/nv140-: Disable interlacing Date: Mon, 24 Oct 2022 13:27:52 +0200 Message-Id: <20221024113050.860144557@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lyude Paul commit 8ba9249396bef37cb68be9e8dee7847f1737db9d upstream. As it turns out: while Nvidia does actually have interlacing knobs on their GPU still pretty much no current GPUs since Volta actually support it. Trying interlacing on these GPUs will result in NVDisplay being quite unhappy like so: nouveau 0000:1f:00.0: disp: chid 0 stat 00004802 reason 4 [INVALID_ARG] mthd 2008 data 00000001 code 00080000 nouveau 0000:1f:00.0: disp: chid 0 stat 10005080 reason 5 [INVALID_STATE] mthd 0200 data 00000001 code 00000001 So let's fix this by following the same behavior Nvidia's driver does and disable interlacing entirely. Signed-off-by: Lyude Paul Cc: stable@vger.kernel.org Reviewed-by: Karol Herbst Link: https://patchwork.freedesktop.org/patch/msgid/20220816180436.156310-1-lyude@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -503,7 +503,8 @@ nouveau_connector_set_encoder(struct drm connector->interlace_allowed = nv_encoder->caps.dp_interlace; else - connector->interlace_allowed = true; + connector->interlace_allowed = + drm->client.device.info.family < NV_DEVICE_INFO_V0_VOLTA; connector->doublescan_allowed = true; } else if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS ||