Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa9ebdef1f1dbfceb5a32f5f437b865861976957.camel@linux.ibm.com>
Subject: Re: Report in downstream Debian: mpt3sas broken with xen dom0 with
 update to 5.10.149 in 5.10.y.
From:   James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To:     Juergen Gross <jgross@suse.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Bart Van Assche <bvanassche@acm.org>
Cc:     Salvatore Bonaccorso <carnil@debian.org>,
        sathya.prakash@broadcom.com, suganath-prabu.subramani@broadcom.com,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
        adi@kriegisch.at
Date:   Mon, 24 Oct 2022 14:50:26 -0400
In-Reply-To: <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
References: <Y1JkuKTjVYrOWbvm@eldamar.lan>
         <85ad4508-b979-c792-e92b-01bc16260dec@acm.org>
         <CAK=zhgr=MYn=-mrz3gKUFoXG_+EQ796bHEWSdK88o1Aqamby7g@mail.gmail.com>
         <016732f4-d129-69bb-4b5f-82198407ee5e@suse.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-OsMKRDmTTv0MyMAb4mqc"
User-Agent: Evolution 3.34.4 
MIME-Version: 1.0
Precedence: bulk


--=-OsMKRDmTTv0MyMAb4mqc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2022-10-24 at 14:55 +0200, Juergen Gross wrote:
[...]
> Please recheck the backported patch in 5.10.y. It is _wrong_. The
> backport
> has:
>=20
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -2993,7 +2993,7 @@ _base_config_dma_addressing(struct
> MPT3SAS_ADAPTER *ioc,=20
> struct pci_dev *pdev)
>=20
>          if (ioc->is_mcpu_endpoint ||
>              sizeof(dma_addr_t) =3D=3D 4 || ioc->use_32bit_dma ||
> -           dma_get_required_mask(&pdev->dev) <=3D 32)
> +           dma_get_required_mask(&pdev->dev) <=3D DMA_BIT_MASK(32))
>                  ioc->dma_mask =3D 32;
>          /* Set 63 bit DMA mask for all SAS3 and SAS35 controllers */
>          else if (ioc->hba_mpi_version_belonged > MPI2_VERSION)
>=20
> While the upstream patch has:
>=20
> +       if (ioc->is_mcpu_endpoint || sizeof(dma_addr_t) =3D=3D 4 ||
> +           dma_get_required_mask(&pdev->dev) <=3D 32) {
>                  ioc->dma_mask =3D 32;
> +               coherent_dma_mask =3D dma_mask =3D DMA_BIT_MASK(32);
>=20

That's not the upstream commit.  The quoted upstream patch in the
stable commit is:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3De0e0747de0ea3dd87cdbb0393311e17471a9baf1

Which has the same diff as you quoted for the stable tree.

James


--=-OsMKRDmTTv0MyMAb4mqc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iHUEABMIAB0WIQTnYEDbdso9F2cI+arnQslM7pishQUCY1becgAKCRDnQslM7pis
hSQsAQCC7A2xVu85X8YkyFbTrfUGtyIwNToEhWGfvxT9jzz20QD+JhzALYu83cJ2
RUsBjRW335CWiHkcm1rQRKHqXvW0RsM=
=vyiC
-----END PGP SIGNATURE-----

--=-OsMKRDmTTv0MyMAb4mqc--