Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7546649rwi; Mon, 24 Oct 2022 16:33:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5+RlnWkxKJ0wLnCZsFgxtdgDWxZyTzBMF/CJJOPkh8aD17cJ0PgKnffqB0J6KBsdyykVm/ X-Received: by 2002:a17:907:3e85:b0:73d:60cc:5d06 with SMTP id hs5-20020a1709073e8500b0073d60cc5d06mr30723348ejc.722.1666654434420; Mon, 24 Oct 2022 16:33:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666654434; cv=none; d=google.com; s=arc-20160816; b=NlwTFsovZDu0HJBuH5yvwnyUSmSetCKVQiPu1ADrog7otspMYnl8XPI/mdKOGz603M HzBtH7LVpeoe9HdeId8fbNaJI6Pjg3fPnSbRNE85EYQoPkd8IWZnDMyd+bo5SkuA27bI A9+S7f4vXQA+04jJe7vNzfmqiu66eCHSCi1/nnHqd7Csrefl/i7J7iHsuNpoHbvMEgb8 rM6ppxurFCbyUoglBgIg0RbIxYBB0Za+QA1EF6xlR/kgcMfpzDiBgsaSjNM4JTSnJPua RxQgMXzgIEpvIHA8M3Ty4dT1nWCDKirsTumWvtpp7Q7K3QgLtUQeZfrJCZ7gejlFTTBU xChA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=J8dief6RmUvmD02OG/vcLMjVH95bCM+Z/jlWfHifmfc=; b=08qN/Vutlz1aULWm35TOh1HF3Okwgthc4Kr07c9vCPx6RkNkL3t8p/B1bFmoEMJeMi NF6geWd2ArLcdSBTtY64w1CUZp3Y+VDge00m4Ffcfd3aJ9vFqV9RuM0vmtX3SrM7mbpA Pq8ePO1CVmBpPoPbMZp3/5/yseRTfGZixWfWEvJdkYyKlmrtKunhrhkbpwFnS5chJSON DOPCCPbnv24Bbi6AvHp+vAd7FmqhYD/rBTzng1LgXSCJKDREATfn06e+FLnw+7C0NeUc vhQ9N0kchDFPTC3140QFLUDZ84NhSxWyKeOIpGlUpdDE1xmTyjq0QdJ7F2cjS/nA3dvF rklA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=T9EjYDwM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga15-20020a1709070c0f00b0078db517075fsi1072990ejc.659.2022.10.24.16.33.29; Mon, 24 Oct 2022 16:33:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=T9EjYDwM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232168AbiJXWvN (ORCPT + 99 others); Mon, 24 Oct 2022 18:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232136AbiJXWum (ORCPT ); Mon, 24 Oct 2022 18:50:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6533200D3 for ; Mon, 24 Oct 2022 14:12:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38214B810F4 for ; Mon, 24 Oct 2022 20:17:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8445BC433C1; Mon, 24 Oct 2022 20:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1666642627; bh=pve3Synlkj6J6i7lSu93YkYeZZdRndbv6uz1vAXSx90=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T9EjYDwM/Ae7QhYWk18ZfQDUShXZj2tVAmRUMcw7GCIYWfPXvfAXhbguwEBsrXhI0 wsPM4qqXR81KWcOnxi51u0M+n6TRWkT3CGpttzRr8GtnOQHCzepzyWs60+otFFcc0p rjuz3SxOcz13igJ8VDFOBVeN0YX1DNxMpflHP9mo= Date: Mon, 24 Oct 2022 13:17:06 -0700 From: Andrew Morton To: Gautam Menghani Cc: rostedt@goodmis.org, mhiramat@kernel.org, zokeefe@google.com, shy828301@gmail.com, vbabka@suse.cz, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: Re: [PATCH v2] mm/khugepaged: add tracepoint to collapse_file() Message-Id: <20221024131706.3d58bd92c332684386c7df13@linux-foundation.org> In-Reply-To: <20221024173559.332324-1-gautammenghani201@gmail.com> References: <20221024173559.332324-1-gautammenghani201@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Oct 2022 23:05:58 +0530 Gautam Menghani wrote: > In the file mm/khugepaged.c, a TODO in the function collapse_file() asks > to add tracepoints. Add the tracepoint named "mm_khugepaged_collapse_file". This isn't a very satisfying explanation for changing the kernel. Maybe the comment is stale are this tracepoint is unneeded. Please explain afresh how this addition benefits kernel users?