Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 15:55:55 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     Chen Wandun <chenwandun@huawei.com>
Cc:     akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com
Subject: Re: [PATCH] mm: fix pcp count beyond pcp high in pcplist allocation
Message-ID: <20221024145555.oaoisy6m723h4axc@techsingularity.net>
References: <20221024134146.3442393-1-chenwandun@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20221024134146.3442393-1-chenwandun@huawei.com>
Precedence: bulk

On Mon, Oct 24, 2022 at 09:41:46PM +0800, Chen Wandun wrote:
> Nowadays there are several orders in pcplist, Function __rmqueue_pcplist
> would alloc pcp batch pages to refill pcplist, when list of target order
> if empty meanwhile other lists is not all empty, that result in pcp count
> beyond pcp high after allocation. This behaviour can be easily observed by
> adding debugging information in __rmqueue_pcplist.
> 
> Fix this by recalculate the batch pages to be allocated.

Are any problems observed other than the PCP lists temporarily exceed
pcp->high? As is, the patch could result in a batch request of 0 and
fall through to allocating from the zone list anyway defeating the
purpose of the PCP allocator and probably regressing performance in some
csaes.

The intention was to allow high to be briefly exceeded on the refill side,
particularly for THP pages and to always refill by at least two pages. In
the THP case, one would be allocated and maybe one in the near future
without acquiring the zone lock. If the limits are exceeded, it's only
exceeded until the next free.

-- 
Mel Gorman
SUSE Labs