Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4028a1c7-ed84-37a8-1d94-178b5aa201a9@intel.com>
Date:   Mon, 24 Oct 2022 15:52:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 02/14] platform/x86/intel/ifs: Propagate load failure
 error code
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-3-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-3-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y21GNDdLVVBHS0cxK2tuZGZkUjlqSStESkkyczFrV1NDODMwSGh1TUFaMXF6?=
 =?utf-8?B?VnZFYmh3d25jS2kxVXU2S0NYOUdOUFQrSjM3RUQ0UE4yMGtWREtqSUpPaTFQ?=
 =?utf-8?B?dmRHSHY3TUZPVGtabVRpQU9WTTMzQmJDNks2NmRJRGFxV0tKOEFrT3NkY1l5?=
 =?utf-8?B?NjBvY3JOT3JnNnNrV0hDbGM2T3hPelU2QTN1YUd3eU5vZTF2QmM4eTRrc1k5?=
 =?utf-8?B?UWEwRFF3UEkwUURqMlRUcnhkUy83azRraE1RUDM2YkRXeWRYdS8rR0xVbVdV?=
 =?utf-8?B?ZkN2eG95WkpWeTR0Z1J3cVZvbjJMWGZCbElTcktERUZJY25reklteXFGN2xr?=
 =?utf-8?B?b29SeEZFdXRGcysyRGdERWYwSFh5OCswbUtNM1NwM1FFMkF3S1FPQWwvMkVw?=
 =?utf-8?B?YTVtUGk5SUJlUWU4a280dUptLzJXdi94Ri8yR1d3M1NLaXB1YW1vcmdFTGd6?=
 =?utf-8?B?VFh6WUZPTU1qM0xoMHd0UzFjK0cyZmRQU241ZGNFWUc3Z1gwYUlRS0I3clAw?=
 =?utf-8?B?MW9KQklpNEtUcm9iUkNrb1ZlaFg4YmE3aE82dkY5ZnJrRFhMRUJ4WkpHcnZF?=
 =?utf-8?B?WCtZZWVzZEx4T0FPRlp0ZU1teHVaNFpjcHNnTDBZLzFTNG5Fa29HcWRwMnl5?=
 =?utf-8?B?a2tQMGt4WVZQaWo0MUR0SzJPTXJvRmdENmpTZFo3Nzc1MUtPWWlWRHUzYWZU?=
 =?utf-8?B?dzN0bnpNQzRIT3JmRnZUVWcvcytlOFNjTmRpU1JGVnd1SGhhOGd4dHJiOGF4?=
 =?utf-8?B?K3BOc3A2NkhMdTRuLzZ2OHJ1c0N1ckZiVDg1bW9uTkJUVmo0bkpSeFE1UUpa?=
 =?utf-8?B?N0hPazl5Qm5JbmRDcEgvdFBKcGZIaEhzUkd4TUpwc1M1RlIxaCtQQ1VpUVVs?=
 =?utf-8?B?TjR6dldtd3hucVNyeU9ha1FYZEVqZ3ovMC93YUFjd2x4ZHgzOXdodjlBNEhX?=
 =?utf-8?B?TFJIb21UYndmNjZFK09qYS9ZRk5GS3k2RlhRU0IxTmxubFBKM1JzSUcvYlh6?=
 =?utf-8?B?YWFmK0x1cHl2ZjN6NUIyTEwrTm14SXV4ckdTQ3J3YVJYWVZBTG5yQ0NheWMr?=
 =?utf-8?B?blhISmtxeWVobXJlZzNHbjA5MUxUeVJ1M3Z2QUNMYzdidVBzblZMVmpHdlJU?=
 =?utf-8?B?Unk2d3RBdDl3WkNGbmN3aDFkSGdpdnVkYi8wczluUW83QU1WNGNjcUpMQk9x?=
 =?utf-8?B?dDdsclhmTjh6N3ZyajVMOENSazl1TXFzbjh2bFdFQXhBSWF6T1FOeHNCUnZK?=
 =?utf-8?B?LzhGK2xEWUQxL1Vvd3ZxNGI5KzczN0V2NWVKT0RvQmUvRmJWTHpHUGxMbUNa?=
 =?utf-8?B?alBkMEEwY2pPcUZXMHRNa1hIaysvNEtpUFN2REZKYjVQbUJ4bld2ZWkxNlVJ?=
 =?utf-8?B?MHJqUGs2QWdEb3FIYnRQYzdoZFVjQUxMQms4MjIydG1EVTZ1N1RwbmpYYWVo?=
 =?utf-8?B?anI2Z3l5aUhFVVYwYzBrUjU1enNrOEVBOW1ZSWs4ZjMxRHlVWmk2dk1oUXJI?=
 =?utf-8?B?VElYSjV4eWhlRmpWTzZaanlSa1VVc2hiQktTelo4Ui9ldFdLdldZNkZrRmZV?=
 =?utf-8?B?OHdSZXppb3hDdzNrNk9Zd3JZcjZZbEdVb0hsN3FERXM4Tmx4R1ZPaHZXSXlV?=
 =?utf-8?B?cWlsdjBkVE0yU3QxaG5iMURpVE53eHZmSlJycGozRWpPQW5aREorSGM2cmcr?=
 =?utf-8?B?MTFzWVhEWVpjeGRPQWhGQ0NMNU5Qak9yRk0ydXJwOXptY2plb3IyaTdzSkxO?=
 =?utf-8?B?bzUzcVlZeHdZUFJNcFI3eHpiUHoxUW9ZYkZId0dQTHJyNHpZenVTOXJIL2M4?=
 =?utf-8?B?YitPYjRDdVA0WmR1eTg0dDJZY1dMcHc2V2JCcTZHQk5mSUhIZWxUN09HL2ND?=
 =?utf-8?B?dnFEdXF4RjU1NjZjOEwwb0RLdkxZNCt3dHhlNnI1eXFpQmdRSENjT1d1L0JV?=
 =?utf-8?B?eTNKU2ZMaWlHazJuWE5yU1ZlcCtFRitLMGdrS0YzMUZZcmRCQmhJam9lekZJ?=
 =?utf-8?B?cWdDeDJqZVBJY29VWUdDWGp2MUFOM2F4QWlJdHErbWJ5STZTQk91ckZiRmFX?=
 =?utf-8?B?YVF2M2FQWHViOVEySW0rYVFmd1E0UGFJTEZlNUlzZlAvWTZKMTA1eFZvM0I4?=
 =?utf-8?Q?PuNo1UPAT0p7nsC8LpbTZXjHA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b7ee8823-3d69-4838-de7a-08dab61261ca
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 22:52:09.4104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oGL9lJjExk87iov24kmUZwdqrc2gr6H3bi8kie6ob+lra640/ul/7onqcKHoSvxzW0C1G1apRJwjlN2T/X3y4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5261
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jithu,

On 10/21/2022 1:34 PM, Jithu Joseph wrote:
> Existing implementation was returning fixed error code to user space
> regardless of the load failure encountered.
> 

The tense is a bit confusing here. Also, 'Existing implementation' is 
typically implied and unnecessary. Would something like this be better?

The reload operation returns a fixed error code to user space regardless 
of the load failure encountered.

Modify..

> Modify this to propagate the actual error code to user space.
> 

...

> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
> index d056617ddc85..ebaa1d6a2b18 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -234,7 +234,7 @@ static bool ifs_image_sanity_check(struct device *dev, const struct microcode_he
>    * Load ifs image. Before loading ifs module, the ifs image must be located
>    * in /lib/firmware/intel/ifs and named as {family/model/stepping}.{testname}.
>    */
> -void ifs_load_firmware(struct device *dev)
> +int ifs_load_firmware(struct device *dev)
>   {
>   	struct ifs_data *ifsd = ifs_get_data(dev);
>   	const struct firmware *fw;
> @@ -263,4 +263,6 @@ void ifs_load_firmware(struct device *dev)
>   	release_firmware(fw);
>   done:
>   	ifsd->loaded = (ret == 0);
> +
> +	return ret;
>   }
> diff --git a/drivers/platform/x86/intel/ifs/sysfs.c b/drivers/platform/x86/intel/ifs/sysfs.c
> index 37d8380d6fa8..4af4e1bea98d 100644
> --- a/drivers/platform/x86/intel/ifs/sysfs.c
> +++ b/drivers/platform/x86/intel/ifs/sysfs.c
> @@ -94,9 +94,8 @@ static ssize_t reload_store(struct device *dev,
>   			    struct device_attribute *attr,
>   			    const char *buf, size_t count)
>   {
> -	struct ifs_data *ifsd = ifs_get_data(dev);
>   	bool res;
> -
> +	int rc;
>   

Does rc refer to return code? The other IFS functions like above use the 
commonly used 'ret' variable. Any specific reason for the inconsistency?

Also, patch 11 completely removes the reload_store() function. Should we 
avoid a separate patch to fix something that is going to be removed 
soon? Would re-ordering the patches help in that regard?

>   	if (kstrtobool(buf, &res))
>   		return -EINVAL;
> @@ -106,11 +105,11 @@ static ssize_t reload_store(struct device *dev,
>   	if (down_interruptible(&ifs_sem))
>   		return -EINTR;
>   
> -	ifs_load_firmware(dev);
> +	rc = ifs_load_firmware(dev);
>   
>   	up(&ifs_sem);
>   
> -	return ifsd->loaded ? count : -ENODEV;
> +	return (rc == 0) ? count : rc;
>   }
>   
>   static DEVICE_ATTR_WO(reload);


Sohil