Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <238b55b0-7fe6-4923-ef8c-fb1cc1cd1c66@intel.com>
Date:   Mon, 24 Oct 2022 15:57:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 03/14] platform/x86/intel/ifs: return a more appropriate
 Error code
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-4-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-4-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUxwVld6RHByRlhUcTFZVHdVbExteUxYVjBRbHRHaGdIU25OblRlQmN2RkVs?=
 =?utf-8?B?dG05M1NZTFRNKzFXR1dLQ25uYjhWcnZRNGFMMU9GOTVxLzFTVlBiNjRRdEFH?=
 =?utf-8?B?WFordGZDdjFRYy9yQjczeHRmMVZjMnVhUzNkTHBJUW5OR1M0ZDY3UjdQRXlS?=
 =?utf-8?B?ZHJaanV0ZGk0azZzYVhtdHdISWdtZVBHdjM3QzhwV04xVEIxdE9BQjBHdmdi?=
 =?utf-8?B?andndE9Kakp1T3ErTEQrRnRvdGpnRURHWHhTNStUblk1QnY4SUxFdXRKVVFv?=
 =?utf-8?B?SWFLRzBZUXNiUnpRQjEwM0g3b3FMUFl0RnhsN3pFM0drTmN2SWdUQ1dWQW9o?=
 =?utf-8?B?NnVySXNib0owZllablNFTDV2dTNBTjZoaDV0Y3NGTVdXL1N3ejVKRzczVmg5?=
 =?utf-8?B?OXhPcHRaY01wdE5aMVFSRWp3UUkrZFJhVVJvMnN5WjBoY0U0YnNwbkNyVmxL?=
 =?utf-8?B?RCtxYUdKR0VWR2s0Tk5DbDVXVERoSUlQMlNmK1VwWnFOb3NtQkh3N2hOMUtL?=
 =?utf-8?B?aVhOSVNvR2FTdnUrQVlKMXQ4M2lWWXpNTVIvdk1rSVAwL0xxWENBdzNQRkNa?=
 =?utf-8?B?ZzhaZjQxc0YxY1JoUlBkNkhEeE90UDBjdHB1TDcxTlZmaHhyTXBRMFBJTzB1?=
 =?utf-8?B?eDd6b2ZQbzAxV3FhK3VDMzBoWUNDMnVOS08vK0pVbXNmTWhGZFVzZzdxT3Ji?=
 =?utf-8?B?NUo1c0k0QnVYNXR6a05HaUovK0lnNUN3MzVBRUIzZHlnYlVYak5WZmM4cjlK?=
 =?utf-8?B?a0RKZm9RYW1ScGtRMFNKNTFNUjgvZ24xUmlwQjZCbStKS1BNOUNDRDUyRnJY?=
 =?utf-8?B?QWZjaFUxbzZrWTgyS0dqbEsrTHlMektGMDFFQXF3a1AvajR0SWlVQXZhYUdw?=
 =?utf-8?B?V2dHTDRNRkRVOExKeHNSQk9mSktKbk92bDJpUEFWbDJxOVBuWHVFcDFXUEJh?=
 =?utf-8?B?RTh4L252TEtLM1lqd3hNaTdMTnNqNWNvYUs2bng5Z084dHB0V1Ryam8yeUg5?=
 =?utf-8?B?cE1rYXl0YTlJVWFzR3hOalFVd2lDMzJQVEhtcUl5NmtSVXhCM25jRzJlL1NM?=
 =?utf-8?B?Q0FXR1doYWdWU01BNkc2K3ROVGF0TWpIYStPNElGTTFLL1BKOEJadzhLdXlM?=
 =?utf-8?B?SVFaVVFSOXhhaWJqdWxwdS8rUk5kQ254RHpRdk90eUUvVWc4aFE5RC9qb0I0?=
 =?utf-8?B?a1FZUWR0VHpsNC9ldHpKSGdkNDV2U3o3ay9WZGJYOCs3eElZd0c1S0FLdk44?=
 =?utf-8?B?RUo5MDFUV1Z2bVYySDYzK3RMdGthVUZyeDFobENxbXpOMnRrUVdwU3NRUWw4?=
 =?utf-8?B?VlVVV1EyMWJ1aG9rYTFONW94Y3hMMlI3amx4TzR2LzdETFIwOWMwclR5Wk5v?=
 =?utf-8?B?bTUrUFY0c0xmWDl6VExHZTRKdlJvUkpBallCd29adzFxRVRpUFNYaERlTjZG?=
 =?utf-8?B?M3llMzZDcTJ0VGFkNmFMOVFRdGRlWm55WVlTNW41aVZhT0kwbDNFRjErSzA4?=
 =?utf-8?B?ekFoalRsSWVEYkFrbDBKQmNWWmduVW9uYzJHNFVTWllaUWpONnNFeGpjVGMz?=
 =?utf-8?B?Rk1CWFpWMGRGZjhlT2xhQ1pBUDlyeGdJVndvZHdQaXdFMCtCU0pFZkF0TmRT?=
 =?utf-8?B?VjRXWTZPMkMvRWMrdlNsejdkdEtLcjB5ZVpINElNa3N2eG43MFp4WmlPZkNx?=
 =?utf-8?B?TVRpVStEd3dvTXNaVjNzSXJmaWVlM1RaemU5T3YyRDRGL3ltSFNLZG8zbG5a?=
 =?utf-8?B?UHRjbDN5S1JnL2lseXY3RTR4WXdvQllxWkorTUZkRVhZQ1BPT0tlNFdCR01h?=
 =?utf-8?B?TGtudlA3RkdjcHBUbDVmVUZwRWpDWHRBSFBXTiswYmhVZ3huYlRGRUlrSDJR?=
 =?utf-8?B?ejE3eVQ4am56MUFydXhYY3k1U2MvdjIzbkJweTI4R29oakJBVk5xVnpwV1VP?=
 =?utf-8?B?UjFqR0hJSWlnOUxFNlpLaDNaWWt4d2ZJY09STVJERmVQWFVyQ01vUVJoNGVt?=
 =?utf-8?B?OEoxMTlIUytVY3RKKzJGZldNdnBvTkd1K3lOT0hmN21rZ2hIcEM2WDFqWVN4?=
 =?utf-8?B?cEo4TzdQSHBjaHpDZWxUWml2ekRCREk0MUtQVlJlZFZTWVBFUVhrc2NvQUJx?=
 =?utf-8?Q?P12qRYjm4lMLRANXKagYmqzAp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 49cc6d18-5cd2-42a9-5f35-08dab6131d56
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 22:57:24.0586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Md5Dz8yPWGnZReHiWHD9hicG9OpKcSct+J6vjXyy9+B1HF2eY4qxNU2poWhWJZsJSqQDzqOGvqjTc9DTdmMCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4875
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 1:34 PM, Jithu Joseph wrote:
> scan_chunks_sanity_check() was returning -ENOMEM if it encounters
> an error while copying IFS test image from memory to Secure Memory.
> 

Same as before:

s/was returning/returns

> Return -EIO in this scenario, as it is more appropriate.
> 

Do the first 3 patches need a 'Fixes' tag? Or is the idea here that the 
feature isn't truly enabled so everything before removing the BROKEN tag 
will be considered together?