Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Oct 2022 16:57:24 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Dave Jiang <dave.jiang@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PATCH v2 06/12] cxl/acpi: Extract component registers of
 restricted hosts from RCRB
Message-ID: <63572664e884c_4da329497@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221018132341.76259-1-rrichter@amd.com>
 <20221018132341.76259-7-rrichter@amd.com>
 <63522b53321e1_24ac29467@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <Y1b92DF0c36/QDbo@rric.localdomain>
 <635702a652637_4da32941a@dwillia2-xfh.jf.intel.com.notmuch>
 <635713bd6bc15_4da329434@dwillia2-xfh.jf.intel.com.notmuch>
 <63cd195a-f5d0-b016-d833-b3a9c86ff6ee@intel.com>
 <Y1ckyqeoWQAs6R9B@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y1ckyqeoWQAs6R9B@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yAIVEYufLGrw3O/rmhdu/6Tcjh94IAwuQVF4Ym3p9TlVYOGRDAJOIBCXAma/?=
 =?us-ascii?Q?RLUnpedoT4aCrfF8GGpnfFnXHy3qphnl+KbAKtONlnRCvXwTp1oMty9btn20?=
 =?us-ascii?Q?hz7SM8n3yGHEF/5lt8QKmN6xhgiLydJAyOPNv0C0sML7WdxhfYOsRzsap0Gb?=
 =?us-ascii?Q?TwB0v0vc7k2m5Ie/0wQJK5FTGXeqMQqUTNb0piBYQKL6dH7/HnP91dwxcwsz?=
 =?us-ascii?Q?+d9bs3qPrdqPqAOrTzfEYhIh4hr+kZq2oR/p22IQPEHPMznOIITTu/Cok8pc?=
 =?us-ascii?Q?1JM8wAoR9py0j07x0Rbo1zakfS9j9Q2zFjsBlBQ2XS00GFGSQ393qA3E80Ia?=
 =?us-ascii?Q?fQh5NWhKkW7uhOwn+FJ3PCR9ENamIPAqUYtpiZLwroQV03qmTY2gg1KCp0vO?=
 =?us-ascii?Q?4vPaeLo48+z20UlrdpreVrBIt6DL8565vhV//1zE/1G8RBIc7lc6ISLkvmjE?=
 =?us-ascii?Q?/m5jsj0rH7u7P7ghDldekByytoG0vKEGp3BWzhOYPGgB3OE/PpyAvV7cmspi?=
 =?us-ascii?Q?vuXyWGzoHhbciLZVIPgVnr2zfZBlqnaQ/uUTyQURoau7s8RLq3j+YMVtQahF?=
 =?us-ascii?Q?I+nUnk5FjgGxNpj7AHX3Zf1Jm4K8Gp9nK834g/dlv18kXA+uaqLrRCHWw0zB?=
 =?us-ascii?Q?KwnbjgzHi62kzoEjhyjPOLFCt6HA0nSBt/JavuU6gjOOcY4w1alnvd/fjmhB?=
 =?us-ascii?Q?txBhFxjCwIhMa9SzVae5bQCKeLpANjXPe684GrXYtz4A26SVSFv5a+7E1lfu?=
 =?us-ascii?Q?nVidqo0Q9SzSONDaOwSgWpAwWk9Y/rzUadD0t9M+Bi3g9jarDxByb3mQ5dzI?=
 =?us-ascii?Q?2jHnAeAMEUWEoYcmR7DDG14LMKpn3I1b6O+7up/4lGscqLGTPzYuYEz5o6ii?=
 =?us-ascii?Q?/yxAt3xwg3/FkZ6bWz8CjhwBkitX1l4wSWWKi+WBcHXaeo8+UbspHHkSiBXt?=
 =?us-ascii?Q?jrjlypye2a71el8/8NACRozFCvXoPLAPt7qp/snEBqI2HE0zC89Hoq/j9Akb?=
 =?us-ascii?Q?qVOeI5HZdGacl9kVuYRZRwYkVyx/IKh7Aj5Ktp2YEDcok8pejuzNaI4TZv37?=
 =?us-ascii?Q?cdY5DndInAEEX/iHJbLzRSQy+JuLH57I325ZxHZDrKAzkyWuE/qWAA+F1K8Z?=
 =?us-ascii?Q?sYvDPBM6HTSEzPE+YO3TQH8vVdmVId5DZl9rguS1OkS4DT6+amr5iwKMY3SP?=
 =?us-ascii?Q?NtqzUfRSxp0v9JZEJdAsgzeKvwkDnIylFmbtCJzue4jcV9QiCBc0K3nq7jDB?=
 =?us-ascii?Q?Tc+zS/+m1XWx4Bq0LVLZ1pWdRYjezJMjv7Wrnde7syJSf5WbcXC5zEipsyLP?=
 =?us-ascii?Q?/iQVk7Rmfc5hpxqDPRxPd2QhKRLLzV6v5pMVRslOW6iTbnwNv8Rpusr9FzUH?=
 =?us-ascii?Q?/CxiaMqGXlCno2W4mNA3DF+oZ7WDRIRF0xNi4SVy5OQLiV5Mlo0mcibcXaMV?=
 =?us-ascii?Q?MIW2KXM9t4POwUgjj9oiKT/dy1gXpoCqc3+NyTjObvCzC6v2ECEAo9g8AqEV?=
 =?us-ascii?Q?FEooWtBlf9CNbDabDKAJ8KxA1ttq87TRXGVwi3x9hKDyHomOXbYxMz+U6ApQ?=
 =?us-ascii?Q?LHm+6lr0CUqA6+ufiJps4+QlkcU2tDkXMwVkJcuyt53TnPdyxlZ8irq9PjDV?=
 =?us-ascii?Q?FA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8be8706-c831-4d81-be00-08dab61b819f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 23:57:28.3479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6BOee5xq5K6lVKq8QGxmU7hpRp+LetacPyShypqfP7lLJCj8sUYvCQR70Yml3+nmGnOiPRoawnzcEbM13CrrQnbp4PuqUKURPTyZx1k1Ei0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5035
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> On 24.10.22 16:23:39, Dave Jiang wrote:
> > On 10/24/2022 3:37 PM, Dan Williams wrote:
> >     Dan Williams wrote:
> >         Robert Richter wrote:
> 
> >             Ok, I see where to go here. Could you point me to Dave's postings you
> >             are referring to? I checked linux-cxl and could not find anything
> >             related to RCRB or that changes regs.c.
> > 
> >         He was in the middle of tidying them when you posted your series, but I
> >         think it would not hurt to push them to a git tree so you can grab the
> >         bits and pieces you want.
> > 
> >         Dave?
> > 
> >     Looks like the list delivery is backed up, so I added Dave to the Cc:.
> > 
> >     He pushed:
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/log/?h=cxl-rch
> > 
> >     ...which was his original attempt and:
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/log/?h=cxl-rch-robert
> > 
> >     ...which was an attempt to rebase on top of your bits.
> > 
> >     The common RCRB mapping function is here:
> > 
> >     https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git/commit/?h=cxl-rch-robert&id=5be44cad37972517dae6a79001080ccfbdb67c49
> 
> Thanks for the pointers.
> 
> > 
> >     I think the path forward is to build on that common RCRB code, fix
> >     cxl_acpi to register the pci host bridge device instead of the APCI
> >     device as the dport device, and then rely on a flag to skip over
> >     devm_enumerate_cxl_ports() in favor of just calling cxl_mem_find_port()
> >     directly in the RCIEP / RCH case.
> 
> Yes, we can completely skip devm_enumerate_cxl_ports() now. Though, I
> am not convinced on using the pci host bridge as dport_dev as RCD and
> non-RCD mode will diverge too much then. Looking into details here.

Oh, I disagree with the initial implementation Dave had here. Both cases
should be specifying the bridge device as the dport. That's a fixup that
can go in now even without the RCD support.

As it is the tooling needs to jump through the physical_node attribute
to provide the useful information in cxl list:

# cxl list -BTu -b ACPI.CXL
{
  "bus":"root0",
  "provider":"ACPI.CXL",
  "nr_dports":1,
  "dports":[
    {
      "dport":"ACPI0016:00",
      "alias":"pci0000:34",
      "id":"0x34"
    }
  ]
}

...and I think that should just swap to this in all cases:

# cxl list -BTu -b ACPI.CXL
{
  "bus":"root0",
  "provider":"ACPI.CXL",
  "nr_dports":1,
  "dports":[
    {
      "dport":"pci0000:34",
      "alias":"ACPI0016:00",
      "id":"0x34"
    }
  ]
}