Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Kees Cook <keescook@chromium.org>,
        Nathan Chancellor <nathan@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>
Subject: RE: [PATCH 1/1] kbuild: upgrade the orphan section warning to an
 error if CONFIG_WERROR is set
Thread-Topic: [PATCH 1/1] kbuild: upgrade the orphan section warning to an
 error if CONFIG_WERROR is set
Thread-Index: AQHY5cZutEIhoaA9LUqamYfjnx4Fj64d0OmAgAAA2gCAAGG9gA==
Date:   Mon, 24 Oct 2022 23:23:21 +0000
Message-ID: <BN6PR1101MB2161BDD7309CD8D02B71F444A82E9@BN6PR1101MB2161.namprd11.prod.outlook.com>
References: <20221022030519.9505-1-xin3.li@intel.com>
 <20221022030519.9505-2-xin3.li@intel.com>
 <Y1bLk47I4pyEmJVi@dev-arch.thelio-3990X> <202210241031.4BB6E70FB@keescook>
In-Reply-To: <202210241031.4BB6E70FB@keescook>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5BODzHSva6UudsJm9UgoftwZu8SAtMJgwZsbDxX6sVmu8JLxj+KtsVLwqfdo?=
 =?us-ascii?Q?rTXYyw9yzd5axj6GX17qz99fk0axGoTf1vRuV4h5nw1/epeuXjVccK6OBE3C?=
 =?us-ascii?Q?qA0mGF+NOfP0NC5c4MwhK4+qVBa/OPZO6sUvN1GKsvR7zMhhqSxl6g/b/jqL?=
 =?us-ascii?Q?zv5b7kE88I63QDpp3Mk4L+Yi6g47eNl4qHec6jyqz/xhgAGBP9OQA+0dQcm1?=
 =?us-ascii?Q?WFkERAivyLg2iaF6waMxO7gT9+4Ukf7BgB/wSV51VD6yKJVp6pf1M+El/b9W?=
 =?us-ascii?Q?bI1kyHybVzDtN0mUHwLMfe3yzhze0cLH72swdnDaDFbZeoZ8wXjFtkltnXK1?=
 =?us-ascii?Q?37HDjmToRgoQulGf7DM74u1VMtK60yLNn++C78DG23UT8LNIPS4O4TASxu4P?=
 =?us-ascii?Q?ENlJ1BuB0JggHg4TzNrAI7GtTcD5s6G5f2hn8N/1QEt25W91nhZozb+N9V4C?=
 =?us-ascii?Q?/ruTgLYLQSOriesvIvJ2sEMkeuwWPDUBWdrkUOL3dyu+67U+UD16H3UMPAsQ?=
 =?us-ascii?Q?7f3uCsPnjSkVCJGNWyqs/gwabedh2pUEYwQDYtOMjBD3Vj2AqXOTeaY27PvK?=
 =?us-ascii?Q?tkRLfT3mKVgyoZZgpspDSCaQgX6Mh2PEvqemch5j7gVSAU38zUgD8Yd0CfiL?=
 =?us-ascii?Q?OL6+EW19k2h5cTqyV/P195B2iAXPPqNRsVwYkcrlHzoChURKu/FRtSVqGglD?=
 =?us-ascii?Q?r5keZRbcbG+E0fP7YhRGZslBx+aJs8T8fda+GJpiGr7/V7jRwT7y+zeX/YEg?=
 =?us-ascii?Q?6bQpfqdkXjCrdbNyiMGbjxSgureOatPENNn4Wa0IjjcxDB82QrLkpI/Whz9w?=
 =?us-ascii?Q?umo5qh9qvzRCJFXs3dQ1ugg9HyuRPFQQplXVGFTgqnTsxlKb6IosUfRATRnk?=
 =?us-ascii?Q?SPKYn/GuM8axF0Fybb//EViH/W3auSGxP9OuK6G4Vdxl4LMtCB0kJkVLpNY5?=
 =?us-ascii?Q?Y5VZ2UPMSEud2H2ZqdvZofkfHxrEbK9McjwP62my/IKSgjmOpVZCk1SUFcp5?=
 =?us-ascii?Q?1g75kY/vkeIb+bq1NrInO/IMxRoCR2CbxGR4iGnXbGc9+uq9FrPDNpMOLVg7?=
 =?us-ascii?Q?22Yxo2o1H7mPaU+W3D5tzIlC6OV5fzotItlcxxnaBTLZun+FQ7Rz+GnUe+oG?=
 =?us-ascii?Q?+BzkfZIB4qxpYSDiZjjjRmZumdGwTkogM24o+TkeP/eJaGfoEnZJvelnzQe0?=
 =?us-ascii?Q?nsYO594L/1YKPrTHFrws0aS6MmzfDR1Nk248KLVRMeSPfhhPtChva2J1Y4T/?=
 =?us-ascii?Q?WNvkBuPTPq1T+gjIBqD0W0WQs8rEdZX+GFph3txeJhCCXKDDP2szDvajudFy?=
 =?us-ascii?Q?56pMXPs2Nw6PJla5Cx3HGfbnFWXxocRs3mxF3pg+YthjcLm+NU2mmngmyoEb?=
 =?us-ascii?Q?11Bb/lEPfeB1iHP+8BEZTuOwrniUzdaqFFUb+1WTxzthvofj3bAt5BmVirf+?=
 =?us-ascii?Q?NqKvIrYX7QnWs2ekbByo0dWCiCjpVqxzkHkyx7W+OFNOqO3I+vczP8fv5hFh?=
 =?us-ascii?Q?LWm+QYtxN3A7pxEBgAmsVV49ogNLj3oIXqjCbLUfc1L0OLBcS/GcU/b+GvWR?=
 =?us-ascii?Q?0cX21q7cYuemplbOX60=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2161.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbe835d0-96a8-4804-6cce-08dab616bdd8
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 23:23:21.6490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zgY/KPjZoE6DXsWjEGCxF8H/Y2sR/wnbmTjf2C4gO/EwSjX6EEqmHYPhK5cX9yGGcQE7kPIJxX6h8vrchJ/Bbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6817
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, Oct 24, 2022 at 10:29:55AM -0700, Nathan Chancellor wrote:
> > On Fri, Oct 21, 2022 at 08:05:19PM -0700, Xin Li wrote:
> > > Andrew Cooper suggested upgrading the orphan section warning to a
> > > hard link error. However Nathan Chancellor said outright turning the
> > > warning into an error with no escape hatch might be too aggressive,
> > > as we have had these warnings triggered by new compiler generated
> > > sections, and suggested turning orphan sections into an error only
> > > if CONFIG_WERROR is set. Kees Cook echoed and emphasized that the
> > > mandate from Linus is that we should avoid breaking builds. It wrecks
> bisection, it causes problems across compiler versions, etc.
> > >
> > > Thus upgrade the orphan section warning to a hard link error only if
> > > CONFIG_WERROR is set.
> > >
> > > Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > > Suggested-by: Nathan Chancellor <nathan@kernel.org>
> > > Signed-off-by: Xin Li <xin3.li@intel.com>
> >
> > Thanks for the patch!
> >
> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> > Tested-by: Nathan Chancellor <nathan@kernel.org>
> >
> > We could deduplicate the '$(if $(CONFIG_WERROR),error,warn)' logic if
> > we hoisted it into Kconfig by having something like
> >
> >     config LD_ORPHAN_WARN_LEVEL
> >         string
> >         depends on LD_ORPHAN_WARN
> >         default "error" if WERROR
> >         default "warn"
> >
> > in init/Kconfig then using it everywhere like
> >
> >     --orphan-handling=3D$(CONFIG_LD_ORPHAN_WARN_LEVEL)
> >
> > but I will let others decide if they would prefer that over the
> > direction we went here.
>=20
> I think this makes it look cleaner, yeah.

Agree this looks much cleaner.

>=20
> --
> Kees Cook