Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 03:29:24 +0300
From:   Vadym Kochan <vadym.kochan@plvision.eu>
Subject: Re: [PATCH v3 1/2] dt-bindings: mtd: marvell-nand: Convert to YAML DT
 scheme
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc:     Elad Nachman <enachman@marvell.com>,
        Chris Packham <chris.packham@alliedtelesis.co.nz>
In-Reply-To: <ae7c86fd-5bc9-4cdb-857c-e686225f5966@linaro.org>
References: <20221024210153.28852-1-vadym.kochan@plvision.eu>
        <20221024210153.28852-2-vadym.kochan@plvision.eu>
        <ae7c86fd-5bc9-4cdb-857c-e686225f5966@linaro.org>
Content-Type: text/plain
Message-ID: <VI1P190MB03170C4FC92ED25F78EF57FC95319@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nJN0LVYnhpbBtAmqW+eALDOkUX0QvEVq7E++cmyKKfIWXuPtWdtYAPZ4TDV1?=
 =?us-ascii?Q?IobpFOeW5R/FxmjTCWzoue3PhBfMU7bthV4AE4W+CLPZiNnkhIkEVnPsavPy?=
 =?us-ascii?Q?8YRnNEFx1IHZjJQgTgDf68EmhU+6nxHWZpAeS1LR1Lb9o2JBddVp0yJC8Unz?=
 =?us-ascii?Q?c1punLIFXsMfF6fdbqWCSbDAvocMsZevox4P6MKPiKgux4Wmf1bFOAVXz4QK?=
 =?us-ascii?Q?9GWblt96V4f7h1JNJkp2yJKiGXjbpdR1b9i2VJ1llkk2AMNNHKTpw80ds0c/?=
 =?us-ascii?Q?0ZRuppdPfMv53A0m0KmvSTU3RmnN3gErlv4BBQRNSHcwzs8zA0FW2D9i0BD0?=
 =?us-ascii?Q?5UEHkinLRFbfz54ObH0LmZR8x9R0j64dEmS1qVKscHyNRMN/CtOLr3FU2g32?=
 =?us-ascii?Q?tDumxXEKa1PE31n0Bhmw9VzYboWKhFpE+QKMb4vG2NSK45jr3uSIaW/sF3q8?=
 =?us-ascii?Q?zuhqLrDssXT5svy76UpJ/AjwC8TwR+Oo8VspcPzfjIMOwyu5ScwYPBpjFDfU?=
 =?us-ascii?Q?p6/+JY626Bho5NL+1MGMobueY8W0F/Abcz7cmDoD6E9pJbvnsdCqBOvVVdfz?=
 =?us-ascii?Q?XthXFQEQhCHcXFWpvlvl5iaXsC9Sh6Mnnh0xvmZv9xv/IxrCXUp4lhOAUJFr?=
 =?us-ascii?Q?QnJRInVda3O1g8V7bU7NernpptfpPUYyhZ3+/zgqLCfoPFxHRLipNjAG63rx?=
 =?us-ascii?Q?4J7M8RGpZ3KZZ0KbHcYbG3mbRdYuE9t85Re6R/0bZHgUSvAWuHqygVmKF7Kl?=
 =?us-ascii?Q?cda1/lBJxSdcJiWF/L5g79HePzQu77w8MugMA9X3Cmxy1DYyazxvtwr1ib6F?=
 =?us-ascii?Q?FUhtuLyPcv9SEKfy6qt+ujHFKIKyJcX0OgTv4MG3C74lAZ08f4ANzMCRQWI1?=
 =?us-ascii?Q?0DMw+ihlPqBWoOx6w+XRVVUTnjtiYZ9hiULCVF9+A/9nM708WqskmQ33Oe/M?=
 =?us-ascii?Q?iJThOpy8L0QGtQUsgTSkjss063c7No44QynKmcdGPR8aP1R343aEvcQwUyqJ?=
 =?us-ascii?Q?/NoHRLBhU15jDJnS9itEgThBN8fe2HkkQWo7JQSYxNezVDzKRDcQivOocmb+?=
 =?us-ascii?Q?mdqe9b1P+N+tFg2iDUC0ypNVIfqOZikcSJpPI9J9EJcCf2pV/8anTgbFfmYu?=
 =?us-ascii?Q?riuJIuB+enKpP2TJdlxcMhp+5x80Y8BRP77bT+tHIrnBqJCBS/V+ApgNHn3z?=
 =?us-ascii?Q?4llObNehH3eGucNOtB6/Aws26mS2RfaVkBECKH/ylChiCyir3b/rwdTW4uYL?=
 =?us-ascii?Q?bPg+rKlwxUtEczPYKfv7cyEafbPos3b01ejU+NFDOlSwDOAgq7aF13tH+cVS?=
 =?us-ascii?Q?hcPLfUkpIHXHwwRBMzzHXsUrYzSf4XQ0dvCK/6Cywvz6N7yyPk8nYkazne4t?=
 =?us-ascii?Q?AadklAFKwxgSRhKTjLjHPgrJggNC+zFVxzE9WpCNMs/EBdHyxubvIqTohjiJ?=
 =?us-ascii?Q?xWOXCnLyYyPYr22OPL/SYJunPvpoWUt+C2FIo5YajlpkyiMhljMAoGju6PwC?=
 =?us-ascii?Q?MITi80TfjcGC0zgEXzeUbH5zhSWcpBstCFwAc47JMChUYLMnXQSGspeXxuwL?=
 =?us-ascii?Q?P8Fg0rHdILHWzufAGTSu1M8gFpRb9IU2W+xyKigLkUcoNTg4Y6jnkv7WgWl2?=
 =?us-ascii?Q?ag=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 85dec9b5-77d0-4581-fc2a-08dab61ff827
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0317.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 00:29:25.1676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gnV4+L2gZzkCRH4SvZu6I8/pzl3N5I0BJwZIJ90pP1RFZWoNNYASX328SIfb9LQaotPcY1tThg2MFXC4zmmsM5Rux7UPNYOVCnNMvM2/Hsk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP190MB1765
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

On Mon, 24 Oct 2022 17:31:48 -0400, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 24/10/2022 17:01, Vadym Kochan wrote:
> > Switch the DT binding to a YAML schema to enable the DT validation.
> > 
> > Dropped deprecated compatibles and properties described in txt file.
> > 
> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>
> > ---
> > 
> > v3:
> >   1) Remove txt version from the MAINTAINERS list
> > 
> >   2) Use enum for some of compatible strings
> > 
> >   3) Drop:
> >         #address-cells
> >         #size-cells:
> > 
> >      as they are inherited from the nand-controller.yaml
> > 
> >   4) Add restriction to use 2 clocks for A8K SoC
> > 
> >   5) Dropped description for clock-names and extend it with 
> >      minItems: 1
> > 
> >   6) Drop description for "dmas"
> > 
> >   7) Use "unevalautedProperties: false"
> 
> Hmm... In one place it makes sense. In "nand@" not really.
> 
> > 
> >   8) Drop quites from yaml refs.
> > 
> >   9) Use 4-space indentation for the example section
> > 
> > v2:
> >   1) Fixed warning by yamllint with incorrect indentation for compatible list
> > 
> >  .../bindings/mtd/marvell,nand-controller.yaml | 189 ++++++++++++++++++
> >  .../devicetree/bindings/mtd/marvell-nand.txt  | 126 ------------
> >  MAINTAINERS                                   |   1 -
> >  3 files changed, 189 insertions(+), 127 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/mtd/marvell-nand.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> > new file mode 100644
> > index 000000000000..cb20f14d4aea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> > @@ -0,0 +1,189 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell NAND Flash Controller (NFC)
> > +
> > +maintainers:
> > +  - Miquel Raynal <miquel.raynal@bootlin.com>
> > +
> > +

[...]

> > +      nand-ecc-step-size:
> > +        description: |
> > +          Marvell's NAND flash controller does use fixed strength
> > +          (1-bit for Hamming, 16-bit for BCH), so the actual step size
> > +          will shrink or grow in order to fit the required strength.
> > +          Step sizes are not completely random for all and follow certain
> > +          patterns described in AN-379, "Marvell SoC NFC ECC".
> > +
> > +      label:
> > +        $ref: /schemas/types.yaml#/definitions/string
> > +
> > +      partitions:
> > +        type: object
> > +        $ref: /schemas/mtd/partitions/partition.yaml
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
> 
> Thank you.
> 

I see that I have to drop "label" and "partitions" properties.

> > +
> > +      marvell,nand-keep-config:
> > +        description: |
> > +          Orders the driver not to take the timings from the core and
> > +          leaving them completely untouched. Bootloader timings will then
> > +          be used.
> > +        $ref: /schemas/types.yaml#/definitions/flag
> > +
> > +      marvell,nand-enable-arbiter:
> > +        description: |
> > +          To enable the arbiter, all boards blindly used it,
> > +          this bit was set by the bootloader for many boards and even if
> > +          it is marked reserved in several datasheets, it might be needed to set
> > +          it (otherwise it is harmless) so whether or not this property is set,
> > +          the bit is selected by the driver.
> > +        $ref: /schemas/types.yaml#/definitions/flag
> > +        deprecated: true
> > +
> > +    unevaluatedProperties: false
> 
> This looks wrong. I do not see referencing schema here and I did not ask
> to change it.

Yes, I will drop it.

> 
> > +
> > +    required:
> > +      - reg
> > +      - nand-rb
> > +
> > +unevaluatedProperties: false
> 
> This one is ok.
> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +
> > +allOf:
> > +  - $ref: nand-controller.yaml#
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: marvell,pxa3xx-nand-controller
> > +    then:
> > +      required:
> > +        - dmas
> > +        - dma-names
> > +    else:
> > +      properties:
> > +        dmas: false
> > +        dma-names: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: marvell,armada-8k-nand-controller
> > +    then:
> > +      required:
> > +        - marvell,system-controller
> > +      properties:
> > +        clocks:
> > +          minItems: 2
> 
> Also for clock-names "minItems: 2"
> 
> > +    else:
> > +      properties:
> > +        marvell,system-controller: false
> 
>     clocks:
>       maxItems: 1
> 

OK, so it goes under the "else".

> and the same for clock-names... unless these variants also have two clocks?
> 
> 
> Best regards,
> Krzysztof
> 

Thank you,
Vadym