Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 08:19:34 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 0/4] Add tbench/gitsource new test cases for
 amd-pstate-ut
Message-ID: <Y1crluIArwEksyIp@amd.com>
References: <20221024013356.1639489-1-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221024013356.1639489-1-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X8Vg9DSd7hMbe1LwV0B619BWZONrRuMHTSXG7bBE8+yiSH301ALQ+QbqJ5oF?=
 =?us-ascii?Q?IBlUNGQgwuQQIxQVY8vJu3m3HotTCfScx8bMRnwmp5FzaWgJizsJmi4W4Z+K?=
 =?us-ascii?Q?qMXmJVgMYZHzhxR/4cEFFpfT1JL892abtwLWtTosePIbM6gYn9CrVXT+796F?=
 =?us-ascii?Q?/tXymkgB76ILbDJhg7OhNFtC2jvGdGzTNYpMSvOxSnFjhwiorKIh8eoEq40M?=
 =?us-ascii?Q?434XaeDQjqlKPK20V6eafvTPM5oI28XrtvUhfo85fBg3MSw2HvFOC0QiuWq4?=
 =?us-ascii?Q?g9b7CyStjF3MHx9Y5nzqxvjIMiF+K+Mh2G+5Qx/PUOZ1x5jVsfNiiaTPjJWR?=
 =?us-ascii?Q?Rm4eKwq8V1/4ZIEqbAwDRxIp9p++o/r6RU0dbagYpCQWFHrCSXM4lvtTuuOV?=
 =?us-ascii?Q?OTmivejwl6u0o4ceyv69HNbAgV9rKKYLW5gj7StG0zkwHgldzUpnB0UrNUJX?=
 =?us-ascii?Q?7q55p7V9scxRCKyYO0tlnk+NXFhdVwSrdsL5XBNakxDnz0JRh1KTUWG7BePK?=
 =?us-ascii?Q?8i4Ej1Q027kiSNSp1CNa6pnD7390o4nYnpxz812AEMsy8qmtp0bwgXUubeM7?=
 =?us-ascii?Q?L+WxbwpETJlYj8u0dINegDDje8n1xRqxcRs5ibeT6lW0O07KBaBMK6iVWOKX?=
 =?us-ascii?Q?xKhg136j/qKpWjkw5DLOVlIEEFLyvKIjOHPIoOD7Xdivem2FzQwJJucAeYWY?=
 =?us-ascii?Q?6CCcR4Cqe7VRu0MFFSDowF+Adk6kiYL9IfNbgTmMH0Id6aF8Tl66k9bybEc7?=
 =?us-ascii?Q?Fb7IdBlwu/E3qDCXlerlJQS9jcua6Lek0B/0OFoAtz0kLgbx8P3hhBuDbYYd?=
 =?us-ascii?Q?malIX2rSFeUP8T3pqoALX3w38Xy5+K7XER3Wa4RRvagiS9Mp82zAhYTtG+r1?=
 =?us-ascii?Q?6Mo/HwenTSPLsAG0GmTjKLZtRehB4m9QvYYwrZZDrgBkKmq229fIBSpcPrv1?=
 =?us-ascii?Q?G+i3eeaonAXgWF49aFweHFxEn1/2RHy0mQ8Ai0sudCHF/RkHl7UqDIjQ9VuB?=
 =?us-ascii?Q?BVLm/hw3qLU3zdxUPgNApOyFPRxwrtXTGVR4m0AAutwo91oYbgP6vI3CFrVe?=
 =?us-ascii?Q?O+ug/BAYoTH+XuuknDldfZ4HnnFhBCP+OfSOAVMvaH5f7a7eiUAkjXtQazPe?=
 =?us-ascii?Q?peUvUo7hisyGdl30NIt+t4YgyliwfDhMGedh5DoeiKCqxF0+dhOV7ZKSn34C?=
 =?us-ascii?Q?3FbbqiONCBW9GAtc9cFSKHGmlRni6u1skmopMBI0cuUnPn1fBsbGyna1zdp/?=
 =?us-ascii?Q?zbNZdbzAn1QTsdrXxqde38O145bVRMfw9dQZPVzedXXWIoRyP2FOnXexS5tr?=
 =?us-ascii?Q?cRtBv18pfTwvzVKU72StwCFXs+4B/xjDiw2zSXdHAjPmJsHHqDKX2erVbgVa?=
 =?us-ascii?Q?hDjU52BVOxFisWS1KZpeKVUEARPyW8oST0+7W4S0hwATfMWMuylxqukBLlYy?=
 =?us-ascii?Q?rRY9/SBvVK3Hyl1QwxhiFgiSvGTV9tJ/24E6bewMfYKLMtnL23A9QY8vBGZd?=
 =?us-ascii?Q?aYHPXXDf5pTYeZ93ARAiLuRZ6ioFIDj2NiItYqvXydszumOjyoBXfQm+lpk+?=
 =?us-ascii?Q?L1mWbmHhhTIsqZRxSTEWqEPBk73qn2HJiZe9K60a?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 010880d6-56d4-4089-d97f-08dab61ea56e
X-MS-Exchange-CrossTenant-AuthSource: MW2PR12MB2506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 00:19:57.0094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QCUbrPOJ9QwpV8ySyfQ3Vx4sGyLd9p5eEsrTHbnRHBE1JjEdc/6oWmixmqJO8f8DjprAWAcManyaiNH3llbfwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4431
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 09:33:52AM +0800, Meng, Li (Jassmine) wrote:
> Hi all:
> 
> First, we modify amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> AMD P-State kernel drivers. The purpose of this modification is to
> facilitate the subsequent addition of gitsource, tbench and other tests.
> You can test specific functions by specifying test cases.
> Default test all cases, include basic, tbench and gitsource etc.
> 
> Secondly, add tbench.sh trigger the tbench testing and monitor the cpu
> 
> Third, add gitsource.sh trigger the gitsource testing and monitor the cpu
> information.
> 
> Finally, modify rst document to introduce test steps and results etc.
> 

Series look good for me right now, thanks!
Next time, please send them to linux-kselftest@vger.kernel.org as well.

Acked-by: Huang Rui <ray.huang@amd.com>

Shuah, could you please take a look at these series?

Thanks,
Ray

> See patch series in below git repo:
> V1:https://lore.kernel.org/lkml/20220706073622.672135-1-li.meng@amd.com/
> V2:https://lore.kernel.org/lkml/20220804054414.1510764-1-li.meng@amd.com/
> V3:https://lore.kernel.org/lkml/20220914061105.1982477-1-li.meng@amd.com/
> 
> Changes from V1->V2:
> - selftests: amd-pstate: basic
> - - delete main.sh and merge funtions into run.sh
> - selftests: amd-pstate: tbench
> - - modify ppw to performance per watt for tbench.
> - - add comments for performance per watt for tbench.
> - - add comparative test on acpi-cpufreq for tbench.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for tbench.
> - selftests: amd-pstate: gitsource
> - - modify ppw to performance per watt for gitsource.
> - - add comments for performance per watt for gitsource.
> - - add comparative test on acpi-cpufreq for gitsource.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for gitsource.
> - Documentation: amd-pstate:
> - - modify rst doc, introduce comparative test etc.
> 
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - reduce print logs for governor.
> - - add a check to see if tbench and the perf tools are already installed.
> - - install tbench package from apt or yum.
> - - correct spelling errors from comprison to comparison.
> 
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - modify cover letter and commit logs.
> - Documentation: amd-pstate:
> - - modify some format questions.
> 
> Thanks, 
> Jasmine 
> 
> Meng Li (4):
>   selftests: amd-pstate: Modify amd-pstate-ut.sh to basic.sh.
>   selftests: amd-pstate: Trigger tbench benchmark and test cpus
>   selftests: amd-pstate: Trigger gitsource benchmark and test cpus
>   Documentation: amd-pstate: Add tbench and gitsource test introduction
> 
>  Documentation/admin-guide/pm/amd-pstate.rst   | 194 ++++++++-
>  tools/testing/selftests/amd-pstate/Makefile   |  11 +-
>  .../selftests/amd-pstate/amd-pstate-ut.sh     |  56 ---
>  tools/testing/selftests/amd-pstate/basic.sh   |  38 ++
>  .../testing/selftests/amd-pstate/gitsource.sh | 345 ++++++++++++++++
>  tools/testing/selftests/amd-pstate/run.sh     | 387 ++++++++++++++++++
>  tools/testing/selftests/amd-pstate/tbench.sh  | 334 +++++++++++++++
>  7 files changed, 1288 insertions(+), 77 deletions(-)
>  delete mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/basic.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/gitsource.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/run.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/tbench.sh
> 
> -- 
> 2.34.1
>