Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1666320059-17544-1-git-send-email-u0084500@gmail.com>
 <1666320059-17544-2-git-send-email-u0084500@gmail.com> <20221024164251.GA1890861-robh@kernel.org>
In-Reply-To: <20221024164251.GA1890861-robh@kernel.org>
From:   ChiYuan Huang <u0084500@gmail.com>
Date:   Tue, 25 Oct 2022 08:30:40 +0800
Message-ID: <CADiBU3_WUeyYdnmnG0Ff2pH+b3u1zOtP1z44LcA53Ba5c9nrEw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Add bindings for Richtek
 RT6190 regulator
To:     Rob Herring <robh@kernel.org>
Cc:     krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
        lgirdwood@gmail.com, cy_huang@richtek.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Rob Herring <robh@kernel.org> =E6=96=BC 2022=E5=B9=B410=E6=9C=8825=E6=97=A5=
 =E9=80=B1=E4=BA=8C =E5=87=8C=E6=99=A812:42=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Fri, Oct 21, 2022 at 10:40:58AM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add devicetree binding for Richtek RT6190 4-Switch buckboost controller=
.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > Since v2:
> > - Rename binding filename to 'richtek,rt6190.yaml'
> >
> > ---
> >  .../bindings/regulator/richtek,rt6190.yaml         | 77 ++++++++++++++=
++++++++
> >  1 file changed, 77 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/regulator/richtek=
,rt6190.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rt6190=
.yaml b/Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
> > new file mode 100644
> > index 00000000..dced404
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
> > @@ -0,0 +1,77 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/richtek,rt6190.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Richtek RT6190 4-Switch BuckBoost controller
> > +
> > +maintainers:
> > +  - ChiYuan Huang <cy_huang@richtek.com>
> > +
> > +description: |
> > +  The RT6190 is 4-Switch BuckBoost controller designed for converting =
input
> > +  voltage to output voltage that can be equal to, higher or lower than=
 input
> > +  voltage. It operates with wide input voltage range from 4.5V to 36V,=
 and
> > +  the output voltage can be set from 3V to 36V by external FB pin. It'=
s commonly
> > +  used for the application like as BuckBoost bus upply, docking statio=
n and USB
>
> typo: upply
>
> > +  power delivery product.
> > +
> > +  Datasheet is available at
> > +  https://www.richtek.com/assets/product_file/RT6190/DS6190-02.pdf
> > +
> > +allOf:
> > +  - $ref: regulator.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - richtek,rt6190
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  enable-gpios: true
>
>        maxItems: 1
>
It's coming from gpio-consumer-common.yaml.
If so, does it still need to declare the 'maxItems'?
> > +
> > +  wakeup-source: true
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  regulator-allowed-modes:
> > +    description: |
> > +      buck allowed operating mode
> > +        0: PSM mode (light load Power Saving Mode)
> > +        1: FCCM mode (Forced-CCM mode)
>
>        maxItems: 2
>
> > +    items:
> > +      enum: [0, 1]
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    i2c {
> > +      #address-cells =3D <1>;
> > +      #size-cells =3D <0>;
> > +
> > +      regulator@2c {
> > +        compatible =3D "richtek,rt6190";
> > +        reg =3D <0x2c>;
> > +        wakeup-source;
> > +        interrupts-extended =3D <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> > +        enable-gpios =3D <&gpio26 1 GPIO_ACTIVE_HIGH>;
> > +        regulator-name =3D "richtek,rt6190-buckboost";
> > +        regulator-min-microvolt =3D <3000000>;
> > +        regulator-max-microvolt =3D <32000000>;
> > +        regulator-min-microamp =3D <306000>;
> > +        regulator-max-microamp =3D <12114000>;
> > +        regulator-allowed-modes =3D <0 1>;
> > +      };
> > +    };
> > --
> > 2.7.4
> >
> >