Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec2a2799-9db5-8810-7a41-f9f6ca1b360b@intel.com>
Date:   Mon, 24 Oct 2022 16:50:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 04/14] platform/x86/intel/ifs: Remove image loading during
 init
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <markgross@kernel.org>,
        <hdegoede@redhat.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-5-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-5-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWdjdW1YOVk4Y0g4L25QRXg2RzdXdi9MMFRZb3FUUUExTERIQ1pubU9pOXlo?=
 =?utf-8?B?NkRPMUd2SmV3NnVXUnZMeVJLMExqUWpBOHkvUXNWRjhSUXlqNThNL0VnY25D?=
 =?utf-8?B?NDYrYmdOMDdWVTlVRUlwVVBRVXRyTDBFTzlXcTFOVGNYMUhSaDJsNFQ1ajRn?=
 =?utf-8?B?WHhTWE1EVE1pOW5ZTWFFNEJqeEFkTW5yZWsvbElUaFpHUklyOTNEakNENE4y?=
 =?utf-8?B?WEdNSzhZNHdlUHp0Y1B0eGVRTnU1eVZ2VGloTVdQWlFpZzhheDVNK09maFFB?=
 =?utf-8?B?T2ZCcDRIVDVqOGVHYi93RTVBdE9hZnJBK1ZUTVppOENnU0lNbUVtMVhUcC8w?=
 =?utf-8?B?cGtmK1BWSG9CQWo1K3I2cGJuUGwwemZLMnZ4cEZhbmxvb0VCQjFGYnc0RzUr?=
 =?utf-8?B?NC9lR3lNVHIwM1dYUkR2Tzhsc1VLNFEzT0NpZHRabjd1WklpaUV6eGJCL3p4?=
 =?utf-8?B?WDExSTJYMk5IQ1JHdlZmV3liWldrYTE1QXRoZDV1SXV6NVhncjJlT0d1Zjdz?=
 =?utf-8?B?RGxoN0JzdmR0M0xDOStudHBDQjZ5UXZUTDgyTExBRHVKWmNpUXNvU2VwQ1Zv?=
 =?utf-8?B?VmYyMUp4aEErKzdtVTZxeVRWZEdvamFRa3NpZlU5dkZ2Um1hd0tqbXJiSyth?=
 =?utf-8?B?Nkg5bXJZNWZYejNONisxNjByZVV2U0xGQmRMcDhsVnNVK1pMQUNuWmROOURk?=
 =?utf-8?B?NGFsWmIvaGxpN2J4Z1RFRVF4cThJR1FUbWhsMGwyck5wS2t5c0xhRlFhYmtB?=
 =?utf-8?B?cHN6QjcrYmxFQmtSSDl3MjkzekZvOFhFZ3AyRkM3MDhvSTRnU292amgwaldT?=
 =?utf-8?B?Q21qZDFCdnIwcDgyWkxzY3VuaVZZZVRlZXVSNjExVS9lbTkyREk4d0pVeTVC?=
 =?utf-8?B?UTFrclh1NlB6YzE1TUZnZXpEVFk5akdJTVFRZXZaRjczSEIrNDJQTTV1allw?=
 =?utf-8?B?MXZIY1Q3WFFtaVUzMCt1dGZnbHoxT1BCL05keEphd0pWZERzbEdUclZVSmF6?=
 =?utf-8?B?SkN5cHZRbmlFbGk5bUZ4NmhUb2NWNUJzbG5paEU4MjFsbUdNUkxpSXNOT1VO?=
 =?utf-8?B?cjVTMFpwc0Z0akxLTU91dnVHcE9XdFNsRldFYzF5QmRRVzEzTWo0LzhrUGdx?=
 =?utf-8?B?YjZabHhuQjRpTzBhdUFsak90c1hhems3d29YTU5na1pPZ0ttRGt6NHV4QnJ1?=
 =?utf-8?B?SXIwK1Z3dEtoRzJqekpXMXU5TzhoUEVlTEQvVmthNUpVWkFwVHU1TmJ0OEVh?=
 =?utf-8?B?TmpBMUJEU0VLZ0lwSHRObG9mL2NScDdrWCtwbzJmTzM1Z01aRi9mMnRFN3d2?=
 =?utf-8?B?OGhMeVBKSFp3TklkTXBFVDFoaFFxbkdzRFozMzYrSGNsZmgySFh1bURITDc3?=
 =?utf-8?B?NzZoVDMweEtCSzFkNkFwMFEzaENmRUlOZElad0ZiL2pUcXlhelZwZW8yUGhI?=
 =?utf-8?B?eVJXQUlsdTA1WG9ZV3FOKzczUDhiQjVEMzlYbnI1Y3pxbzBDNGpoK2tqaVdE?=
 =?utf-8?B?RW1PU1BsS1Y1WW9KZUtsZlZtQXZYMEp4c2hHb3RzZXZHRFExclUvNktGc2gw?=
 =?utf-8?B?cDcxdHpkUTJSR1pFdmc4dkxHRUZYTTk0bktNWFhQVzNpNVBTclRQYUZNc0dt?=
 =?utf-8?B?NlVZQXdTUmZZTEZYaGY1T01Sb3NtcEJLTHJJSGZBYytyRHRtZGh2VVl5QVN5?=
 =?utf-8?B?KzdyeXI2cUplR0pYN3doQXVjaU0xbVVIZDl1WFdkaU1LeWh0bXgzckp2TktG?=
 =?utf-8?B?bTZDUzRoU3NaZFJCcXdDWVJYU3V5RWh5YTkwa1Bsd21ZNU1tUE9ILzRTNHJM?=
 =?utf-8?B?WXBCcWhiY0YvVkY5SGZvaHkyWGh1MnR5QmI2d3o2M2JHMGhJSVpFWlk0SEFS?=
 =?utf-8?B?WGhITVVLdmJFaDIwQUJtV2txY0NKblJQZitSenJIN25uOS9kQ29WNkdvT3pq?=
 =?utf-8?B?NGVCcmhmM2wyQXRNclVoSldZMk5BSUxLT0ZPTmQ0UmU4TURQY1BiMUJBRU1s?=
 =?utf-8?B?M3liN0dpbHlYanJFdEl0U1BQNkRlNTE5dVozcXo1QWwvOWFNZko1M295Q3JR?=
 =?utf-8?B?dEN5NWVXZWpTMThleGFBa01RZmgvSlBMTlhRTHVodEpBaTA5WGlodDZiT2pN?=
 =?utf-8?Q?Eozq8tShfZkePBZLkZw0Ouz5U?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bce869ee-3a1c-49bc-ee93-08dab61a8b71
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 23:50:35.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w9Zu+wlcqDY8ZThRX2+Pbnz4F0nL3KMImn7lHNMIqFphxIuXXn42MNc9ajzaZTbJMempfGu+0HbNSBNN6kBQHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6605
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 1:34 PM, Jithu Joseph wrote:
> Existing implementation loads IFS test image during the driver
> init flow.
> 
> Dropping test image loading from the init path improves
> module load time.
> 
> Prior to starting IFS tests, the user has to load one of
> the IFS test images by writing to the current_batch sysfs file.
> 

The kernel is still unaware of the 'current_batch' sysfs file. It will 
be introduced in patch 12. You can avoid the reference here.

> Removing IFS test image  loading during init also allows us to
> make ifs_sem static as it is used only within sysfs.c.
> 

Does something like this sound better?

IFS test image is unnecessarily loaded during driver initialization. The 
user has to load one when starting the tests.

Drop image loading during ifs_init() and improve module load time. As a 
consequence, make ifs_sem static as it is only used within sysfs.c

> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
> index 27204e3d674d..5fb7f655c291 100644
> --- a/drivers/platform/x86/intel/ifs/core.c
> +++ b/drivers/platform/x86/intel/ifs/core.c
> @@ -51,12 +51,8 @@ static int __init ifs_init(void)
>   	ifs_device.misc.groups = ifs_get_groups();
>   
>   	if ((msrval & BIT(ifs_device.data.integrity_cap_bit)) &&

Is there a reason to store the integrity cap constant in the device.data 
global structure?

.data = {
	.integrity_cap_bit = MSR_INTEGRITY_CAPS_PERIODIC_BIST_BIT,
},

IIUC, you are basically reading an MSR and testing a bit within? You 
already have an BIT macro (unused) for that.

#define MSR_INTEGRITY_CAPS_PERIODIC_BIST 
BIT(MSR_INTEGRITY_CAPS_PERIODIC_BIST_BIT)


> -	    !misc_register(&ifs_device.misc)) {
> -		down(&ifs_sem);
> -		ifs_load_firmware(ifs_device.misc.this_device);
> -		up(&ifs_sem);
> +	    !misc_register(&ifs_device.misc))
>   		return 0;
> -	}
>   
>   	return -ENODEV;
>   }

Sohil