Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75b4faa2-d1af-17ee-6a2c-a39b59adca6c@gmail.com>
Date:   Tue, 25 Oct 2022 11:19:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/1] ARM: dts: aspeed: bletchley: add aliases for mdio0
 and mdio3
To:     Joel Stanley <joel@jms.id.au>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Patrick Williams <patrick@stwcx.xyz>,
        Potin Lai <potin.lai@quantatw.com>
References: <20221025024145.1561047-1-potin.lai.pt@gmail.com>
 <CACPK8XdpeKVaxFki3GRyo30bWYNF6Q5wL706j5deaqi8P=ssdA@mail.gmail.com>
Content-Language: en-US
From:   Potin Lai <potin.lai.pt@gmail.com>
In-Reply-To: <CACPK8XdpeKVaxFki3GRyo30bWYNF6Q5wL706j5deaqi8P=ssdA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/25/22 11:05, Joel Stanley wrote:
> On Tue, 25 Oct 2022 at 02:43, Potin Lai <potin.lai.pt@gmail.com> wrote:
>> Add aliases for mdio0 and mdio3 so that we can use name to lookup the
>> address of Aspeed SOC.
>>
>> For example:
>> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio0
>> /ahb/mdio@1e650000
>> root@bletchley:~# cat /sys/firmware/devicetree/base/aliases/mdio3
>> /ahb/mdio@1e650018
>>
>> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
>> index c02c15f15465..2825d5f3f78b 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-bletchley.dts
>> @@ -15,6 +15,8 @@ / {
>>
>>         aliases {
>>                 serial4 = &uart5;
>> +               mdio0 = &mdio0;
>> +               mdio3 = &mdio3;
> Should this go into the dtsi instead?
Thanks for suggestion, I will move this to aspeed-g6.dtsi in next version.
>>         };
>>
>>         chosen {
>> --
>> 2.31.1
>>