Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Maxime Ripard <mripard@kernel.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        Hans Verkuil <hverkuil@xs4all.nl>
Cc:     linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH v1] media: cedrus: Propagate error code from cedrus_h265_skip_bits()
Date:   Tue, 25 Oct 2022 06:59:01 +0200
Message-ID: <12078224.O9o76ZdvQC@jernej-laptop>
In-Reply-To: <d75c0597-2323-27f2-a7e2-b319667bdcf6@xs4all.nl>
References: <20220914150105.209484-1-dmitry.osipenko@collabora.com> <d75c0597-2323-27f2-a7e2-b319667bdcf6@xs4all.nl>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Hans,

Dne ponedeljek, 24. oktober 2022 ob 13:38:36 CEST je Hans Verkuil napisal(a=
):
> Hi Dmitry,
>=20
> This patch has a conflict with this patch from Jernej:
>=20
> https://patchwork.linuxtv.org/project/linux-media/patch/20221017194413.11=
983
> 01-1-jernej.skrabec@gmail.com/
>=20
> I decided to take Jernej's patch first. Can you make a v2 that sits on top
> of that patch?

I believe you already merged first version of the patch for 6.1. No need fo=
r=20
this version though, first version already solves main issue.

Best regards,
Jernej

>=20
> Thanks!
>=20
> 	Hans
>=20
> On 9/14/22 17:01, Dmitry Osipenko wrote:
> > The cedrus_h265_skip_bits() may get into infinite loop if decoding
> > parameters are incorrect. In this case we detect the loop and print
> > a error message, continuing the decoding that is fated to fail.
> >=20
> > Will be cleaner to abort the decoding early. Propagate the error code
> > to cedrus_device_run() and reset hardware on the cedrus_h265_skip_bits()
> > failure.
> >=20
> > Suggested-by: Jernej =C5=A0krabec <jernej.skrabec@gmail.com>
> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > ---
> >=20
> >  drivers/staging/media/sunxi/cedrus/cedrus_dec.c  |  2 ++
> >  drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 15 ++++++++++++---
> >  drivers/staging/media/sunxi/cedrus/cedrus_hw.c   |  7 ++++++-
> >  drivers/staging/media/sunxi/cedrus/cedrus_hw.h   |  2 ++
> >  4 files changed, 22 insertions(+), 4 deletions(-)
> >=20
> > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
> > b/drivers/staging/media/sunxi/cedrus/cedrus_dec.c index
> > e7f7602a5ab4..ae5df3dc01c0 100644
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_dec.c
> > @@ -112,6 +112,8 @@ void cedrus_device_run(void *priv)
> >=20
> >  		dev->dec_ops[ctx->current_codec]->trigger(ctx);
> >  =09
> >  	} else {
> >=20
> > +		cedrus_hw_reset(dev);
> > +
> >=20
> >  		v4l2_m2m_buf_done_and_job_finish(ctx->dev->m2m_dev,
> >  	=09
> >  						 ctx-
>fh.m2m_ctx,
> >  						=20
VB2_BUF_STATE_ERROR);
> >=20
> > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c
> > b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c index
> > 4952fc17f3e6..f409f59452d8 100644
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus_h265.c
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h265.c
> > @@ -224,9 +224,10 @@ static void cedrus_h265_pred_weight_write(struct
> > cedrus_dev *dev,>=20
> >  	}
> > =20
> >  }
> >=20
> > -static void cedrus_h265_skip_bits(struct cedrus_dev *dev, int num)
> > +static int cedrus_h265_skip_bits(struct cedrus_dev *dev, int num)
> >=20
> >  {
> > =20
> >  	int count =3D 0;
> >=20
> > +	int err;
> >=20
> >  	while (count < num) {
> >  =09
> >  		int tmp =3D min(num - count, 32);
> >=20
> > @@ -235,11 +236,16 @@ static void cedrus_h265_skip_bits(struct cedrus_d=
ev
> > *dev, int num)>=20
> >  			     VE_DEC_H265_TRIGGER_FLUSH_BITS |
> >  			     VE_DEC_H265_TRIGGER_TYPE_N_BITS(tmp));
> >=20
> > -		if (cedrus_wait_for(dev, VE_DEC_H265_STATUS,
> > VE_DEC_H265_STATUS_VLD_BUSY)) +		err =3D cedrus_wait_for(dev,
> > VE_DEC_H265_STATUS, VE_DEC_H265_STATUS_VLD_BUSY); +		if=20
(err) {
> >=20
> >  			dev_err_ratelimited(dev->dev, "timed out=20
waiting to skip bits\n");
> >=20
> > +			return err;
> > +		}
> >=20
> >  		count +=3D tmp;
> >  =09
> >  	}
> >=20
> > +
> > +	return 0;
> >=20
> >  }
> > =20
> >  static void cedrus_h265_write_scaling_list(struct cedrus_ctx *ctx,
> >=20
> > @@ -408,6 +414,7 @@ static int cedrus_h265_setup(struct cedrus_ctx *ctx,
> > struct cedrus_run *run)>=20
> >  	u32 pic_order_cnt[2];
> >  	u8 *padding;
> >  	int count;
> >=20
> > +	int err;
> >=20
> >  	u32 reg;
> >  =09
> >  	sps =3D run->h265.sps;
> >=20
> > @@ -534,7 +541,9 @@ static int cedrus_h265_setup(struct cedrus_ctx *ctx,
> > struct cedrus_run *run)>=20
> >  	/* Include the one bit. */
> >  	count++;
> >=20
> > -	cedrus_h265_skip_bits(dev, slice_params->data_byte_offset * 8 -=20
count);
> > +	err =3D cedrus_h265_skip_bits(dev, slice_params->data_byte_offset * 8=
=20
=2D
> > count); +	if (err)
> > +		return err;
> >=20
> >  	/* Bitstream parameters. */
> >=20
> > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> > b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c index
> > a6470a89851e..e9ceca332062 100644
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c
> > @@ -168,11 +168,16 @@ void cedrus_watchdog(struct work_struct *work)
> >=20
> >  					=20
VB2_BUF_STATE_ERROR);
> > =20
> >  }
> >=20
> > +void cedrus_hw_reset(struct cedrus_dev *dev)
> > +{
> > +	reset_control_reset(dev->rstc);
> > +}
> > +
> >=20
> >  int cedrus_hw_suspend(struct device *device)
> >  {
> > =20
> >  	struct cedrus_dev *dev =3D dev_get_drvdata(device);
> >=20
> > -	reset_control_assert(dev->rstc);
> > +	cedrus_hw_reset(dev);
> >=20
> >  	clk_disable_unprepare(dev->ram_clk);
> >  	clk_disable_unprepare(dev->mod_clk);
> >=20
> > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.h
> > b/drivers/staging/media/sunxi/cedrus/cedrus_hw.h index
> > 7c92f00e36da..919c4475f0d7 100644
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.h
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.h
> > @@ -30,4 +30,6 @@ void cedrus_hw_remove(struct cedrus_dev *dev);
> >=20
> >  void cedrus_watchdog(struct work_struct *work);
> >=20
> > +void cedrus_hw_reset(struct cedrus_dev *dev);
> > +
> >=20
> >  #endif