Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp7924997rwi; Mon, 24 Oct 2022 23:26:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CNJGeLkf541BfEuEsOG1QkQoTiql4FAc5ZbTPRAh8ouDdMTBF8y1kHJKoPHDD9oECO9Bc X-Received: by 2002:a63:82c3:0:b0:46e:c4e4:f8cb with SMTP id w186-20020a6382c3000000b0046ec4e4f8cbmr15619811pgd.155.1666679184823; Mon, 24 Oct 2022 23:26:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666679184; cv=none; d=google.com; s=arc-20160816; b=GgdLOzgZeSGPpLwNwQM5/n2EhacC0XBYy4jJhXAkQqjb74BYLd+4ETb8X73+58yalr EecjVPMzLfhN01xwY9mByfjcMN+QApxe30wZcbTF289CWEL41+q0511fdPybXr0LLD0Q JCcb7PBSi48ovsS17r6sLvEJg6HE1Z0J2LMUN/+3PLdImtMaUn6GiKNyPGrHiiB2k+GP CfOA4d1VwJ4BR/87MNov6jZa4EhZxCoYlPPw/RBu1AxBHWwmnc7jLxZOmswtPP7HjKGV yz2fRC6FrYkRnMKIOAruk96Tg3wG1EJiDBWQvpAYePCDNdgvNdcYi0EjPE2Wwivi4IoE +bmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fFrmI8K5lGuSst31g/cJjHTyF5NH3SrLB7GvM1NU+xc=; b=WkvaaClYYCRk89rT6b7d9uNPyTwysNiyD5qqyMDHHGP4wIF3f2Qz/gE3ds0+8TPHwO veH4lY1zUb7lUVfYEseYJp8r0zO1840F17jTla0xbJreynx7LG2mhxYmy7qOfS4gdESu BsnjfnjBeNhmJeU/Dh+Zc5AOtIlc6XDarDX7djFa4csFmYe7x7tlxZPmzmOFDYrMSvfz ++aKC908jFQBNu7xnmyj6R5MuCo/Zf0P34fJ1OnA0Ltk1h69BB8GvLsJjAWoM2j9UwUf MwDkF9Nb2VPzCmXgmy09CPRnQMiWPqHgRzBYXy5FiyNCrvfsvUW6WCeKI8ulCl/NMjRg YbmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=i0VJrI7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a170902f70800b00186881688f9si1906715plo.276.2022.10.24.23.26.12; Mon, 24 Oct 2022 23:26:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=i0VJrI7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230414AbiJYGLb (ORCPT + 99 others); Tue, 25 Oct 2022 02:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbiJYGL3 (ORCPT ); Tue, 25 Oct 2022 02:11:29 -0400 X-Greylist: delayed 65 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 24 Oct 2022 23:11:27 PDT Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net [185.136.65.225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E43186D873 for ; Mon, 24 Oct 2022 23:11:27 -0700 (PDT) Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 20221025061020ea657f904c29eba2e4 for ; Tue, 25 Oct 2022 08:10:20 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=fFrmI8K5lGuSst31g/cJjHTyF5NH3SrLB7GvM1NU+xc=; b=i0VJrI7xQzuVdDbAyuqhX+zWiPv9qjfAmctbxRStD5rp+d4TRYdVSCyuI5p+HLyavvaQsO RR4DU4o8qqZhBn4tqviQx6SD+4ws0dG9a1qUhoyd/KwfAH649w9X0vzA2uLCf8/fqs06ocnh Wn2GZla+5gJNG7poYXiGkuo3pJ34Q=; From: "D. Starke" To: pchelkin@ispras.ru Cc: daniel.starke@siemens.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, khoroshilov@ispras.ru, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, pavel@ucw.cz Subject: Re: [PATCH 2/2] Revert "tty: n_gsm: replace kicktimer with delayed_work" Date: Tue, 25 Oct 2022 08:10:06 +0200 Message-Id: <20221025061006.2311-1-daniel.starke@siemens.com> In-Reply-To: <20221008110221.13645-3-pchelkin@ispras.ru> References: <20221008110221.13645-3-pchelkin@ispras.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The revert looks correct from my point of view. I recommend to add it. Reviewed-by: Daniel Starke Best regards, Daniel Starke