Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 09:30:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jernej Skrabec <jernej.skrabec@gmail.com>
Cc:     mripard@kernel.org, paul.kocialkowski@bootlin.com,
        mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org,
        samuel@sholland.org, hverkuil-cisco@xs4all.nl,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/11] media: cedrus: Add helper for checking capabilities
Message-ID: <Y1eChJS/0aEchtpH@kadam>
References: <20221024201515.34129-1-jernej.skrabec@gmail.com>
 <20221024201515.34129-5-jernej.skrabec@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221024201515.34129-5-jernej.skrabec@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X7T9Hzptywp3UFpQW5WP0R4OYssWpleChV1ROVYoV7rL+/q5SZ0x6JD00lS+?=
 =?us-ascii?Q?t7IJxzV3vyzkOpJywvqkw4tlshGLv9M0zCMWqgOjxIivOMIiIBuC9mx8Ouha?=
 =?us-ascii?Q?z4ot/k3FJLFgMSD73vJubcQzzuxYZ/eE8LGq6gSOT0wx1z75CSntavbmw3G/?=
 =?us-ascii?Q?KIjG0/9p6Z6X5clTfcOy2ge/2bCnIxf0fSw/dHI01if9mnsUfU1h0cj4zqfn?=
 =?us-ascii?Q?CO1zOXGIFbfbOXjmypZuUP0TcaBBieFqSR4ZXy7UmOcRtEUwOg++nqolAwr9?=
 =?us-ascii?Q?SOxtOjRcuE8EGfZkyVXRBYschbPfOz/IkwuIHEKrTamOVsM3BQtwviRE8sBB?=
 =?us-ascii?Q?h0KRoa9qJib3JMBbh+bBD0BTzbx+RxWqLu5a/sJPRH+39TCqK3WVqYnEKihW?=
 =?us-ascii?Q?bT9/k9VcZxu3zV3KUFYH5ewAut9jfImpgeVYWK+AjU4LTNdyt4IyvbxaTBrx?=
 =?us-ascii?Q?OyZ32ZANnP4tr9m+rs60adDm8Qjkdcd+HryH/vP46OirQWj4o3FVh3RhYLXw?=
 =?us-ascii?Q?/D+zVbCG0indoAEFpB6D7nHNC5BMtvw4lRB2RIvMlVKezmHKxoQE3b+5E7EE?=
 =?us-ascii?Q?U5RJaOf7ZJZ2x7avry2pNlyQ2/rpIaiMvaR/cO63aH7S1B1JnGNAUkGo6yjj?=
 =?us-ascii?Q?ia6zWRr8aaF8y5PEZIM6goPK/XoHGfU8s3BaJIuE4iRbznA0QwZfbnQzQ/8N?=
 =?us-ascii?Q?gPGRqV7qEPmY9/3ZEIzjKWtVAcvBkagDP5qSmQG9cFoprsN03HD3reI/nm8S?=
 =?us-ascii?Q?FHUuVjNoPCOgjIjA/5qHUj6CaGJ+hwY0NwacODb4g6UHusKyeC50rmS1nhh1?=
 =?us-ascii?Q?JWgcjOU2gYZcgMITy60idhr4FdKWLhR0v1nVUtAIpwkwjLvnAGiApddDx1bi?=
 =?us-ascii?Q?WH/GHubh0xUbjxbotSrJoxYpFwaYbuX2nbymkmKdxcfHXSeNcUIZl/qnbPn/?=
 =?us-ascii?Q?rY0RQu/4rzJaDCtPU8Nn6EuikCC3pXpT5FQyGao73KUOw3+3IEknmP6rQ9vL?=
 =?us-ascii?Q?Krbg8QM452RTNqFqp1PwP/5AbrnPA0o/xg/06zZlgl+xr31v5ii4vniqNwLr?=
 =?us-ascii?Q?S4v7uVt+i8Do+dq6gOBMUueA/+WwwXxCossVcplIOcJdtbN67fbpmhBIc4Oa?=
 =?us-ascii?Q?3/wh62+yOHcigTLODbexHlCAFX2m0p4bvYA7F67ES0wiU2yZFHiYrjQ83PrQ?=
 =?us-ascii?Q?3k1Jf96cBaj8Pw3HFihyqNebG031Qun+9iPsPDzqBGc/nl0U9VHWBmsi/ZMT?=
 =?us-ascii?Q?Ma2OJIXVAWqVMdjDJo+tPKblGU+KbthzjvHRg3gfoBmCGEBkLJSmnxIbkY4Y?=
 =?us-ascii?Q?BBYlMuqiEibKZLWS6yHjQdq4FjeagvhvQfkkcjD3byOL75WodDv/Jmv+n9IF?=
 =?us-ascii?Q?WpKTOegU6L4fct0u7zmoSCO54bqgzhf+A3iHExY0w16mXhpgUXCz72tNhpem?=
 =?us-ascii?Q?sWWcn7zQVK+/lA62W4ncE2EbIwVfBGapY1fiI/rtEMsBVK4sXaheO0rX4Mjb?=
 =?us-ascii?Q?Oysy24pVcTtEiWlzs4tEC6IqUOiHr8w73Q2Bkhw6bSO3ap2buHqkR1Hc6W93?=
 =?us-ascii?Q?HMHup5WFMoVitkhGels9D+JqjAwnAvhyYAwZH+qEDLoQvMywvNUDTj3r9Uor?=
 =?us-ascii?Q?dQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5fd1c70-658a-4824-eabe-08dab6527179
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:30:43.6391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H/L5LBWd6IkwGsmwnAJLj1zvUw04RCyyxr5JxCYQvyZUzFIXa37Y9/KBzUAv0gOVCInJjUowJgZWUaJtP7JEcMzGolDSM5250Env3Ur5ciU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6531
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_01,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=907 phishscore=0
 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210250036
X-Proofpoint-ORIG-GUID: vT1g5M8MwHKfbccVRQcjqyWGbLmdcFNR
X-Proofpoint-GUID: vT1g5M8MwHKfbccVRQcjqyWGbLmdcFNR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 10:15:08PM +0200, Jernej Skrabec wrote:
> There is several different Cedrus cores with varying capabilities, so
> some operations like listing formats depends on checks if feature is
> supported or not.
> 
> Currently check for capabilities is only in format enumeration helper,
> but it will be used also elsewhere later. Let's convert this check to
> helper and while at it, also simplify it. There is no need to check if
> capability mask is zero, condition will still work properly.

Sure.  That's true.  Out of curiousity, can cedrus_formats[i].capabilities
be zero?  Because it feels like that's what should be checked.

regards,
dan carpenter