Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 09:19:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8192e: use explicitly signed char
Message-ID: <Y1eADgj7fLKegXDH@kadam>
References: <20221024163005.536097-1-Jason@zx2c4.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221024163005.536097-1-Jason@zx2c4.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7gCp0dGPI+0lpyzVj7s1vlevddZM8PaWJNzZOFwHDehC4qqgjRalsGRBnQVk?=
 =?us-ascii?Q?A3JaON5+loZexdExObQhJOgvS2/aVWPpFzF5fRR9i8TSYQ8HtYKlE1QdPtIJ?=
 =?us-ascii?Q?x1hHF2eWNF8JUsmwdht+p5FBpUrpKjNYx4dlzhLBQr6gJImowX5ag3fO1FlL?=
 =?us-ascii?Q?KrQ4pmjFDGbQ2hk37v2bQBWQ/GfSszE22zdU80AZgyESPqtC5H3XxaJf9aTA?=
 =?us-ascii?Q?g4MyKpXjby7wtqLsrC+yR3nqhCQ9PVoF6+noPC6iy08NAkgDW3F/YHXuPKJP?=
 =?us-ascii?Q?YV8Ex9mXGyqBg1H0Lbgk7SyOZ13jmOdrx/8M9GShbFJGaF06fAbKH1qJnmEE?=
 =?us-ascii?Q?tnpAe00aY3wE7l91XE1ZSc5/mD2cEcdSKVnuzX6s28E384Z8kmBEytlGyKFC?=
 =?us-ascii?Q?0OX2Am7eFG4mir7UZ+5afQJhG6/4nPFmJPcz8Ao8/BZD9KDQiJ6JwVfrfaoT?=
 =?us-ascii?Q?uBEnwWTLdJVAGaePpg8UMqh7MXJyPIkKX/l4/ZkXnwS2nCf1kf43UnxrDxEZ?=
 =?us-ascii?Q?rIkHSEBfCMNOBBNCtt1REn5xAMRaHoMWSvzni6S1iRHtFQNE5bI1eDPXDPV6?=
 =?us-ascii?Q?nzUvbXAaRku4fDSV7pxrkbLyBpRDcjKFVJqAPTGry7sE5n1rWrQSfiZqDyFm?=
 =?us-ascii?Q?Ve3zf7q+kbZtjzOa+KKE3oMzI/t0/eR4ek2scuUPJIb4aUDrpl86XwpWB7mI?=
 =?us-ascii?Q?bKvIAsXRi8RWOvrElagUBTrY+hKhqznbb7rJLYhjyyp2+0swiExtihtWmllB?=
 =?us-ascii?Q?PU/M6twxdSUKW9CHUGDiJBkT1wf7s/Bvw442JZdnS9i0cl9OTrXWoLmJtrQR?=
 =?us-ascii?Q?9tHBF7HiUkSshVi8f2WM/H0JsZR+oZOzvQqZKZRTy2QXb0SHGGWaFeu5xmRP?=
 =?us-ascii?Q?1DUaOpkHlJrVAhYUmiiTUJkA6P0CF1vCFpqde6lp8oXbwLNSq3/WYecXQZU6?=
 =?us-ascii?Q?5XDJNYW6BLIskOZPaUqPsYXeYMZOeEnEUKLFR8bvePfqiZrZWoFnIuiE5jTz?=
 =?us-ascii?Q?QxKFXpayj4y2zzEHnFMDFS61qnZi4sLa1FhN4krF5Zs7SSMKLzi0dSW2Pwdw?=
 =?us-ascii?Q?9lWs9uMxmXzBAS85TPm0/NCg7eeYkrp0ZMtqew1r4ITlUhI058p9Cbt8S6R/?=
 =?us-ascii?Q?AQo9BuCqTiETmwpoDP6igKeAm0uznr9K5C385N+oEpNua4I6ujbfsFu6i32e?=
 =?us-ascii?Q?IuzqFPKO9bD0zsaOwfC9TKgh0QaPX8KPTU6Ww73zEC0DaaJdlmKI5v95Jmjr?=
 =?us-ascii?Q?zfiIpS0jSZ5CZjKSzacVLJJO5GvBzdANLZU6RwKiHBwNnzAQmPyaTuk7B+sv?=
 =?us-ascii?Q?OiggHpcTVUivHifMx5EBST5sextkQqyjjkBzGpcvQt/nXDJPseIkQGm56cxV?=
 =?us-ascii?Q?fTiRj8+ttB/+IS4bLvgeSBQtC1QBQ5YJXwVJBsrKr1L8XAKqqSaH38ClsIJP?=
 =?us-ascii?Q?Uan91D1iVuMWnBQ/yWhoaS8n3+6cywuuODe6W0ncD8/1hdZKEbtvhdev3Mha?=
 =?us-ascii?Q?NGqxPifPYEY5NqdIdRceM5uYl6eVNUgHtxNDs+v3oqGZLcTG9dXPJw00sNIP?=
 =?us-ascii?Q?PaH5vV8v1MO5wpJRenc30COye7XQmvjuHYWh/FQwheQTYXGvUEw+rTQNiaM/?=
 =?us-ascii?Q?Aw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 950f01b3-65f4-4866-17b4-08dab650fc28
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:20:18.0626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /oaF6GxOPX5puUa6NmDRMzLgIGdvpd47FHpscSu0oVd3Z0sxh5GGD9sUl9bbx4JvdMwshJH9rGvpBrqUYJrltJ/t0JbPpqXIDNsS92C1flk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4836
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_01,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210250035
X-Proofpoint-GUID: Yq04WRj4a2eH4xIGG_EiDyR2iXNozAqh
X-Proofpoint-ORIG-GUID: Yq04WRj4a2eH4xIGG_EiDyR2iXNozAqh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 06:30:05PM +0200, Jason A. Donenfeld wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. In this case, passing `char *extra` is part of the
> iw API, and that extra is mostly intended to be somewhat opaque. So just
> cast to `s8 *` for the sign test. This fixes warnings like:
> 
> drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-staging@lists.linux.dev
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> index f9589c5b62ba..4563e3b5bd47 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> @@ -456,7 +456,7 @@ int rtllib_wx_set_essid(struct rtllib_device *ieee,
>  	}
>  
>  	for (i = 0; i < len; i++) {
> -		if (extra[i] < 0) {
> +		if (((s8 *)extra)[i] < 0) {

I agree with Linus that this if statement is nonsense and should just be
deleted.

regards,
dan carpenter

>  			ret = -1;
>  			goto out;
>  		}