Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 08:21:10 +0200
Message-ID: <87czags9t5.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: au88x0: use explicitly signed char
In-Reply-To: <CAHmME9q2JOGMKNrXqK7q=xfZdciy89P+GT0eGHVmVqOvKDYA8g@mail.gmail.com>
References: <20221024162929.536004-1-Jason@zx2c4.com>
        <Y1b/iNMncyKI/W5c@ZenIV>
        <CAHmME9q2JOGMKNrXqK7q=xfZdciy89P+GT0eGHVmVqOvKDYA8g@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 25 Oct 2022 01:59:50 +0200,
Jason A. Donenfeld wrote:
> 
> Hi Al,
> 
> On Mon, Oct 24, 2022 at 11:11 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > On Mon, Oct 24, 2022 at 06:29:29PM +0200, Jason A. Donenfeld wrote:
> > > With char becoming unsigned by default, and with `char` alone being
> > > ambiguous and based on architecture, signed chars need to be marked
> > > explicitly as such. This fixes warnings like:
> >
> > It might make sparse to STFU, but it does *not* resolve the underlying
> > issue:
> >
> > vortex_adb_checkinout() returns a number in range of 0..31 on success
> > and -ENOMEM on failure.  Quite a few callers don't bother to check...
> 
> Yea, I saw that. I assume that the places that don't check don't
> *need* to check. But maybe this driver is junk and other bugs lurk.
> I'm not sure. Either way, I think this change is certainly an
> improvement on the status quo. I don't intend to develop further on
> it, but feel free to send patches atop once this lands.

Yes, the driver is likely broken in some other way, too.
Such a corner case doesn't hit usually, and it's unlikely worth to
spend too much time on it.

In anyway, I applied the patch now to for-next branch.

Thanks!

Takashi