Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 09:57:38 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: rtl8712: check for alloc fail in
 _r8712_init_recv_priv()
Message-ID: <Y1eI4kTRSwEG+G6g@kadam>
References: <cover.1666645510.git.namcaov@gmail.com>
 <ce12408f17f90b3b368d077a7321a2a252f52b72.1666645510.git.namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce12408f17f90b3b368d077a7321a2a252f52b72.1666645510.git.namcaov@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g2Fc8joXAgqPprn+byF8z3QN8yqbfNZbkeLiLNsvwNnt4ohNBrEwpLLR9nB5?=
 =?us-ascii?Q?xurXypoTZ1wNjld3lFhRxGbIGUlsnT25i7wOBfSL1MTElbZ/cneYnTkZP5qv?=
 =?us-ascii?Q?HnUD5U/EPL9IpClGvfb3IBoreloMvZuFXJJhu0p2WK5MsOJywk567TivHaYG?=
 =?us-ascii?Q?bwDTAgWWfbNyNnzZk9B2PKrIsVV+0ZzzJZQBUVBnI3d526QwPJmfKx+QWXov?=
 =?us-ascii?Q?h/k1S9hqvS0OOpXsjLhYZBqPA3suXc9e8DiNZfUqaHtcrV2mXGte9GcDfVqp?=
 =?us-ascii?Q?AtcnC0hq9wOMcSmJ0ww5zVxjdIZzstto9vBUt5kqKr7YCbGp71FaGHv/aVBV?=
 =?us-ascii?Q?V5kNOi3d51RGoU6mkMtO7SbEfvNEpl1kErgWbgdHEh3vQPhHWBYimjRls1Rd?=
 =?us-ascii?Q?l3I2nAlUAH+nC0ZTrTFZjD9N3HKi3XfGeCAL7A8mQnnj01wg1FmyeBHHSNcO?=
 =?us-ascii?Q?omqRdAWhtVhlrXzbLoznnl9GNNffvyR4TAv9GoC7zaypeHhV2y8E1pQ5yFgE?=
 =?us-ascii?Q?4DgGpGLfmNaNKk9OOYn1XzRcilXDHm2h4CaUom2XD6bAcVJxOiVwnVvlgCnd?=
 =?us-ascii?Q?S+SYbFVKnx5PXTYqJwJDE8IV2DWBOWFAn9JYY2ra2QWZDBID11s7yjCHh+/J?=
 =?us-ascii?Q?QBblsl1vE2g885AyFpru0SNad5s4ksuQtAoD1jeJkkGMkrU8l4WLFtOMuPqD?=
 =?us-ascii?Q?+BFKPpsLfE8tEuQ326HYl1cRnOpY2Xp6VWDjZkKexdZK3tLISh3Mysju1qhe?=
 =?us-ascii?Q?plcCNijEj65u1s1/JG5SeIcu8AgqPkX6+iOLrBikxZuGo2u3GVDeKkXQHRGY?=
 =?us-ascii?Q?VNMSJweMUFX6iiIkUTCSS0SaUX5Wguef3VUQrgDQWh/cNqJZHtkr9OoOFadG?=
 =?us-ascii?Q?X1Uv7qfcLsm4R2gPF6I7aeXLjXNUdXyscGZaKnwhynlmRIWgXA1J65A66IKX?=
 =?us-ascii?Q?oYKe9eYvTSTp5kzMgY7ol46F7HNDXfnKPHBIvN7ZBsBzB+LoNYhXBr0YLWLU?=
 =?us-ascii?Q?lIbFg/xTQxwGFP7WWl/esKawI+4hKYc/1GryIP5urHh59cdBpuLPkW6sEL5S?=
 =?us-ascii?Q?8PqsfYbG4nUlgZ71TU/mj+iScIgowoerHCbbwpzAFGZ0poHp0NnRY5o1pnA0?=
 =?us-ascii?Q?wu4CbrBhNvWcifFsM4Lm5UcWUx0fDM/x1Ts1IWH0lJdxDsNgPkmSHAoN+Aaw?=
 =?us-ascii?Q?j4kpvjHxLsBoKw6hHtgk7EniMQX1sMAVphGpBTUdeFCMNeBz5PXCIOXrp8dK?=
 =?us-ascii?Q?5qDIyG4tPGjVv2nOxhu7ekr9thR+88I8hCdTpcxKDCqrhh+8KE1z7N4iZlmB?=
 =?us-ascii?Q?74pePUOVOk1FllXRmbFkhS+pA/P+Ob5uORu8CZz50hY4IQFOdzDwvQDcuMDG?=
 =?us-ascii?Q?Ik6zTxbTNox+doJqNrugpcUu8TIiLHKC7APAZIPshlU4qzJggl6RTj5UOK9B?=
 =?us-ascii?Q?vKj3UKCzD+JoleJnQRh/pIBqA47xsJizyR5p07Kr1JHz1FmQ+gXV+XTmLhcY?=
 =?us-ascii?Q?MX6RfuqSYV6t8e8PGRrqaaMwGQgV4h1V62Dp8Sj7iiwpGRCMcxN65oGbbLls?=
 =?us-ascii?Q?m3QxtO66GpSpTgGNWvSeiLmHwq3dET6B7e9n3RMPwO5snjETPEAjzrt4AxuR?=
 =?us-ascii?Q?DQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6182b29-b36d-4bb3-106b-08dab6563acc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 06:57:49.8741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hd5Fu7kJo6viJgg3BHrvySlVH5xTY4HKu6+37z1M21+jZ90JGqsX8dFMkW/eMc5dh0/7xVorpAgK8CRFnuGzCc9RmVyVXdGadjo5k08CRq8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6289
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-25_01,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=867 bulkscore=0
 suspectscore=0 malwarescore=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210250039
X-Proofpoint-ORIG-GUID: g6LuCB0MUixaEvZTijQJyxMUuRiM2Jpp
X-Proofpoint-GUID: g6LuCB0MUixaEvZTijQJyxMUuRiM2Jpp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 24, 2022 at 11:24:07PM +0200, Nam Cao wrote:
> The function _r8712_init_recv_priv() and also r8712_init_recv_priv()
> just returns silently if they fail to allocate memory. Change their
> return type to int and add necessary checks and handling if they return
> -ENOMEM
> 
> Signed-off-by: Nam Cao <namcaov@gmail.com>
> ---
>  drivers/staging/rtl8712/os_intfs.c     |  3 ++-
>  drivers/staging/rtl8712/recv_osdep.h   |  8 ++++----
>  drivers/staging/rtl8712/rtl8712_recv.c |  7 ++++---
>  drivers/staging/rtl8712/rtl871x_recv.c | 13 +++++++++----
>  4 files changed, 19 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index 003e97205124..47d7d998fa86 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -309,7 +309,8 @@ int r8712_init_drv_sw(struct _adapter *padapter)
>  	if (ret)
>  		return ret;
>  	_r8712_init_xmit_priv(&padapter->xmitpriv, padapter);
> -	_r8712_init_recv_priv(&padapter->recvpriv, padapter);
> +	ret = _r8712_init_recv_priv(&padapter->recvpriv, padapter);
> +		return ret;

If statement missing.

>  	memset((unsigned char *)&padapter->securitypriv, 0,
>  	       sizeof(struct security_priv));
>  	timer_setup(&padapter->securitypriv.tkip_timer,

regards,
dan carpenter