Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp8020790rwi; Tue, 25 Oct 2022 01:06:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6ODPqYwc/lMMTKXfhXOJ+xnbvtC388HGKKJNsxsG+R8mCrIi/UkFkJGF1QVhFwB2tEAOcw X-Received: by 2002:a17:907:8a24:b0:78d:cd60:1022 with SMTP id sc36-20020a1709078a2400b0078dcd601022mr30905448ejc.384.1666685186337; Tue, 25 Oct 2022 01:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666685186; cv=none; d=google.com; s=arc-20160816; b=s6Xh0ImrsVCj0oBSF3HAQIfYc3HL/EEtM5s2WU+aCczn7PAp7P1m2pORp9ZdCy3zWW nuQ+4Dotv+36ltyYuE1nX3ivKYdAmDcEhvd1zAms2LHbQJP2+1wywrYhEswxH/8156lV fjYQHAvnwon0ly9Zr0wGE/nAKHack2WeQ7YFQRT/CQjP/rHyJYq9VqkmmzzNzSus/qyc Aa+t54T70E9k95I/Nzv0U91nlKhrS4mVLGo0E6NoYtkd1tKdv6sjOCe+QTzQsqoHhZSz zaWogUTFdrkGYrjUTlDj6ridfbiGP+pQ/YCDCPSi/lONmtn47YGsZP77gQZ+TTNMnGix QDWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=PWYaEp6fQa69dMeRT/gHkfJr6Og5Rs74Qd9gOdPSHxc=; b=VcWHmaxBs7PY4V0xrxXwlClVgUUEw+BX56by8JF56xHTkb4c1dgtdzyEZuefsNJ2Sr R3+BkbnoZ5E7BfSm87y39/8rBiZtyqiOsAbZwWE0/+vtrhVs0racHGEPwxxEetQwd1gd 1hm23llAcT+c156ibYTdoSVbW6P60A8xLGhNAccNOomJRT6cji9/AlSuAGxjpnZxc2Kf nlx5u+tBGGmnkhTrsrrBnR64C+kcJr7CrDqKc20YFhj7cQucGBskzUEdxLlJ+N1S/WXU cj+dBArZShGPUKNtR6R9OITOMQUZrXK1Gf7wUxoZEo1cAPhAj7tSCM05X31NiffkCUdD /9NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp9-20020a1709071b0900b00782539a0286si2342098ejc.142.2022.10.25.01.06.01; Tue, 25 Oct 2022 01:06:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbiJYHQX (ORCPT + 99 others); Tue, 25 Oct 2022 03:16:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbiJYHQU (ORCPT ); Tue, 25 Oct 2022 03:16:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D4ACA8CFF for ; Tue, 25 Oct 2022 00:16:15 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onEAH-0005xX-AG; Tue, 25 Oct 2022 09:15:57 +0200 Received: from pengutronix.de (unknown [IPv6:2a01:4f8:1c1c:29e9:22:41ff:fe00:1400]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 7214C109279; Tue, 25 Oct 2022 07:15:55 +0000 (UTC) Date: Tue, 25 Oct 2022 09:15:51 +0200 From: Marc Kleine-Budde To: Dongliang Mu Cc: Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vincent Mailhol , Stefan =?utf-8?B?TcOkdGpl?= , Andy Shevchenko , Oliver Hartkopp , Sebastian =?utf-8?B?V8O8cmw=?= , Sebastian Andrzej Siewior , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Timo =?utf-8?B?U2NobMO8w59sZXI=?= , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] can: mcp251x: fix error handling code in mcp251x_can_probe Message-ID: <20221025071551.ghj2hhcxxdfcjbcp@pengutronix.de> References: <20221024090256.717236-1-dzm91@hust.edu.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qfguc5tuuzqidvwz" Content-Disposition: inline In-Reply-To: <20221024090256.717236-1-dzm91@hust.edu.cn> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qfguc5tuuzqidvwz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 24.10.2022 17:02:52, Dongliang Mu wrote: > In mcp251x_can_probe, if mcp251x_gpio_setup fails, it forgets to > unregister the can device. >=20 > Fix this by unregistering can device in mcp251x_can_probe. >=20 > Fixes: 2d52dabbef60 ("can: mcp251x: add GPIO support") > Signed-off-by: Dongliang Mu Applied to can/main. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --qfguc5tuuzqidvwz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmNXjSUACgkQrX5LkNig 013iJAf/TNNi8uXYP3ngYHUtPflKn8hjFygxbAR+D3nv23s1rExgBG84Wcw3y05f J7B9UcOa7xU5wmU7Yqcf3sin1+FBVqMIRbHnHhnq12lj3BTtpN1qVLdPBHPe24uV EjbPHEoxd5QsGXhN+/byiKIUQ7gIwYCZtvp/KDU3s7hzqct4c4mAk/lvKVwd4zwL 4FTZnA5bkJ7MeupPvKe3IXIfyuexfftIeP5Zlku2CKxYNr/fFoCiGvXm2G1F+RXT oUmqWTPs0SLQi+5kl/7CL2B2KHFc/DuwLtJdbXI4MA/+OC+L09YRWrkHKqvXeZjE K/UmturqbBZov7tBrAMTSzZFg/tEEg== =32pt -----END PGP SIGNATURE----- --qfguc5tuuzqidvwz--