Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 09:44:24 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vivek Yadav <vivek.2311@samsung.com>
Cc:     rcsekar@samsung.com, wg@grandegger.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        pankaj.dubey@samsung.com, ravi.patel@samsung.com,
        alim.akhtar@samsung.com, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] can: mcan: enable peripheral clk to access mram
Message-ID: <20221025074424.udfltascaqjc6dhs@pengutronix.de>
References: <20221021095833.62406-1-vivek.2311@samsung.com>
 <CGME20221021102632epcas5p29333840201aacbae42bc90f651ac85cd@epcas5p2.samsung.com>
 <20221021095833.62406-5-vivek.2311@samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2636diqrfd4pgcj5"
Content-Disposition: inline
In-Reply-To: <20221021095833.62406-5-vivek.2311@samsung.com>
Precedence: bulk


--2636diqrfd4pgcj5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21.10.2022 15:28:30, Vivek Yadav wrote:
> When we try to access the mcan message ram addresses, make sure hclk is
> not gated by any other drivers or disabled. Enable the clock (hclk) before
> accessing the mram and disable it after that.
>=20
> This is required in case if by-default hclk is gated.

=46rom my point of view it makes no sense to init the RAM during probe.
Can you move the init_ram into the m_can_chip_config() function? The
clocks should be enabled then.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--2636diqrfd4pgcj5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmNXk9YACgkQrX5LkNig
012s4wgAgEvXknoIf4nkxglrh4BH7qZ19M3p2awqWomcLpkgCN0XfHo7NGFtd4pD
UABYD6nDQYc+aOPqQmDFfYVghWHXv5BvjLWuojiq5d9m6YLXw9zcPzBH3NcTlTV8
Unt4dCYLjDW3HAurEG5C4OA0/zyzaIezFtIil+UszYX19g/JEknxydnkxMsakrqH
Bwr0CUBmi3tytW1oWMpgpSh6VCbcH9XKzEP9OeXQtDyZZdOcNeJM6G/nJSecPV8j
rUogXNZcuHGqIp0rWsJV8bfjDK4fgfcntfznWgV+MN8V3X1vfmpKNmD6cqrAsj0O
eisHx4gR0CXKc+LzFJ2NCGWPjCl8dg==
=3bl7
-----END PGP SIGNATURE-----

--2636diqrfd4pgcj5--