Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp8031200rwi; Tue, 25 Oct 2022 01:18:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM62/bAefza5i2Xmj9tJIYZJC6hNKiM/n3LtHwyzccziMeIZe0eEa3MBin5ohFg/rZn8bjeX X-Received: by 2002:a05:6402:c07:b0:461:87ab:78aa with SMTP id co7-20020a0564020c0700b0046187ab78aamr13839354edb.258.1666685888557; Tue, 25 Oct 2022 01:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666685888; cv=none; d=google.com; s=arc-20160816; b=KjA9O6QFGJeFVo0ovaUGY9S+28ajuTeZ8lcV8cb240rHiDY2C37hy94u6f45/N9T7b rdQoaXnBs3jPU6A3HmMld4LrCLSq75PViNFgin7QTqCEKpVeiZKG3QEFJ/9ZhXXC6oF+ wicpCadrcYMvsML8wAIQthozYDGg3eVIVtQmgXHd02hE9VPsuanCEvfA39ak1bc6oFzP ofucEcyalmgzJU4pX/3rwkRH+NwD0ah/w/dAi2u+tQQW7P7pUWInWFLNKmFyD0lJ0YGM 5GN/xLuG+MXkH/udNaijdJ+jrHK0YW4pIwYGG4MuLR/8rXWv2GcjRzTt8wHjYLO+lpWd MKNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=bmTwj6OtS+qKGejwPsYen74GyvpkldNOmgs1vn0WEDk=; b=xLcoptvXNYHUcRUdgvEmZ/WVzd4RHUD85SIAQPRMkm/5rY9ZtSaqnvu8Gf66hqByM3 DS4cLT55TskvdVEnbZ0l1J4lm6Am22rHdIyjxf62BuI6V2JJCT1Ab1LLJ5Pj9T9QiE1L cGv/ViaWAqvz82s3OSGYxEQAk1hgNB66EmKe3N2A4nKpg5ltWud/nkDTzkI2ngXa3hZ9 zqdqQH0XllY6oraXKcrH80jNcqPXxuLNKXcBNqtoJi25wvcSt3a8khpD80tzxrZfgzPj pzX3uGXl9lWqQktcvR8alrnvbdnLEFD1Emua1ZCDsTapJcU6v5+jBvCF4Kruknk4wyxB zazA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a1709063b0200b0077951929341si1883763ejf.312.2022.10.25.01.17.42; Tue, 25 Oct 2022 01:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231717AbiJYHbV (ORCPT + 99 others); Tue, 25 Oct 2022 03:31:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbiJYHbS (ORCPT ); Tue, 25 Oct 2022 03:31:18 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E32F027CEE for ; Tue, 25 Oct 2022 00:31:15 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 56A3C1C0016; Tue, 25 Oct 2022 09:31:13 +0200 (CEST) Date: Tue, 25 Oct 2022 09:31:12 +0200 From: Pavel Machek To: Fedor Pchelkin Cc: Daniel Starke , Jiri Slaby , lvc-project@linuxtesting.org, Alexey Khoroshilov , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] tty: n_gsm: revert tx_mutex usage Message-ID: <20221025073112.GA1587@duo.ucw.cz> References: <3572970f-f40f-5410-651a-a5e019d328d8@ispras.ru> <20221008110221.13645-1-pchelkin@ispras.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <20221008110221.13645-1-pchelkin@ispras.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > As far as switching to tx_mutex turns out to have its own problems, > we suggest to revert it and to find another solution for the original > issue described in 902e02ea9385 ("tty: n_gsm: avoid call of sleeping > functions from atomic context"). We have lived with locking problems for a long time, and we really don't want data corruption. Reviewed-by: Pavel Machek Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY1eQwAAKCRAw5/Bqldv6 8nB0AJ9DaAxHYyT3R+w8Mzbayd0rp+dI7wCguS1jTN3LNAweNA0qFGXNw9sldW8= =q1lp -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--