Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 13:32:17 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, vadimp@nvidia.com
Cc:     vadimp@nvidia.com, rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "open list:MELLANOX ETHERNET SWITCH DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] thermal/drivers/mellanox: Use generic
 thermal_zone_get_trip() function
Message-ID: <Y1e7MRozZYSHgV0V@shredder>
References: <20221014073253.3719911-1-daniel.lezcano@linaro.org>
 <20221014073253.3719911-2-daniel.lezcano@linaro.org>
 <Y05Hmmz1jKzk3dfk@shredder>
 <cb44e8f7-92f6-0756-a622-1128d830291c@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cb44e8f7-92f6-0756-a622-1128d830291c@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TTNznXGWXiE5f0fi3znFI6XcDJfRvxN4SuavNvpOsAT4zM/alVv4c9cOBh4N?=
 =?us-ascii?Q?DF5d7HiIzmzUMBEhNncUeOdLIfYuk8gX7jZeAfE9n/8hVf2sUNm3EGcKAPH9?=
 =?us-ascii?Q?I5SZMB+OYtB6l9ZU2XXLDZamDexWM/PNUED6y1bvpTYAganl1a40cAA58IP6?=
 =?us-ascii?Q?c5IACs6U/BytKgD1cllLlnh66Kz4vmc/VPyAwSPrYb9QuQ2DkMGl/a1xjmtD?=
 =?us-ascii?Q?dJi33LZjZgs2vTCCziL8pkw8BcrC9/XZ0EgxYcWV9hQ3mslydUy3knzyKvMF?=
 =?us-ascii?Q?FayLYHzzs9BsDplqszO/C4vRFSDqQbsTLvtZ/CU97FFQ4kfulIrh8RgxRUFx?=
 =?us-ascii?Q?l8P27VaIKNRwABjxSUQ/mnzy5curobmDD/PkvZ4ibBky7sNZa8cf/rn21gFS?=
 =?us-ascii?Q?QnrUbXWVlIfzXvOALaea6acmOL71tT2CXxSBAXd55x7J8t2bf1YxkfVPIGBt?=
 =?us-ascii?Q?WzM87yZsyw0a/0gYz4RQNTw2Tv/c6zJ/XCv6IS3FmQkUQc9Bb101VRmqiwNa?=
 =?us-ascii?Q?NRaqQUXF4KCjLHvUiuQB6PI2VVVH+C1c315EtJHO1pgbbIr/WVuCLjXL6NKZ?=
 =?us-ascii?Q?WMM3d4jsHd4gpEq9kf8QLzAklA6DM4jUG+vvA1uh7D6eDCaWQxGDHmHwM2gd?=
 =?us-ascii?Q?SFRCXKI0K+2eUsQK7pyn7UAZ+rBXjifTou1QlxrPclWAfCCXdcmLjxWu/eE8?=
 =?us-ascii?Q?Mg3YXNKFNG0MWXe+wygIz6FkpbwJt1dU1XSnfObgBEuLIldtW/iI8DXO7bjV?=
 =?us-ascii?Q?TGJ6BJXCJfT3Wu4sIC+IJG6A4Bw718vGUFo1gbusHkdbUTA3t93tf55Z43Ve?=
 =?us-ascii?Q?ADhWEOndap2SlKy76V0DQe/1UpMYEFnJkJLjapbGL36swwKpJTjhiF5g18Jm?=
 =?us-ascii?Q?vdkx6pzSScixA3w0Ob/RzywA9qObg5af2RSUpB+tj07J691Avd2oPQ6ROtrm?=
 =?us-ascii?Q?IljT9htVpWvVfzcdczP8Pwf7SBSvcXxi2614fUm9MAPWRt6YN1wH2kefhDah?=
 =?us-ascii?Q?hPw8LvFJfZ2deiT5u5ug8ZiLDscHOWp4WcPKDecEdl7zq+nTHU65LO2xtuqY?=
 =?us-ascii?Q?ta2waPTq0BgQ6AsZVdspuSvdCxAry3ABJ3Jib9Bx67pvRxGHdN8ADRQTgaXb?=
 =?us-ascii?Q?wA83Kv2jEGIavyxgldyiw9KgJTyZwAJEPrltiCooSdRbaT1q164ncWNL3T68?=
 =?us-ascii?Q?JHv3B8Ur0FYv/ynQ/cNDAA+y/ZhdZRspJM6XINQsXC4VvrH2szMmh7DrkyBs?=
 =?us-ascii?Q?qIzcrVufK/Dy5noGna3BBk9AMBAZVjZ6qezwSatbve6w966LGtL7536agB6M?=
 =?us-ascii?Q?1OK4XVBHESijblMAfWnqRq3QqVwx2XeXJ5FT5dfv4rfUkZLD6giaAMk3Guho?=
 =?us-ascii?Q?YFDugsd45ORlbEz6/AM3u/jhurUQJJphHAv2GDcCOyJGMsakpdxSPNAlH6ju?=
 =?us-ascii?Q?p1IdYJ+U42YeLzAImJPLSgulfvV0SjejIuqPqCbhTPmvX/k9owKX/m4gx53H?=
 =?us-ascii?Q?MKHCafsvxQaS6oNiEca+m3Gs5nRkVHqDzFZLRkk3CKydQjUgiRHQT0X78yTZ?=
 =?us-ascii?Q?2+X2BFlx+5VjlD973lwcLhkkKWqAkHDj+5pIDiSR?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef4fa522-19d5-4638-6a6a-08dab674357e
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 10:32:25.7536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fycMITTjiygbn5vcA8Sj3taYkFiJxKhw57sq3AECHguNRsWXpcNcHcYzo00+nvraaibaVctIq9jd3bffKMOJEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7072
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 25, 2022 at 09:02:23AM +0200, Daniel Lezcano wrote:
> Because I hope I can remove the ops->get_trip_ ops from thermal_ops
> structure before the end of this cycle.

OK. Vadim, any chance you can review the patch?

> May be you can consider moving the thermal driver into drivers/thermal?

I don't think it's worth the hassle (if possible at all). In practice,
this code is upstream for almost six years and IIRC we didn't have any
conflicts with the thermal tree. I don't expect conflicts this cycle
either.