Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221025101828.1626490-1-ecurtin@redhat.com> <20221025104833.io3spnxw7724vlhb@begin>
In-Reply-To: <20221025104833.io3spnxw7724vlhb@begin>
From:   Eric Curtin <ecurtin@redhat.com>
Date:   Tue, 25 Oct 2022 12:08:08 +0100
Message-ID: <CAOgh=FwFHrLc3kmjVD49cVoRcfhtPFAqKrO5U_RE6FYVV2zXTw@mail.gmail.com>
Subject: Re: [PATCH] speakup: include types.h so u_char is a known type
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Eric Curtin <ecurtin@redhat.com>, gregkh@linuxfoundation.org,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>,
        "open list:SPEAKUP CONSOLE SPEECH DRIVER" <speakup@linux-speakup.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 25 Oct 2022 at 11:54, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> Hello,
>
> Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:
> > Fixes build of utils.h header file, occurred when building kernel on
> > postmarketOS on Lenovo Duet Chromebook.
> >
> >   drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
> >      57 |         u_char *pn = (u_char *)name;
> >         |         ^~~~~~
> >         |         char
> >
>
> There is already a patch pending commit that just replaces it with
> unsigned char.

Sorry I missed that. that works for me :)

>
> (see
> Subject: [PATCH] speakup: replace utils' u_char with unsigned char
> )
>
> Samuel
>