Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 12:48:33 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Eric Curtin <ecurtin@redhat.com>
Cc:     gregkh@linuxfoundation.org, William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>,
        "open list:SPEAKUP CONSOLE SPEECH DRIVER" <speakup@linux-speakup.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] speakup: include types.h so u_char is a known type
Message-ID: <20221025104833.io3spnxw7724vlhb@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Eric Curtin <ecurtin@redhat.com>, gregkh@linuxfoundation.org,
        William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>,
        Kirk Reiser <kirk@reisers.ca>,
        "open list:SPEAKUP CONSOLE SPEECH DRIVER" <speakup@linux-speakup.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20221025101828.1626490-1-ecurtin@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221025101828.1626490-1-ecurtin@redhat.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Hello,

Eric Curtin, le mar. 25 oct. 2022 11:18:24 +0100, a ecrit:
> Fixes build of utils.h header file, occurred when building kernel on
> postmarketOS on Lenovo Duet Chromebook.
> 
>   drivers/accessibility/speakup/utils.h:57:9: error: unknown type name 'u_char'; did you mean 'char'?
>      57 |         u_char *pn = (u_char *)name;
>         |         ^~~~~~
>         |         char
> 

There is already a patch pending commit that just replaces it with
unsigned char.

(see
Subject: [PATCH] speakup: replace utils' u_char with unsigned char
)

Samuel