Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp8270971rwi; Tue, 25 Oct 2022 04:50:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OfYlmuudFfvaktJcTcycUejOszM8fyxIYFOfpoyLDF3+2f0DHEIWv88bOjkWznSYJSy4S X-Received: by 2002:a17:902:7296:b0:180:1330:b3c0 with SMTP id d22-20020a170902729600b001801330b3c0mr37438903pll.170.1666698613252; Tue, 25 Oct 2022 04:50:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666698613; cv=none; d=google.com; s=arc-20160816; b=B5M/K2+K7erU+/5QtQBpAwZCH3IFyTcb4NVsTr6I8uRVo3CD9228Ncx8YcbKvQCvRY BMJZO6SID6ARa00b65++ZRGZ0TI+6DQMxvf6kQagS0lBlKcC7t7lRShMSD56S5y/EC5+ qU4pywVxcFEdZlJ/QRok01ran9TrG6Ru0v/IZoaFfLEUioRMNZTXvQJ1hPY/jt3d5YRi Yrza1a7DsBx7lACEkqCkmOJtPodnyFNRMhdnxljmIPeBfLvmFQTdPy07MW9+ughsLYPu DaHEJPs5OrPYQKVaBAXpKFUKaPcnn5fEN2+2XOeIqYKCWpN1RTfGwdvfmILBs6NnoJTf gXDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ZOARB5+HWYxKkIKHJ2AGeMLtbslz4P+kiY3dRjaFYLU=; b=BsHQFAR26o7w8a85O2PWC9rI1k/LlGJIekjYkdDvgdSQezHPdbbbTP9gKLAVKX5n0H i/1avo5o88lt+DUuXCX3IPg/PPuzSmQcCnDfUluxEQKyqzHz7WMF40hDTe0TtfPZBxWR 99toXT8dPAFMr2dwR8wxtVtVUPLORZxn63cbjlpjexkybiP0iF7VsemGU3E8LhzMrkni 6X3Fx4f2CK/UYJApnBRuQYz/CzppdbJv3anJCZABzx7Ys7VXNw2R+kvZ1CzcsbgC3rTd Cm0wl0ec/YprZ40eak9j89ngOXITmCL2tEocZ4ENncB/1fpAfAylmRuFl5dMhkHmEoOA A3Bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020a170902f0d400b001729cfb3cb5si2345573pla.610.2022.10.25.04.50.00; Tue, 25 Oct 2022 04:50:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbiJYLrt (ORCPT + 99 others); Tue, 25 Oct 2022 07:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbiJYLrs (ORCPT ); Tue, 25 Oct 2022 07:47:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 261BA7963B for ; Tue, 25 Oct 2022 04:47:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E885F618E8 for ; Tue, 25 Oct 2022 11:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C58AAC433D6; Tue, 25 Oct 2022 11:47:43 +0000 (UTC) Date: Tue, 25 Oct 2022 07:47:54 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Rafael Mendonca , Alexei Starovoitov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fprobe: Check rethook_alloc() return in rethook initialization Message-ID: <20221025074754.0e66cd76@gandalf.local.home> In-Reply-To: <20221025170346.2fbd0158e98882dd09812431@kernel.org> References: <20221025031209.954836-1-rafaelmendsr@gmail.com> <20221025170346.2fbd0158e98882dd09812431@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Oct 2022 17:03:46 +0900 Masami Hiramatsu (Google) wrote: > On Tue, 25 Oct 2022 00:12:08 -0300 > Rafael Mendonca wrote: > > > Check if fp->rethook succeeded to be allocated. Otherwise, if > > rethook_alloc() fails, then we end up dereferencing a NULL pointer in > > rethook_add_node(). > > Good catch! > > Acked-by: Masami Hiramatsu (Google) > Acked-by: Steven Rostedt (Google) Masami, feel free to pull this in. -- Steve