Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Aleksey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        "minchan@kernel.org" <minchan@kernel.org>,
        "ngupta@vflare.org" <ngupta@vflare.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v1] zram: add size class equals check into recompression
Thread-Topic: [PATCH v1] zram: add size class equals check into recompression
Thread-Index: AQHY56FoneIKBPF3rEq28K0jaPH8QK4eJ6gAgAADEgCAAIHKAIAABYEAgAAd1wA=
Date:   Tue, 25 Oct 2022 11:55:51 +0000
Message-ID: <20221025115542.5o4igroslirn6cxy@cab-wsm-0029881.lan>
References: <20221024120942.13885-1-avromanov@sberdevices.ru>
 <Y1dBpLDf+mRH6cLf@google.com> <Y1dEOLjD+kpdz0Vo@google.com>
 <20221025094859.7kbcqknlkmo4hj2y@cab-wsm-0029881.lan>
 <Y1e1tvMMXU5+8JQP@google.com>
In-Reply-To: <Y1e1tvMMXU5+8JQP@google.com>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <01B5ABE957561B48AAA2754E64A57C61@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

On Tue, Oct 25, 2022 at 07:08:54PM +0900, Sergey Senozhatsky wrote:
> On (22/10/25 09:49), Aleksey Romanov wrote:
> > On Tue, Oct 25, 2022 at 11:04:40AM +0900, Sergey Senozhatsky wrote:
> > > On (22/10/25 10:53), Sergey Senozhatsky wrote:
> > > > > +unsigned int zs_get_class_size(struct zs_pool *pool, unsigned in=
t size)
> > > > > +{
> > > > > +	struct size_class *class =3D pool->size_class[get_size_class_in=
dex(size)];
> > > > > +
> > > > > +	return class->size;
> > > > > +}
> > > > > +EXPORT_SYMBOL_GPL(zs_get_class_size);
>=20
> I wonder if we want to return class->index instead of class->size?
>=20
> Something like this (a sketch)
>=20
>   Return: the index of the zsmalloc &size_class that hold objects of the
>   provided size.
>=20
> unsigned int zs_lookup_class_index(struct zs_pool *pool, unsigned int siz=
e)
> {
>         struct size_class *class =3D pool->size_class[get_size_class_inde=
x(size)];
>=20
>         return class->index;
> }

Sure. I think it would be more logical, and perhaps such a function
would be more applicable in other cases, in the future.

Will you fix it in your cherry-pick?

--=20
Thank you,
Alexey=