Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 25 Oct 2022 15:14:09 +0200
Message-ID: <87a65kqc4e.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char
In-Reply-To: <87czagqc8k.wl-tiwai@suse.de>
References: <202210250456.vKv5zoLb-lkp@intel.com>
        <20221025000313.546261-1-Jason@zx2c4.com>
        <87bkq0s9rw.wl-tiwai@suse.de>
        <Y1fRvWfcU4NT1HTU@zx2c4.com>
        <87fsfcqdbx.wl-tiwai@suse.de>
        <CAHmME9qkJk0vH2n7gz1XFyo-W5EMffGA6Hd4Fd8twKSRWz12nA@mail.gmail.com>
        <87czagqc8k.wl-tiwai@suse.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 25 Oct 2022 15:11:39 +0200,
Takashi Iwai wrote:
> 
> On Tue, 25 Oct 2022 14:54:54 +0200,
> Jason A. Donenfeld wrote:
> > 
> > On Tue, Oct 25, 2022 at 2:48 PM Takashi Iwai <tiwai@suse.de> wrote:
> > >
> > > On Tue, 25 Oct 2022 14:08:29 +0200,
> > > Jason A. Donenfeld wrote:
> > > >
> > > > On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote:
> > > > > On Tue, 25 Oct 2022 02:03:13 +0200,
> > > > > Jason A. Donenfeld wrote:
> > > > > >
> > > > > > With char becoming unsigned by default, and with `char` alone being
> > > > > > ambiguous and based on architecture, signed chars need to be marked
> > > > > > explicitly as such. This fixes warnings like:
> > > > > >
> > > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned
> > > > > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)'
> > > > > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned
> > > > > >
> > > > > > Cc: Jaroslav Kysela <perex@perex.cz>
> > > > > > Cc: Takashi Iwai <tiwai@suse.com>
> > > > > > Cc: alsa-devel@alsa-project.org
> > > > > > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > > > >
> > > > > Applied now.  Thanks!
> > > >
> > > > Thanks. For this and the other patch, applied for 6.1 or 6.2?
> > >
> > > I applied for 6.2.  Was it an action that has to be fixed for 6.1?
> > > If so, I still can shuffle.
> > 
> > Well, this is code that's broken currently on ARM platforms, for
> > example, where char is already unsigned. So it's arguably a fix for
> > 6.1.
> 
> Fair enough, I'll apply for 6.1, then.

... and in that case, it deserves for Cc-to-stable, IMO, as it's a fix
to be done for older kernels, too.  Then it'd be clearly a 6.1
material.


Takashi